Tan Wang Leng
|
347dc835b5
|
Fix code formatting
|
2017-02-09 21:51:11 +08:00 |
|
Tan Wang Leng
|
a4a71a1dc9
|
Change qualifier of ShowSaveDialog() parameter
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
|
2017-02-09 21:50:55 +08:00 |
|
Tan Wang Leng
|
72723646dd
|
Add tests to check errors in parameters
|
2017-02-09 21:23:02 +08:00 |
|
Tan Wang Leng
|
9423143211
|
Change the default value of showsTagField to true
The default value of showsTagField in macOS's NSSavePanel is true.
Therefore, in order to follow the standard behavior and not break
backwards-compatibility, let's change the default value of
showsTagField to true.
Reference:
https://developer.apple.com/reference/appkit/nssavepanel/1525589-showstagfield?language=objc
|
2017-02-09 21:01:40 +08:00 |
|
Tan Wang Leng
|
b0487b7d84
|
Fix wrong signature for gtk's ShowSaveDialog()
|
2017-02-09 20:10:57 +08:00 |
|
Tan Wang Leng
|
1bf8270c0d
|
🏁 Fix dialog method calls for Windows
|
2017-02-09 20:10:57 +08:00 |
|
Tan Wang Leng
|
8843fef065
|
📝 Update docs for new attributes in showOpenDialog()
|
2017-02-09 20:10:57 +08:00 |
|
Tan Wang Leng
|
36209ddd90
|
🍎 Add additional options for Mac's open dialog
Support an additional attributes available in macOS's NSOpenPanel:
message.
|
2017-02-09 20:10:57 +08:00 |
|
Tan Wang Leng
|
cc22149beb
|
📝 Update docs for new attributes in showSaveDialog()
|
2017-02-09 20:10:57 +08:00 |
|
Tan Wang Leng
|
1d612a12a1
|
🍎 Add additional options for Mac's save dialog
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
|
2017-02-09 20:10:57 +08:00 |
|
Kevin Sawicki
|
9163b601a4
|
Merge pull request #8636 from electron/update-certificate-verifier-specs-for-linux-ci
Allow multiple verification results in specs
|
2017-02-08 13:56:59 -08:00 |
|
Kevin Sawicki
|
22b9c6e539
|
Allow multiple verification results
|
2017-02-08 13:33:07 -08:00 |
|
Kevin Sawicki
|
bad130f623
|
Merge pull request #7955 from deepak1556/veto-ssl-verify
session: provide chromium cert verification result to setCertificateVerifiy callback
|
2017-02-08 13:12:24 -08:00 |
|
Kevin Sawicki
|
18e15a1e53
|
Add spec for rejecting using old signature
|
2017-02-08 12:51:24 -08:00 |
|
Kevin Sawicki
|
1e581d6814
|
Use unique_ptr for passing VerifyRequestParams
|
2017-02-08 11:59:43 -08:00 |
|
Kevin Sawicki
|
70178adb6e
|
Use object for verification request
|
2017-02-08 11:59:43 -08:00 |
|
Kevin Sawicki
|
5245d42d15
|
Only document deprecation for now
|
2017-02-08 11:59:43 -08:00 |
|
Kevin Sawicki
|
9c134e7bf3
|
Assert certificate error
|
2017-02-08 11:59:43 -08:00 |
|
Kevin Sawicki
|
6b56dfd94b
|
Add spec for remote callback length
|
2017-02-08 11:59:43 -08:00 |
|
Kevin Sawicki
|
37db804099
|
Use NetLogWithSource since BoundNetLog no longer exists
|
2017-02-08 11:59:43 -08:00 |
|
Greg Nolle
|
e29b64a18a
|
modify CertVerifier Class
* respond to multiple similar verification requests.
* accept net error result as callback response.
|
2017-02-08 11:59:43 -08:00 |
|
Kevin Sawicki
|
d00a96ce35
|
Merge pull request #8618 from electron/forward-this-in-require-wrapper
Forward `this` in require wrapper
|
2017-02-08 10:33:48 -08:00 |
|
Kevin Sawicki
|
e9226aa354
|
Assert test.coffee outside of doesNotThrow
|
2017-02-08 09:02:46 -08:00 |
|
Kevin Sawicki
|
c1773a2c94
|
Add coffee-script dependency to specs
|
2017-02-08 09:00:14 -08:00 |
|
Kevin Sawicki
|
090255c3f4
|
Upgrade node for require wrapper this fix
|
2017-02-08 09:00:14 -08:00 |
|
Kevin Sawicki
|
84f8bfbdef
|
Add spec for registering/requiring Coffeescript
|
2017-02-08 09:00:14 -08:00 |
|
Kevin Sawicki
|
83d31cefeb
|
Merge pull request #8626 from dengyaolong/master
complete download-item translation docs
|
2017-02-08 08:50:26 -08:00 |
|
Cheng Zhao
|
5cd18fe32a
|
Merge pull request #8619 from electron/mac-os-version-checks
Use IsAtLeastOS10_* version checks
|
2017-02-08 13:58:26 +09:00 |
|
dengyaolong
|
0748f4fef2
|
complete download-item translation docs
|
2017-02-08 12:38:08 +08:00 |
|
Kevin Sawicki
|
f9b319e4f8
|
Merge pull request #8624 from electron/disable-file-icon-specs-on-linux
Disable getFileIcon specs on Linux CI
|
2017-02-07 18:30:00 -08:00 |
|
Kevin Sawicki
|
ba03f04017
|
Disable getFileIcon specs on Linux CI
|
2017-02-07 18:24:35 -08:00 |
|
Cheng Zhao
|
0643d98d99
|
Merge pull request #8616 from electron/renew-symbol-trick
Simplify the trick used for referencing symbols
|
2017-02-08 07:56:28 +09:00 |
|
Kevin Sawicki
|
4630f4488e
|
Merge pull request #7851 from YurySolovyov/image-from-icon
Add an API to fetch file icon
|
2017-02-07 11:37:06 -08:00 |
|
Kevin Sawicki
|
82ac4ddf19
|
Large is only 48x48 on Linux
|
2017-02-07 11:20:27 -08:00 |
|
Kevin Sawicki
|
fc1b7431c7
|
Tweak optional syntax
|
2017-02-07 10:35:31 -08:00 |
|
Kevin Sawicki
|
a4277bb616
|
Document sizes
|
2017-02-07 10:33:44 -08:00 |
|
Kevin Sawicki
|
dddc6aec49
|
Tweak spec descriptions
|
2017-02-07 10:21:20 -08:00 |
|
Kevin Sawicki
|
683a758dab
|
Call done instead of skip
|
2017-02-07 10:16:09 -08:00 |
|
Kevin Sawicki
|
ee66776450
|
Update IconManager for Chrome 56 upgrade
|
2017-02-07 10:15:46 -08:00 |
|
Yury Solovyov
|
a9dae243b4
|
Fix large icon spec
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
c810e64fda
|
Fix doc lint
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
bcf0964c61
|
Fix more review
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
2b60df3d8b
|
Fix some feedback
|
2017-02-07 09:55:18 -08:00 |
|
Yury Solovyov
|
29452364f3
|
Use isolate() method to get isolate
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
c36cdb8580
|
Properly skip large size test on macOS
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
1aa4fcae08
|
Lint tests
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
00748889f9
|
Add tests
|
2017-02-07 09:54:22 -08:00 |
|
Yury Solovyov
|
c2bf5bb986
|
Put locker and handle scope to the top of the function. Remove unneeded header
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
11ef2c539b
|
Update docs
|
2017-02-07 09:53:34 -08:00 |
|
Yury Solovyov
|
5794138ed4
|
Normalize path
|
2017-02-07 09:53:34 -08:00 |
|