Cheng Zhao
c9b53a6e8b
Merge pull request #3240 from atom/reland-win-remove-wildcard-extension
...
Reland win remove wildcard extension
2015-10-27 20:52:43 +08:00
Haojian Wu
f69bafd48a
Win: Fix adding '.*' to filename in callback.
2015-10-27 20:15:43 +08:00
Haojian Wu
fa24e15d8b
Win: Remove adding '*.*' to file name in a save dialog.
2015-10-27 20:15:20 +08:00
Cheng Zhao
dacd921a04
Revert "Win: Remove adding default file filter(*.*) in a save dialog."
...
This reverts commit 00493f64b7
.
2015-10-27 14:58:44 +08:00
Cheng Zhao
3042f604cc
Merge pull request #3234 from atom/win-remove-default-filter
...
Win: Remove adding default file filter(*.*) in a save dialog.
2015-10-27 14:30:35 +08:00
Haojian Wu
00493f64b7
Win: Remove adding default file filter(*.*) in a save dialog.
2015-10-27 13:10:34 +08:00
Brandon Cash
60b14d03e9
Fix: tray NotfiyDropFiles typo
2015-10-18 00:32:13 -05:00
Cheng Zhao
3b1ee994e2
views: Remove hack on setting min/max size for frameless window
2015-10-05 20:37:08 +08:00
Cheng Zhao
a76ea00249
views: Implement NativeWindow::SetSizeConstraints
2015-10-05 20:07:20 +08:00
Cheng Zhao
2b9b4c6789
Merge pull request #2979 from etiktin/fix_calculating_min_max_4_frameless
...
Fix calculating min/max size in frameless view
2015-10-05 15:10:27 +08:00
Eran Tiktin
c34c123b33
Make it work only on Windows
...
Limiting the solution to Windows only.
2015-10-05 04:01:25 +03:00
Cheng Zhao
add9c38023
linux: Enable force showing menubar
...
This is for debugging purpose.
2015-10-04 16:33:03 +08:00
Eran Tiktin
aea1f8aebb
Fix calculating min/max size in frameless views
...
The minimum and maximum size that frameless windows had used, was
incorrect. It included the border, so when it was called it actually
added that to the size, so window increased in size. The fix makes sure
that the view will use the frameless size.
This fixes #2945 and partially fixes #1806 (it also refers to some other
issues with hidpi which might still exist).
2015-10-03 22:09:57 +03:00
Eran Tiktin
6dcc752f67
Set default extension in Windows file dialog
...
On Windows when you open the save dialog and switch the filter, the
extension is supposed to change accordingly. It didn't happen with the
existing code, since the existing code didn't set the default extension
(should be set to the first filter).
This resolves #2915 .
2015-09-28 02:12:47 +03:00
Cheng Zhao
9b1fa04988
win: Fix building
2015-09-24 12:01:57 +08:00
Paul Betts
b0e5039951
Fix initializer
2015-09-23 11:26:57 -07:00
Paul Betts
22e6f15795
Remove GUID from Shell_NotifyIcon calls
...
https://github.com/atom/electron/issues/2468#issuecomment-142684129 has
the details
2015-09-23 11:20:26 -07:00
Cheng Zhao
84ce441fb6
Add converters for WebInputEvent
2015-09-18 13:33:06 +08:00
Cheng Zhao
53b9d61831
Fix building on Windows
2015-09-03 20:07:29 +08:00
Cheng Zhao
4254eb279f
Fix API changes on Linux
2015-09-03 17:50:23 +09:00
Cheng Zhao
45491ca7ab
Fix API changes
2015-09-03 17:50:23 +09:00
Cheng Zhao
d830badc57
Add role property for MenuItem
2015-09-02 09:42:17 +08:00
Cheng Zhao
3e5449561f
Merge pull request #2595 from atom/mac-tray-quick-click
...
mac: make tray's behavior more official when getting clicked quickly multiple times.
2015-08-26 17:18:51 +08:00
Haojian Wu
2b051e3884
mac: make tray's behavior more official when getting clicked quickly
...
multiple times.
2015-08-26 16:28:22 +08:00
Cheng Zhao
da10df3a9a
Merge pull request #2556 from etiktin/fix_msg_box_no_close_btn
...
Fix message box missing a close button on Windows
2015-08-25 13:57:24 +08:00
Eran Tiktin
9232620023
Fixed comment spacing
2015-08-22 04:26:09 +03:00
Eran Tiktin
b1406fbad9
Fix no close button in message box on Windows
...
This resolves #2293 .
2015-08-22 04:20:52 +03:00
Haojian Wu
5f663dbf0a
mac: make * extension filter works.
2015-08-21 12:15:20 +08:00
Haojian Wu
c566ba575f
Linux: make * extension filter works.
2015-08-21 12:13:33 +08:00
Paul Betts
0efdb448b6
Merge pull request #2509 from atom/fix-win-tray
...
Correct generation of GUID on Windows.
2015-08-17 09:02:21 -07:00
Haojian Wu
763dcc545d
Correct generation of GUID on Windows.
2015-08-17 13:20:36 +08:00
Cheng Zhao
33eadad139
popContextMenu => popUpContextMenu
2015-08-10 13:00:15 +08:00
Cheng Zhao
225140bd64
win: Don't emit right-clicked event when there is menu attached
2015-08-10 12:52:55 +08:00
Cheng Zhao
58dee04d5c
mac: Redraw icon when menu is closed
2015-08-10 12:52:35 +08:00
Cheng Zhao
4b9ff309ec
Add our own MenuModel class
2015-08-10 12:39:05 +08:00
Cheng Zhao
a3f3a35fd1
mac: Don't emit "clicked" event if there is menu attached
2015-08-10 12:18:00 +08:00
Cheng Zhao
744059b8bd
Check button size
2015-08-06 15:22:17 +08:00
Cheng Zhao
454085eb95
Fix cpplint warning
2015-08-06 13:07:39 +08:00
Cheng Zhao
6e75af5c0f
Move SetOverlayIcon to TaskbarHost
2015-08-06 13:07:00 +08:00
Cheng Zhao
8da7803f3e
Save the taskbar object
2015-08-06 12:58:40 +08:00
Cheng Zhao
2d6f8350cb
Move SetProgressBar to TaskbarHost
2015-08-06 12:54:00 +08:00
Cheng Zhao
958658513c
Refactor code in taskbarHost
2015-08-06 12:44:07 +08:00
Cheng Zhao
a28f70e85c
Decouple TaskbarHost from NativeWindow
2015-08-06 11:10:34 +08:00
Cheng Zhao
8f8c3aef87
ThumbarHost => TaskbarHost
2015-08-06 10:30:22 +08:00
Cheng Zhao
39af10cc8d
Move thumbar_host_ from TreeHost to NativeWindow
2015-08-06 10:25:50 +08:00
Cheng Zhao
d175a68586
Add MessageHandlerDelegate
2015-08-06 10:15:27 +08:00
Haojian Wu
2f1cb8b52a
Expose NativeWindow.setThumbarButtons API to all platforms.
2015-08-05 22:30:05 +08:00
Haojian Wu
78eac4116c
Polish thumbar code.
...
* Fix a memory leak in thumbar initialization.
* Check the number of thumbar buttons, should be <= 7.
* Correct to check thumbar button click event.
2015-08-05 19:38:12 +08:00
Haojian Wu
dfd076a3e5
Move atom_desktop_window_tree_host_win to atom/browser/ui/win directory.
2015-08-05 13:55:06 +08:00
Haojian Wu
54af048f04
win: Add BrowserWindow.setThumbarButtons API.
2015-08-05 13:55:02 +08:00
Cheng Zhao
488a69d461
Merge pull request #2419 from atom/clean-native-window
...
Clean up NativeWindow code
2015-08-05 13:28:09 +08:00
Cheng Zhao
adbb909b39
Move ShouldUseGlobalMenuBar to x_window_utils
2015-08-05 13:16:03 +08:00
Cheng Zhao
dc60bfa885
Merge pull request #2410 from atom/pop_context_menu_issue
...
Check context menu when calling popContextMenu API.
2015-08-05 10:04:26 +08:00
Cheng Zhao
50f226e34e
win: Use app name as default title of message box
...
TaskDialogIndirect doesn't allow empty name, if we set empty title
it will show "electron.exe" in title.
2015-08-04 21:57:00 +08:00
Haojian Wu
613e5c77ea
Check context menu when calling popContextMenu API.
2015-08-04 19:45:44 +08:00
Cheng Zhao
be24d3e78c
mac: Make the tray icon behave more like the official one
2015-07-30 13:58:53 +08:00
Cheng Zhao
80f45f6226
Merge pull request #2370 from atom/osx-tray
...
Use NSImageView to draw tray icon.
2015-07-29 17:22:47 +08:00
Cheng Zhao
b2f03fc2d8
Add metaKey
2015-07-29 14:44:08 +08:00
Haojian Wu
45f5a10d5d
Use NSImageView to draw tray icon.
...
* Fixes Tempate image doesn't show correctly in dark mode.
* Fixes the tray icon is stretched showing in menubar.
* Fixes title color will not reversed in dark mode.
2015-07-29 13:45:01 +08:00
Cheng Zhao
d42fd6fc7e
win: Pass modifers in 'clicked' events
2015-07-29 13:10:51 +08:00
Cheng Zhao
74248253f5
win: Set GUID when getting icon's bounds
2015-07-29 12:55:44 +08:00
Cheng Zhao
9afa94f4b8
win: Implement double-clicked event
2015-07-29 12:36:01 +08:00
Cheng Zhao
edde653d60
Merge branch 'feature/modifiers-click-tray' of https://github.com/nishanths/electron into nishanths-feature/modifiers-click-tray
2015-07-29 12:19:17 +08:00
Cheng Zhao
0ca9dfbc12
Merge pull request #2337 from nishanths/feature/bounds-tray-dblclick
...
Send bounding Rect on tray double click events
2015-07-29 11:27:04 +08:00
Cheng Zhao
b08af89473
Style fix for #2328
2015-07-29 11:22:12 +08:00
Nishanth Shanmugham
a44f14d76e
Fix code formatting issues
2015-07-27 03:33:15 -07:00
Nishanth Shanmugham
74b4522195
Add keyboard modifiers payload to tray click events
...
* Add keyboard and mouse button bitsum to Tray click events payload
* Move getBoundsFromRect: to common event_util file
* Update documentation
2015-07-27 03:15:51 -07:00
Nishanth Shanmugham
99a8f29de9
Move event type functions to a common event_util file
2015-07-27 00:41:20 -07:00
Nishanth Shanmugham
f53995d555
Send bounding Rect on tray double click events
2015-07-25 20:56:35 -07:00
Paul Betts
5e61974c24
Set NIF_GUID if we have a GUID
2015-07-24 08:05:36 -07:00
Paul Betts
70feb08f84
Fix linting issues
2015-07-24 03:30:23 -07:00
Paul Betts
75b08f510e
Fix up namespaces
2015-07-24 03:27:15 -07:00
Paul Betts
08383a69ce
Propagate User App Model ID to Tray Icon
...
This PR prevents dozens of items showing up in the notification area
preferences when using Squirrel for Windows, by ensuring that
notification tray items are tied to the User App Model ID.
2015-07-24 03:10:03 -07:00
Cheng Zhao
73ded9d378
linux: Fix min/max size not working
2015-07-24 16:21:44 +08:00
Yifei Teng
8960aa956c
Only allow extensions explicitly specified by the user. Fixes #2296
2015-07-23 12:30:07 -07:00
Cheng Zhao
6c44553456
Show all buttons as custom buttons when noLink is specified
2015-07-23 17:34:35 +08:00
Cheng Zhao
cc2a9f617d
Add noLink option for showMessageBox
2015-07-23 17:25:37 +08:00
Cheng Zhao
da724d65d7
Add |options| for ShowMessageBox
2015-07-23 14:16:43 +08:00
Cheng Zhao
dbab889fcc
Merge pull request #2232 from atom/status_item_view
...
Introduce custom status item view on OS X.
2015-07-21 10:36:19 +08:00
Haojian Wu
d342c9a6df
Implement 'drop-files' tray event on OS X.
2015-07-20 20:06:15 +08:00
Haojian Wu
2cd6ad1a97
More code style fixing.
2015-07-16 18:42:20 +08:00
Haojian Wu
736fe0c1db
Fix OS X build error.
2015-07-16 11:43:42 +08:00
Haojian Wu
ed4c69343f
Add 'tray.popContextMenu()' Windows implementation.
2015-07-16 11:42:43 +08:00
Haojian Wu
4421fbf9f3
Implement 'tray.popContextMenu' API on OS X.
2015-07-16 10:50:53 +08:00
Haojian Wu
002eb1a326
Simplify code logic and fix object-c code style.
2015-07-16 10:49:55 +08:00
Haojian Wu
5ad3fff6a0
Implement 'right-clicked' tray event on Windows.
2015-07-15 20:03:05 +08:00
Haojian Wu
cca4f4abd5
Implement 'right-clicked' tray event on OS X.
2015-07-15 19:32:00 +08:00
Haojian Wu
e54fda6b34
Introduce Electron custom statusItem view.
...
Reimplement tray functions on OS X by using custom statusItem view.
2015-07-15 18:26:39 +08:00
Cheng Zhao
5863ed4c33
win: Also map MESSAGE_BOX_TYPE_QUESTION to TD_INFORMATION_ICON
2015-07-13 21:51:19 -07:00
Cheng Zhao
001b4a3179
Final cleanup
2015-07-08 16:24:39 +08:00
Cheng Zhao
9793473b10
Show custom buttons as links
2015-07-08 15:57:45 +08:00
Cheng Zhao
a89e5592f2
Use stock buttons on Windows when possible
2015-07-08 15:55:53 +08:00
Cheng Zhao
989351a41d
Show user's icon when specified
2015-07-08 15:04:34 +08:00
Cheng Zhao
6fb8b2ce4f
Show icon according to dialog's type
2015-07-08 14:46:06 +08:00
Cheng Zhao
f0be4025a5
If "detail" is empty then don't make message hilighted
2015-07-08 14:41:19 +08:00
Cheng Zhao
49da74f976
Handle when dialog is cancelled
2015-07-08 14:35:28 +08:00
Cheng Zhao
1146441c2a
Implement ShowMessageBox with TaskDialog
2015-07-08 14:12:11 +08:00
Cheng Zhao
fb537d91fc
Set default cancelId in JavaScript
2015-07-07 18:39:08 +08:00
Cheng Zhao
b158427271
Add cancelId option for showMessageBox
2015-07-07 18:39:08 +08:00
Cheng Zhao
a2d1ec2c1f
Make "title" work
2015-07-07 17:21:30 +08:00
Cheng Zhao
9b25c16980
Allow "detail" to be empty
2015-07-07 17:21:30 +08:00
Cheng Zhao
810f14aecb
Simplify the code
2015-07-07 17:21:30 +08:00
Cheng Zhao
e627592eed
Reuse ShowMessageBox in ShowErrorBox
2015-07-07 17:21:30 +08:00
Cheng Zhao
3e6394a004
gtk: Map dialog type to message box type
2015-07-07 17:21:30 +08:00
Cheng Zhao
02e28ea758
Fix focusing message box
2015-07-07 17:21:30 +08:00
Cheng Zhao
b98cdf71c4
gtk: Implement message box APIs
2015-07-07 17:21:26 +08:00
Cheng Zhao
8fca1f52d3
Use SetGtkTransientForAura from libgtk2ui
2015-07-07 15:12:08 +08:00
Cheng Zhao
1ff00281f3
Seperate linux's implementation of message box
2015-07-07 15:12:08 +08:00
Haojian Wu
c01a79de6b
Fix the wrong reverse pageup
and pagedown
keys.
2015-07-01 21:24:51 +08:00
Cheng Zhao
03ab9b2686
Merge pull request #1848 from Bitbored/master
...
Added `bounds` payload to tray `clicked` event on Windows
2015-06-09 10:49:01 +08:00
Seppe Stas
cac97cca0d
Initialized rect with zeros
...
As per @zcbenz 's remark: The rect should be initialized with zeros to prevent random values being passed to the click event handler when `Shell_NotifyIconGetRect` fails.
2015-06-08 19:07:46 +02:00
Seppe Stas
16c08e7e37
Switched to gfx::Rect
constructor that takes a RECT
...
As per @zcbenz's suggestion the rect passed to the click event handler now passes a rect constructed using `gfx::Rect(const RECT& r)`.
2015-06-08 19:04:56 +02:00
Haojian Wu
da83ba6c06
Fix dialog.showSaveDialog doesn't show the non-exist file name on Linux.
2015-06-04 14:16:53 +08:00
Seppe Stas
e5c4e34ac4
Ow 💩 , where did that extra space come from?
2015-06-03 07:54:38 +02:00
Seppe Stas
ce8aa073ee
Added bounds
payload to tray clicked
event
...
Used [Shell_NotifyIconGetRect function](https://msdn.microsoft.com/en-us/library/windows/desktop/dd378426 ) to get the bounds of the application's tray icon.
Note: only works with Windows 7 and later.
Related to #1159 , #1500 .
2015-06-02 21:43:37 +02:00
Cheng Zhao
f31bfab127
gtk: Notify the click event
2015-05-21 15:22:52 +08:00
Cheng Zhao
1571c3537d
Merge pull request #1601 from hokein/fix-out-of-bound
...
Fix a potential out-of-bound issue in Accelerator.
2015-05-10 21:04:45 +08:00
Cheng Zhao
ce042d0524
mac: Don't use [NSScreen mainScreen]
2015-05-10 16:51:18 +08:00
Haojian Wu
2b82e523bf
Fix a potential out-of-bound issue in Accelerator.
2015-05-07 15:46:38 +08:00
Cheng Zhao
9d54092f41
Merge pull request #1512 from hokein/add-win-key
...
Add `Super` key support in global-shortcut API.
2015-05-07 10:35:56 +08:00
Haojian Wu
0f67b1866a
Add Super
key support in global-shortcut API.
2015-05-05 22:49:32 +08:00
Cheng Zhao
f5cf3556b1
Pass bounds in clicked event of tray
2015-05-04 11:43:22 +08:00
Cheng Zhao
a53b1f7edf
win: Mouse position is not notify icon's position
2015-05-04 11:37:23 +08:00
deepak1556
6d7d068e49
tray: send tray icon position as payload onclick OSX
2015-05-01 19:30:01 +05:30
Cheng Zhao
c7468278df
Change the window class names
2015-04-14 16:18:57 +08:00
Cheng Zhao
5b2c0110dc
Fix other compilation errors
2015-03-18 09:57:41 +08:00
Cheng Zhao
819ab5cd0c
Fix ui/gfx/geometry headers
2015-03-18 09:57:38 +08:00
Cheng Zhao
443a4b8f2f
mac: Use AsNSImage instead of ToNSImage
...
It can get rid of the empty check.
2015-02-12 12:29:49 +08:00
Cheng Zhao
f0924df68a
Add "type" option to change window type
2015-02-11 12:19:39 +08:00
Cheng Zhao
0087f8da27
linux: Fix building for Chrome 40
2015-01-27 17:20:50 -08:00
Cheng Zhao
750db6aed8
base/file_util.h has been moved to base/files/file_util.h
2015-01-27 13:18:30 -08:00
Cheng Zhao
43421aedcf
OVERRIDE macro is now removed
2015-01-27 13:18:30 -08:00
Cheng Zhao
33b6876cc1
Add support for Plus
as accelerator key, fixes #1050
2015-01-23 15:26:54 -08:00
Cheng Zhao
708e738521
views: Fix showing icon in message dialog
2015-01-05 15:26:35 -08:00
Cheng Zhao
8457090b18
Add "icon" option for message box
2015-01-05 15:08:42 -08:00
Cheng Zhao
bf14f67cb8
win: Fix building
2015-01-02 19:31:19 -08:00
Cheng Zhao
ef7a60807b
linux: Fix building
2015-01-02 19:26:17 -08:00
Cheng Zhao
ab83b21fa6
Use gfx::Image instead of gfx::ImageSkia in API
...
The gfx::Image can use NSImage directly as underlying format, so we
don't have to decode images ourselves on Mac, and we will also be able
to make use of template images.
2015-01-02 18:43:56 -08:00
Cheng Zhao
63e83a7ef8
win: Don't hang when failed to create thread
2014-12-16 12:33:17 -08:00
Cheng Zhao
c20e1e9d82
win: Run async save dialog in new thread
2014-12-16 12:27:26 -08:00
Cheng Zhao
253bacdf1d
win: Run async open dialog in new thread
2014-12-16 11:27:38 -08:00
Cheng Zhao
0ab32bfe17
win: Reserve border space for maximized frameless window
...
Fixes #732 .
2014-12-15 16:01:11 -08:00
Cheng Zhao
e3ccb18696
win: Fix calculating window bounds on high DPI display
2014-12-12 09:04:43 -08:00
Cheng Zhao
409f2b4d0f
win: Fix compilation errors
2014-12-10 14:17:07 -08:00
Cheng Zhao
1853bef39a
views: SizeConstraintsChanged has become required
2014-12-09 16:55:01 -08:00
Cheng Zhao
22c4911b58
linux: GTK+ status icon has come back
2014-12-09 16:55:01 -08:00
Cheng Zhao
9f99209733
win: Add "balloon-show" and "balloon-closed" events
2014-11-28 19:42:57 +08:00
Cheng Zhao
a3327ac53e
win: Remove XP code in Tray
2014-11-28 18:59:51 +08:00
Cheng Zhao
210c97f957
win: Add "balloon-clicked" event for Tray
2014-11-28 18:50:31 +08:00
Cheng Zhao
2650e34867
win: Add NotifyIcon::DisplayBalloon
2014-11-28 18:30:43 +08:00