Cheng Zhao
32a4de4a68
chore: make util::Promise a move-only type ( #17071 )
2019-02-21 12:32:44 +00:00
deepak1556
abec938b0a
Use base::size rather than arraysize
...
https://bugs.chromium.org/p/chromium/issues/detail?id=837308
2019-02-14 23:59:22 +05:30
Milan Burda
a9475f3590
feat: add workingDirectory option to shell.openExternal() ( #15065 )
...
Allows passing `workingDirectory` to the underlying `ShellExecuteW` API on Windows.
the motivation is that by default `ShellExecute` would use the current working directory, which would get locked on Windows and can prevent autoUpdater from working correctly. We need to be able specify a different `workingDirectory` to prevent this situation.
2018-10-10 22:46:54 +02:00
Milan Burda
5b0a898dd2
refactor: SHOpenFolderAndSelectItems does not have to be dynamically resolved
2018-07-12 22:28:44 +02:00
Jeremy Apthorp
78bc1081fd
chore: fix some more warnings in windows build ( #13431 )
...
Remove an unused function and fix an int type comparison warning. Only showed up when building with GN.
2018-06-26 02:00:20 +02:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
Tomas Rycl
7ca1b0704d
Rename ScopedWindowsThreadEnvironment::succeeded() to Succeeded()
...
https://chromium-review.googlesource.com/742447
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
f6648a0d4d
Remove ScopedComPtr and scoped_comptr.h
...
https://chromium-review.googlesource.com/726461
2018-06-19 11:49:43 +10:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Aleksei Kuzmin
7f5fbb04e2
Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/...
...
https://codereview.chromium.org/2894483002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
79e59a88b4
Rename ScopedComPtr::Receive to ScopedComPtr::GetAddressOf
...
https://codereview.chromium.org/2870263002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
485e43636b
Rename ScopedComPtr::get() to ScopedComPtr::Get()
...
https://codereview.chromium.org/2824773002
2017-11-24 10:58:17 +09:00
Cheng Zhao
5639faf069
Also fix the Windows and Linux side of async openExternal
2016-11-17 12:13:07 +09:00
Gabriel Handford
5b260dbee3
Fix win/linux compile (again)
2016-11-17 10:33:24 +09:00
Gabriel Handford
f0ca9dff81
Fix win/linux compile
2016-11-17 10:33:24 +09:00
Gabriel Handford
99a5258999
Callback uses (platform specific) error, with message
2016-11-17 10:33:24 +09:00
Gabriel Handford
08a9af3a85
Linting
2016-11-17 10:33:24 +09:00
Gabriel Handford
cfd2a029ad
Fix linting
2016-11-17 10:33:23 +09:00
Gabriel Handford
9ca684d87f
Remove redundant method
2016-11-17 10:33:23 +09:00
Gabriel Handford
128feb17cb
Fix method call
2016-11-17 10:33:23 +09:00
Gabriel Handford
3eb5f8d521
Fix typo
2016-11-17 10:33:23 +09:00
Gabriel Handford
b266533dfc
Shell openExternal can take optional callback (macOS)
2016-11-17 10:33:23 +09:00
Kevin Sawicki
07304e5950
Add missing return value
2016-09-12 14:33:22 -07:00
Kevin Sawicki
55eab8e385
Return boolean from shell.openItem
2016-09-12 14:29:06 -07:00
Kevin Sawicki
72558654ef
Return boolean from shell.showItemInFolder
2016-09-12 14:22:29 -07:00
Kevin Sawicki
3dd5628ded
Include windows.h first
2016-08-26 16:00:05 -07:00
Kevin Sawicki
6285500cdc
Sort includes alphabetically
2016-08-26 15:30:02 -07:00
Cheng Zhao
5208bbd2e8
Remove unneeded include
2016-07-11 17:13:21 +09:00
Cheng Zhao
86338290fb
win: Fix openExternal not working with non-ASCII characters
2016-07-11 17:12:11 +09:00
Kevin Sawicki
f5bed87199
without_activation -> activate
2016-02-17 08:56:58 -08:00
Ben Gotow
d8679b3899
Allow openExternal to open URLs in the background #3224
2016-02-17 08:56:58 -08:00
Paul Betts
05aeceeb52
Always fall back to OpenFolderViaShell when trying to reveal a file
...
We should always fallback to OpenFolderViaShell when revealing a file fails,
since this API seems to be highly subject to Random Bad Things happening to
you.
2016-01-28 19:05:16 +08:00
Tyler Gibson
2d0e1c313a
Adding check for Windows version and alternate flags for Windows Vista/7
2015-12-24 06:08:43 +00:00
Cheng Zhao
fbb8e61958
Replace "Url" in API names with "URL"
2015-11-13 16:03:40 +08:00
Cheng Zhao
47649ffd17
win: Fix calling showItemInFolder in renderer process
2015-11-05 20:47:27 +08:00
Tyler Gibson
4ff5ce4d6d
Fixing MoveItemToTrash behavior in Windows
...
Modifying MoveItemToTrash for Windows to actually verify file can be
moved to a drive's recycle bin before attempting to delete it.
PR: #3337 .
2015-11-05 20:42:30 +08:00
msullivan
b4674923c9
return bool on shell.openExternal
2015-06-10 11:06:22 -04:00
Cheng Zhao
a213a8639f
win: OpenItemViaShell is removed
2015-04-22 10:04:30 +08:00
Cheng Zhao
ce3d9f44ff
win: Fix compilation error
...
MSDN said, "These are pre-Win32 error codes and are no longer supported or
defined in any public header file."
2015-03-30 09:55:02 +08:00
Robo
bedea89dcf
shell: return status for moveItemToTrash on all platforms
2015-03-29 00:47:50 +05:30
Cheng Zhao
57812616b9
win: Fix tests and compilation errors
2015-03-18 13:58:33 +08:00
Kevin Sawicki
b6b6fc3bfd
Remove All Rights Reserved after GitHub copyright
...
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
8d4211bd3a
win: Fix compilation errors for chrome35.
2014-07-11 12:19:01 +08:00
Mark Samman
2ed46e6f7f
Move item to trash without confirming on Windows
...
This will skip the "Are you sure you want to move this file to the Recycle Bin?" dialog on Windows.
2014-07-02 03:55:29 +02:00
Cheng Zhao
f176b2c58f
Switch to use MIT license.
2014-05-04 20:29:08 +08:00
Cheng Zhao
516d46444d
Move all sources under atom/.
2014-03-16 08:30:26 +08:00
