4ff5ce4d6d
Modifying MoveItemToTrash for Windows to actually verify file can be moved to a drive's recycle bin before attempting to delete it. PR: #3337.
369 lines
12 KiB
C++
369 lines
12 KiB
C++
// Copyright (c) 2013 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "atom/common/platform_util.h"
|
|
|
|
#include <windows.h>
|
|
#include <atlbase.h>
|
|
#include <commdlg.h>
|
|
#include <comdef.h>
|
|
#include <dwmapi.h>
|
|
#include <shellapi.h>
|
|
#include <shlobj.h>
|
|
|
|
#include "base/bind.h"
|
|
#include "base/bind_helpers.h"
|
|
#include "base/files/file_path.h"
|
|
#include "base/files/file_util.h"
|
|
#include "base/logging.h"
|
|
#include "base/strings/string_util.h"
|
|
#include "base/strings/utf_string_conversions.h"
|
|
#include "base/win/registry.h"
|
|
#include "base/win/scoped_co_mem.h"
|
|
#include "base/win/scoped_com_initializer.h"
|
|
#include "base/win/scoped_comptr.h"
|
|
#include "base/win/windows_version.h"
|
|
#include "url/gurl.h"
|
|
#include "ui/base/win/shell.h"
|
|
|
|
namespace {
|
|
|
|
// Old ShellExecute crashes the process when the command for a given scheme
|
|
// is empty. This function tells if it is.
|
|
bool ValidateShellCommandForScheme(const std::string& scheme) {
|
|
base::win::RegKey key;
|
|
base::string16 registry_path = base::ASCIIToUTF16(scheme) +
|
|
L"\\shell\\open\\command";
|
|
key.Open(HKEY_CLASSES_ROOT, registry_path.c_str(), KEY_READ);
|
|
if (!key.Valid())
|
|
return false;
|
|
DWORD size = 0;
|
|
key.ReadValue(NULL, NULL, &size, NULL);
|
|
if (size <= 2)
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
// Required COM implementation of IFileOperationProgressSink so we can
|
|
// precheck files before deletion to make sure they can be move to the
|
|
// Recycle Bin.
|
|
class DeleteFileProgressSink : public IFileOperationProgressSink {
|
|
public:
|
|
DeleteFileProgressSink();
|
|
|
|
private:
|
|
ULONG STDMETHODCALLTYPE AddRef(void);
|
|
ULONG STDMETHODCALLTYPE Release(void);
|
|
HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid, LPVOID* ppvObj);
|
|
HRESULT STDMETHODCALLTYPE StartOperations(void);
|
|
HRESULT STDMETHODCALLTYPE FinishOperations(HRESULT);
|
|
HRESULT STDMETHODCALLTYPE PreRenameItem(
|
|
DWORD, IShellItem*, LPCWSTR);
|
|
HRESULT STDMETHODCALLTYPE PostRenameItem(
|
|
DWORD, IShellItem*, LPCWSTR, HRESULT, IShellItem*);
|
|
HRESULT STDMETHODCALLTYPE PreMoveItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR);
|
|
HRESULT STDMETHODCALLTYPE PostMoveItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR, HRESULT, IShellItem*);
|
|
HRESULT STDMETHODCALLTYPE PreCopyItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR);
|
|
HRESULT STDMETHODCALLTYPE PostCopyItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR, HRESULT, IShellItem*);
|
|
HRESULT STDMETHODCALLTYPE PreDeleteItem(DWORD, IShellItem*);
|
|
HRESULT STDMETHODCALLTYPE PostDeleteItem(
|
|
DWORD, IShellItem*, HRESULT, IShellItem*);
|
|
HRESULT STDMETHODCALLTYPE PreNewItem(
|
|
DWORD, IShellItem*, LPCWSTR);
|
|
HRESULT STDMETHODCALLTYPE PostNewItem(
|
|
DWORD, IShellItem*, LPCWSTR, LPCWSTR, DWORD, HRESULT, IShellItem*);
|
|
HRESULT STDMETHODCALLTYPE UpdateProgress(UINT, UINT);
|
|
HRESULT STDMETHODCALLTYPE ResetTimer(void);
|
|
HRESULT STDMETHODCALLTYPE PauseTimer(void);
|
|
HRESULT STDMETHODCALLTYPE ResumeTimer(void);
|
|
|
|
ULONG m_cRef;
|
|
};
|
|
|
|
DeleteFileProgressSink::DeleteFileProgressSink() {
|
|
m_cRef = 0;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PreDeleteItem(DWORD dwFlags, IShellItem*) {
|
|
if (!(dwFlags & TSF_DELETE_RECYCLE_IF_POSSIBLE)) {
|
|
// TSF_DELETE_RECYCLE_IF_POSSIBLE will not be set for items that cannot be
|
|
// recycled. In this case, we abort the delete operation. This bubbles
|
|
// up and stops the Delete in IFileOperation.
|
|
return E_ABORT;
|
|
}
|
|
// Returns S_OK if successful, or an error value otherwise. In the case of an
|
|
// error value, the delete operation and all subsequent operations pending
|
|
// from the call to IFileOperation are canceled.
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::QueryInterface(REFIID riid, LPVOID* ppvObj) {
|
|
// Always set out parameter to NULL, validating it first.
|
|
if (!ppvObj)
|
|
return E_INVALIDARG;
|
|
*ppvObj = nullptr;
|
|
if (riid == IID_IUnknown || riid == IID_IFileOperationProgressSink) {
|
|
// Increment the reference count and return the pointer.
|
|
*ppvObj = reinterpret_cast<IUnknown*>(this);
|
|
AddRef();
|
|
return NOERROR;
|
|
}
|
|
return E_NOINTERFACE;
|
|
}
|
|
|
|
ULONG DeleteFileProgressSink::AddRef() {
|
|
InterlockedIncrement(&m_cRef);
|
|
return m_cRef;
|
|
}
|
|
|
|
ULONG DeleteFileProgressSink::Release() {
|
|
// Decrement the object's internal counter.
|
|
ULONG ulRefCount = InterlockedDecrement(&m_cRef);
|
|
if (0 == m_cRef) {
|
|
delete this;
|
|
}
|
|
return ulRefCount;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::StartOperations() {
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::FinishOperations(HRESULT) {
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PreRenameItem(DWORD, IShellItem*, LPCWSTR) {
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PostRenameItem(
|
|
DWORD, IShellItem*, __RPC__in_string LPCWSTR, HRESULT, IShellItem*) {
|
|
return E_NOTIMPL;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PreMoveItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR) {
|
|
return E_NOTIMPL;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PostMoveItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR, HRESULT, IShellItem*) {
|
|
return E_NOTIMPL;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PreCopyItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR) {
|
|
return E_NOTIMPL;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PostCopyItem(
|
|
DWORD, IShellItem*, IShellItem*, LPCWSTR, HRESULT, IShellItem*) {
|
|
return E_NOTIMPL;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PostDeleteItem(
|
|
DWORD, IShellItem*, HRESULT, IShellItem*) {
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PreNewItem(
|
|
DWORD dwFlags, IShellItem*, LPCWSTR) {
|
|
return E_NOTIMPL;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PostNewItem(
|
|
DWORD, IShellItem*, LPCWSTR, LPCWSTR, DWORD, HRESULT, IShellItem*) {
|
|
return E_NOTIMPL;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::UpdateProgress(UINT, UINT) {
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::ResetTimer() {
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::PauseTimer() {
|
|
return S_OK;
|
|
}
|
|
|
|
HRESULT DeleteFileProgressSink::ResumeTimer() {
|
|
return S_OK;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
namespace platform_util {
|
|
|
|
void ShowItemInFolder(const base::FilePath& full_path) {
|
|
base::FilePath dir = full_path.DirName().AsEndingWithSeparator();
|
|
// ParseDisplayName will fail if the directory is "C:", it must be "C:\\".
|
|
if (dir.empty())
|
|
return;
|
|
|
|
typedef HRESULT (WINAPI *SHOpenFolderAndSelectItemsFuncPtr)(
|
|
PCIDLIST_ABSOLUTE pidl_Folder,
|
|
UINT cidl,
|
|
PCUITEMID_CHILD_ARRAY pidls,
|
|
DWORD flags);
|
|
|
|
static SHOpenFolderAndSelectItemsFuncPtr open_folder_and_select_itemsPtr =
|
|
NULL;
|
|
static bool initialize_open_folder_proc = true;
|
|
if (initialize_open_folder_proc) {
|
|
initialize_open_folder_proc = false;
|
|
// The SHOpenFolderAndSelectItems API is exposed by shell32 version 6
|
|
// and does not exist in Win2K. We attempt to retrieve this function export
|
|
// from shell32 and if it does not exist, we just invoke ShellExecute to
|
|
// open the folder thus losing the functionality to select the item in
|
|
// the process.
|
|
HMODULE shell32_base = GetModuleHandle(L"shell32.dll");
|
|
if (!shell32_base) {
|
|
NOTREACHED() << " " << __FUNCTION__ << "(): Can't open shell32.dll";
|
|
return;
|
|
}
|
|
open_folder_and_select_itemsPtr =
|
|
reinterpret_cast<SHOpenFolderAndSelectItemsFuncPtr>
|
|
(GetProcAddress(shell32_base, "SHOpenFolderAndSelectItems"));
|
|
}
|
|
if (!open_folder_and_select_itemsPtr) {
|
|
ShellExecute(NULL, L"open", dir.value().c_str(), NULL, NULL, SW_SHOW);
|
|
return;
|
|
}
|
|
|
|
base::win::ScopedComPtr<IShellFolder> desktop;
|
|
HRESULT hr = SHGetDesktopFolder(desktop.Receive());
|
|
if (FAILED(hr))
|
|
return;
|
|
|
|
base::win::ScopedCoMem<ITEMIDLIST> dir_item;
|
|
hr = desktop->ParseDisplayName(NULL, NULL,
|
|
const_cast<wchar_t *>(dir.value().c_str()),
|
|
NULL, &dir_item, NULL);
|
|
if (FAILED(hr))
|
|
return;
|
|
|
|
base::win::ScopedCoMem<ITEMIDLIST> file_item;
|
|
hr = desktop->ParseDisplayName(NULL, NULL,
|
|
const_cast<wchar_t *>(full_path.value().c_str()),
|
|
NULL, &file_item, NULL);
|
|
if (FAILED(hr))
|
|
return;
|
|
|
|
const ITEMIDLIST* highlight[] = { file_item };
|
|
|
|
hr = (*open_folder_and_select_itemsPtr)(dir_item, arraysize(highlight),
|
|
highlight, NULL);
|
|
|
|
if (FAILED(hr)) {
|
|
// On some systems, the above call mysteriously fails with "file not
|
|
// found" even though the file is there. In these cases, ShellExecute()
|
|
// seems to work as a fallback (although it won't select the file).
|
|
if (hr == ERROR_FILE_NOT_FOUND) {
|
|
ShellExecute(NULL, L"open", dir.value().c_str(), NULL, NULL, SW_SHOW);
|
|
} else {
|
|
LPTSTR message = NULL;
|
|
DWORD message_length = FormatMessage(
|
|
FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM,
|
|
0, hr, 0, reinterpret_cast<LPTSTR>(&message), 0, NULL);
|
|
LOG(WARNING) << " " << __FUNCTION__
|
|
<< "(): Can't open full_path = \""
|
|
<< full_path.value() << "\""
|
|
<< " hr = " << hr
|
|
<< " " << reinterpret_cast<LPTSTR>(&message);
|
|
if (message)
|
|
LocalFree(message);
|
|
}
|
|
}
|
|
}
|
|
|
|
void OpenItem(const base::FilePath& full_path) {
|
|
if (base::DirectoryExists(full_path))
|
|
ui::win::OpenFolderViaShell(full_path);
|
|
else
|
|
ui::win::OpenFileViaShell(full_path);
|
|
}
|
|
|
|
bool OpenExternal(const GURL& url) {
|
|
// Quote the input scheme to be sure that the command does not have
|
|
// parameters unexpected by the external program. This url should already
|
|
// have been escaped.
|
|
std::string escaped_url = url.spec();
|
|
escaped_url.insert(0, "\"");
|
|
escaped_url += "\"";
|
|
|
|
// According to Mozilla in uriloader/exthandler/win/nsOSHelperAppService.cpp:
|
|
// "Some versions of windows (Win2k before SP3, Win XP before SP1) crash in
|
|
// ShellExecute on long URLs (bug 161357 on bugzilla.mozilla.org). IE 5 and 6
|
|
// support URLS of 2083 chars in length, 2K is safe."
|
|
const size_t kMaxUrlLength = 2048;
|
|
if (escaped_url.length() > kMaxUrlLength) {
|
|
NOTREACHED();
|
|
return false;
|
|
}
|
|
|
|
if (base::win::GetVersion() < base::win::VERSION_WIN7) {
|
|
if (!ValidateShellCommandForScheme(url.scheme()))
|
|
return false;
|
|
}
|
|
|
|
if (reinterpret_cast<ULONG_PTR>(ShellExecuteA(NULL, "open",
|
|
escaped_url.c_str(), NULL, NULL,
|
|
SW_SHOWNORMAL)) <= 32) {
|
|
// We fail to execute the call. We could display a message to the user.
|
|
// TODO(nsylvain): we should also add a dialog to warn on errors. See
|
|
// bug 1136923.
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool MoveItemToTrash(const base::FilePath& path) {
|
|
base::win::ScopedCOMInitializer com_initializer;
|
|
if (!com_initializer.succeeded())
|
|
return false;
|
|
|
|
base::win::ScopedComPtr<IFileOperation> pfo;
|
|
if (FAILED(pfo.CreateInstance(CLSID_FileOperation)))
|
|
return false;
|
|
|
|
// Elevation prompt enabled for UAC protected files. This overrides the
|
|
// SILENT, NO_UI and NOERRORUI flags.
|
|
if (FAILED(pfo->SetOperationFlags(FOF_NO_UI |
|
|
FOF_ALLOWUNDO |
|
|
FOF_NOERRORUI |
|
|
FOF_SILENT |
|
|
FOFX_SHOWELEVATIONPROMPT |
|
|
FOFX_RECYCLEONDELETE)))
|
|
return false;
|
|
|
|
// Create an IShellItem from the supplied source path.
|
|
base::win::ScopedComPtr<IShellItem> delete_item;
|
|
if (FAILED(SHCreateItemFromParsingName(path.value().c_str(),
|
|
NULL,
|
|
IID_PPV_ARGS(delete_item.Receive()))))
|
|
return false;
|
|
|
|
base::win::ScopedComPtr<IFileOperationProgressSink> delete_sink(
|
|
new DeleteFileProgressSink);
|
|
if (!delete_sink)
|
|
return false;
|
|
|
|
// Processes the queued command DeleteItem. This will trigger
|
|
// the DeleteFileProgressSink to check for Recycle Bin.
|
|
return SUCCEEDED(pfo->DeleteItem(delete_item.get(), delete_sink.get())) &&
|
|
SUCCEEDED(pfo->PerformOperations());
|
|
}
|
|
|
|
void Beep() {
|
|
MessageBeep(MB_OK);
|
|
}
|
|
|
|
} // namespace platform_util
|