Fix linting
This commit is contained in:
parent
c78567aba6
commit
cfd2a029ad
4 changed files with 9 additions and 6 deletions
|
@ -60,7 +60,8 @@ bool OpenExternal(
|
|||
if (args->Length() >= 3) {
|
||||
v8::Local<v8::Value> peek = args->PeekNext();
|
||||
platform_util::OpenExternalCallback callback;
|
||||
if (mate::Converter<platform_util::OpenExternalCallback>::FromV8(args->isolate(), peek, &callback)) {
|
||||
if (mate::Converter<platform_util::OpenExternalCallback>::FromV8(
|
||||
args->isolate(), peek, &callback)) {
|
||||
return platform_util::OpenExternal(url, activate, callback);
|
||||
}
|
||||
return false;
|
||||
|
|
|
@ -5,8 +5,8 @@
|
|||
#ifndef ATOM_COMMON_PLATFORM_UTIL_H_
|
||||
#define ATOM_COMMON_PLATFORM_UTIL_H_
|
||||
|
||||
#include "build/build_config.h"
|
||||
#include "base/callback_forward.h"
|
||||
#include "build/build_config.h"
|
||||
|
||||
#if defined(OS_WIN)
|
||||
#include "base/strings/string16.h"
|
||||
|
|
|
@ -88,8 +88,9 @@ bool OpenExternal(const GURL& url, bool activate) {
|
|||
return XDGOpen(url.spec(), false);
|
||||
}
|
||||
|
||||
bool OpenExternal(const GURL& url, bool activate, const OpenExternalCallback& callback) {
|
||||
// TODO: Implement async open if callback is specified
|
||||
bool OpenExternal(const GURL& url, bool activate,
|
||||
const OpenExternalCallback& callback) {
|
||||
// TODO(gabriel): Implement async open if callback is specified
|
||||
bool opened = OpenExternal(url, activate);
|
||||
callback.Run(opened);
|
||||
return opened;
|
||||
|
|
|
@ -316,8 +316,9 @@ bool OpenExternal(const base::string16& url, bool activate) {
|
|||
return true;
|
||||
}
|
||||
|
||||
bool OpenExternal(const base::string16& url, bool activate, const OpenExternalCallback& callback) {
|
||||
// TODO: Implement async open if callback is specified
|
||||
bool OpenExternal(const base::string16& url, bool activate,
|
||||
const OpenExternalCallback& callback) {
|
||||
// // TODO(gabriel): Implement async open if callback is specified
|
||||
bool opened = OpenExternal(url, activate);
|
||||
callback.Run(opened);
|
||||
return opened;
|
||||
|
|
Loading…
Reference in a new issue