From cfd2a029add3eabf5d59a0b7c83d931e55169421 Mon Sep 17 00:00:00 2001 From: Gabriel Handford Date: Fri, 14 Oct 2016 12:38:55 -0700 Subject: [PATCH] Fix linting --- atom/common/api/atom_api_shell.cc | 3 ++- atom/common/platform_util.h | 2 +- atom/common/platform_util_linux.cc | 5 +++-- atom/common/platform_util_win.cc | 5 +++-- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/atom/common/api/atom_api_shell.cc b/atom/common/api/atom_api_shell.cc index 05214531e1b0..894c85eeeae7 100644 --- a/atom/common/api/atom_api_shell.cc +++ b/atom/common/api/atom_api_shell.cc @@ -60,7 +60,8 @@ bool OpenExternal( if (args->Length() >= 3) { v8::Local peek = args->PeekNext(); platform_util::OpenExternalCallback callback; - if (mate::Converter::FromV8(args->isolate(), peek, &callback)) { + if (mate::Converter::FromV8( + args->isolate(), peek, &callback)) { return platform_util::OpenExternal(url, activate, callback); } return false; diff --git a/atom/common/platform_util.h b/atom/common/platform_util.h index 8f2c5b6e5293..d7bb92064872 100644 --- a/atom/common/platform_util.h +++ b/atom/common/platform_util.h @@ -5,8 +5,8 @@ #ifndef ATOM_COMMON_PLATFORM_UTIL_H_ #define ATOM_COMMON_PLATFORM_UTIL_H_ -#include "build/build_config.h" #include "base/callback_forward.h" +#include "build/build_config.h" #if defined(OS_WIN) #include "base/strings/string16.h" diff --git a/atom/common/platform_util_linux.cc b/atom/common/platform_util_linux.cc index 3aabe375ad47..fd832179594d 100644 --- a/atom/common/platform_util_linux.cc +++ b/atom/common/platform_util_linux.cc @@ -88,8 +88,9 @@ bool OpenExternal(const GURL& url, bool activate) { return XDGOpen(url.spec(), false); } -bool OpenExternal(const GURL& url, bool activate, const OpenExternalCallback& callback) { - // TODO: Implement async open if callback is specified +bool OpenExternal(const GURL& url, bool activate, + const OpenExternalCallback& callback) { + // TODO(gabriel): Implement async open if callback is specified bool opened = OpenExternal(url, activate); callback.Run(opened); return opened; diff --git a/atom/common/platform_util_win.cc b/atom/common/platform_util_win.cc index f859193de23d..69778fefe802 100644 --- a/atom/common/platform_util_win.cc +++ b/atom/common/platform_util_win.cc @@ -316,8 +316,9 @@ bool OpenExternal(const base::string16& url, bool activate) { return true; } -bool OpenExternal(const base::string16& url, bool activate, const OpenExternalCallback& callback) { - // TODO: Implement async open if callback is specified +bool OpenExternal(const base::string16& url, bool activate, + const OpenExternalCallback& callback) { + // // TODO(gabriel): Implement async open if callback is specified bool opened = OpenExternal(url, activate); callback.Run(opened); return opened;