Ales Pergl
29f3332276
Address cpplint issue "{ should almost always be at the end of the previous line [whitespace/braces] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
63eeb96e71
Address cpplint issue "Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]"
2017-04-05 14:30:16 +02:00
Ales Pergl
20d0bda538
Address cpplint issue "Found C++ system header after other header. Should be: toast.h, c system, c++ system, other. [build/include_order] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
33b4936a68
Address cpplint issue "Include the directory when naming .h files [build/include] [4]"
2017-04-05 14:30:15 +02:00
Ales Pergl
0bba5b9b41
Address cpplint issue "Lines should be <= 80 characters long [whitespace/line_length] [2]"
2017-04-05 14:30:15 +02:00
Ales Pergl
392d606848
Changed member variable naming style to snake case
2017-04-05 14:30:15 +02:00
Ales Pergl
0fa6c82b3f
Use NotificationPresenterWin7 on Windows 7
2017-04-05 14:30:15 +02:00
Ales Pergl
fe05b66a6c
Added desktop notifications implementation for Windows 7 (and earlier)
2017-04-05 14:30:15 +02:00
Ales Pergl
e6a30388da
Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions.
2017-04-05 14:30:15 +02:00
Kevin Sawicki
0981807261
Merge pull request #287 from electron/no-anonymous-ns-in-header
...
Don't use anonymous namespace in header file.
2017-04-03 08:27:51 -07:00
Haojian Wu
e80a9bbb93
Move title_ to InspectableWebContentsViewVies to get rid of cast.
2017-04-01 15:10:52 +02:00
Haojian Wu
ee1f3acf7b
Don't use anonymous namespace in header file.
...
Anonymous namespace should be forbidden in header files even for the
forward declarations:
* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.
Consider the following "foo.h":
```cpp
namespace { class Foo; }
class Bar {
public:
Foo* getFoo();
Foo* foo;
}
```
If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
2017-04-01 08:57:34 +02:00
Haojian Wu
f506047a9b
Remove an extra blank line.
2017-03-31 21:56:19 +02:00
Haojian Wu
22035e2d6d
Fix cpplint: at least two spaces between code and comments.
2017-03-31 20:59:27 +02:00
Haojian Wu
d18b34d55f
Replace size() method with empty() when possible.
...
There is no guaranteed that size() is a constant-time function.
2017-03-30 21:49:16 +02:00
Haojian Wu
e4c571fc68
Remove unused using namespace declaration.
2017-03-30 21:49:15 +02:00
Haojian Wu
424078cfdb
Fix namespace comments.
2017-03-30 21:49:15 +02:00
Cheng Zhao
bd5c53c2f7
Merge pull request #283 from electron/devtools_shutdown_patch_revert_revert
...
Revert "Revert "close devtools web contents when available to trigger cleanup""
2017-03-27 22:46:06 -07:00
Kevin Sawicki
21956071e6
Fix compilation issue
2017-03-24 09:52:37 -07:00
Kevin Sawicki
2ece711c2e
Format line length to 80 instead of 100
2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a
Remove cpplint errors
2017-03-23 12:48:27 -07:00
deepak1556
99fd1394e4
Revert "Revert "close devtools web contents when available to trigger cleanup""
...
This reverts commit 7f01bf4e73c188db2406ded1286b661c61c78bba.
2017-03-19 01:25:22 +05:30
Kevin Sawicki
8877d78e79
Revert "close devtools web contents when available to trigger cleanup"
2017-03-17 09:35:01 -07:00
deepak1556
07c4f3563e
close devtools web contents when available to trigger cleanup
2017-03-14 22:23:08 +05:30
Kevin Sawicki
4ed9f63989
Cleanly shutdown browser context
2017-02-13 11:04:02 -08:00
deepak1556
0b76a9c073
Persist zoom levels per partition
2017-02-10 22:54:32 +05:30
Cheng Zhao
abececd78b
libgtk2ui => libgtkui
2017-01-26 20:02:01 +09:00
Cheng Zhao
a749a3dd2a
Fix Debug building on Windows
2017-01-26 16:09:45 +09:00
Cheng Zhao
94fdcb4f48
WebInspector has been split up
2017-01-25 08:43:27 +09:00
Cheng Zhao
bf4c413947
Update PlatformNotificationService
2017-01-23 17:48:16 +09:00
Cheng Zhao
ac4ef926e1
URLRequestContenxtGetter now accepts task runner
2017-01-23 15:43:17 +09:00
Cheng Zhao
622fd8d1d7
Update InspectableWebContentsImpl
2017-01-23 15:43:17 +09:00
Cheng Zhao
db7959619e
Update DevToolsNetworkUploadDataStream
2017-01-23 15:18:52 +09:00
Cheng Zhao
70ffec1134
There is no content::MEDIA_ENUMERATE_DEVICES anymore
2017-01-23 15:14:38 +09:00
Cheng Zhao
0236f87507
Update DevToolsNetworkTransaction
2017-01-23 15:10:34 +09:00
Cheng Zhao
e7ee9f1be9
DevToolsDelegate is no longer needed
2017-01-23 15:07:18 +09:00
Cheng Zhao
804d56e139
Signature of StartDataRequest has changed
2017-01-23 14:55:06 +09:00
Cheng Zhao
eb89edbf5b
devtools_discovery and devtools_http_handler are gone
2017-01-23 14:54:58 +09:00
Ales Pergl
85db1bb47d
Adjustments after upgrading to Chromium 54
2017-01-17 17:18:51 +09:00
Kevin Sawicki
e5ec6adf7d
Update std:move call to fix macOS compiler error
2017-01-12 14:04:12 -08:00
deepak1556
cddce77ea4
force attach devtools client when requested by inspectable webcontents
2017-01-10 16:43:16 +05:30
deepak1556
237cb7d0a3
interceptor should handle default values of download and upload throughput
2017-01-06 23:28:49 +05:30
deepak1556
dbf4e52e05
persist media device id salt across sessions
2016-12-03 16:47:31 +05:30
Kevin Sawicki
7cb8c1fdb9
Add dismiss notification guard on Linux
2016-10-28 11:24:47 -07:00
Kevin Sawicki
0a5f7171d4
Add more guards around null notification
2016-10-28 10:54:55 -07:00
deepak1556
ee4442f964
set notification close callback before requesting user permission
2016-10-25 19:04:09 +05:30
Kevin Sawicki
4fdca64030
Merge pull request #256 from deepak1556/ct_delegate_patch
...
allow embedder to provide RequireCTDelegate
2016-10-24 15:39:49 +09:00
deepak1556
aa7255bad5
allow embedder to provide RequireCTDelegate
2016-10-17 16:06:37 +05:30
deepak1556
f652760c7a
use dock state from peferences when not set by embedder
2016-10-11 13:47:06 +05:30
deepak1556
968bc5c9a2
set dock state using devtools dockController
2016-10-06 17:31:38 +05:30
