Dan Stillman
c0eea4dadd
Missed annotation property from 7889cd5d3
2021-03-21 15:53:12 -04:00
Dan Stillman
7990ce721e
Update pdf-reader submodule
2021-03-21 14:37:03 -04:00
Dan Stillman
b566c06f93
Add getImageBlob() support function for tests
2021-03-21 14:36:43 -04:00
Dan Stillman
06b28194da
Show annotation widget in conflict resolution window
...
This adds a very basic reimplementation of the annotation widget for use
in the CR window. It's not pixel-perfect, but it's close enough that
most people probably won't notice. We'll want to replace this with a
real version that's shared between the PDF reader and the rest of the
codebase.
Image annotations currently show an "[image not shown]" placeholder.
Showing images is tricky: we don't have the remote cache image, so if
the remote position has changed, we could only show an image by
rendering it from the file, and only if the file itself hasn't changed.
Just for a better user experience, we could use the local image as long
as the position and file are both the same, but that would take some
rejiggering of the CR window.
Tags aren't shown because they're not shown for CR at all, though that
could be changed in the future.
2021-03-21 14:36:43 -04:00
Dan Stillman
7889cd5d39
Fix item.clone() on annotation items
2021-03-21 14:36:42 -04:00
Martynas Bagdonas
9eb4fdb9cd
Return back to notes list when a note is deleted
2021-03-19 12:41:07 +02:00
Martynas Bagdonas
ac750520e7
Use browser element instead of iframe to have access to History API
2021-03-18 18:19:09 +02:00
Martynas Bagdonas
f02b3464b8
Close note editor window when the note item is deleted
2021-03-18 10:05:21 +02:00
Martynas Bagdonas
4f71c2ab09
Improve PDF reader and note editor error handling
2021-03-18 10:03:36 +02:00
Martynas Bagdonas
1ede4240e0
Close all tabs and unregister tabs observer when destroying main window
...
#2005
2021-03-17 17:59:04 +02:00
Martynas Bagdonas
bf84e16002
Show crash popover on annotation saving failure
...
#2006
2021-03-17 13:43:48 +02:00
Martynas Bagdonas
1677e957cd
Properly ignore deleted PDF attachments and close pdf-reader tabs
...
#2006
2021-03-17 13:43:48 +02:00
Martynas Bagdonas
8013a6ce97
Do not select the closest tab when closing a tab that is not selected
2021-03-17 13:41:21 +02:00
Dan Stillman
ae98488d2b
Fix selectItem() on first items row (regression from d5334dc483)
2021-03-17 00:31:42 -04:00
Dan Stillman
c04f5c28a2
Update pdf-reader submodule
2021-03-17 00:17:53 -04:00
Dan Stillman
d5334dc483
Fix item tree breakage if annotation is added while search is active
2021-03-17 00:14:43 -04:00
Martynas Bagdonas
bb2f1ced99
Position pdf-reader color popup by element instead of coordinates
2021-03-15 20:27:24 +02:00
Dan Stillman
b3e46392ba
Update pdf-reader
2021-03-14 19:12:48 -04:00
Dan Stillman
ed70b404ad
Tweak zoom labels in PDF reader context menu
...
"Automatic" → "Automatically Resize"
"Page Width" → "Zoom to Page Width"
2021-03-12 06:59:53 -05:00
Dan Stillman
76d504c564
Delete child annotations when deleting attachment
...
And fix a FK definition that could result in orphaned `items` rows
without `itemAnnotations` rows after an attachment was deleted.
2021-03-12 06:35:21 -05:00
Dan Stillman
0bc6b2ccc6
Transfer annotations when converting linked files to stored files
...
Previously, any annotations on the linked file were partially deleted,
leaving broken `items` rows without `itemAnnotations` rows.
2021-03-12 06:35:21 -05:00
Martynas Bagdonas
7b0bd05865
Add PDF page context menu, update editor & reader
...
Fixes #1978
2021-03-11 17:24:48 +02:00
Dan Stillman
cbfaed7abf
Update locales from Transifex and merge new English strings
2021-03-10 11:00:48 -05:00
Dan Stillman
98c101fd55
Notes pane: Change "Delete" to "Move to Trash" and remove confirm()
...
And remove unused _removeNote() function
We prompt to delete in the items list to distinguish from collection
removals, but it's arguably not necessary here, since you can always get
the item out of the trash. Undo would be nice, though.
2021-03-10 11:00:48 -05:00
Dan Stillman
24cc59cc7e
Compress single-file HTML attachments and other text files
...
The test for ZIP uploads was having multiple files, but now snapshots
are all single files.
2021-03-10 09:37:52 -05:00
Dan Stillman
249d1aa0da
Mendeley import: Add log lines for timing pdf-worker
2021-03-10 09:37:52 -05:00
WesleyFord
657832521f
Fix background color of the dropdown menu.
2021-03-09 13:24:52 -05:00
Martynas Bagdonas
13cafe886e
Rework note editor toolbar and related UI
2021-03-09 17:37:44 +02:00
Dan Stillman
824f67cb36
Mendeley import: Ignore empty text highlights
2021-03-08 10:58:15 -05:00
Dan Stillman
e4d7089506
Mendeley import: Fix blank PDF attachment MIME type from previous imports
2021-03-08 09:55:26 -05:00
Dan Stillman
5cdc088c49
Mendeley import: Import highlight and note annotations
...
Using new PDF worker functionality
If you've previously imported, you should be able to import again to get
annotations in the new PDF reader.
Details:
- Text highlights will be processed to extract text
- Rectangle highlights will turn into image annotations
- Any extracted-annotation notes created by previous improts won't be
removed, but they're no longer created as long as the file exists.
2021-03-08 09:05:07 -05:00
Dan Stillman
c16432b217
Mendeley import: Set contentType for PDFs
2021-03-08 09:04:40 -05:00
Dan Stillman
3af4793f7f
Don't log warning when opening a PDF for the first time
...
"Setting contains an invalid attachment page index ('null') -- discarding"
Fixes #1973
2021-03-07 02:30:21 -05:00
Martynas Bagdonas
6e49da1452
Add notes list context menu
...
Fixes #1979
2021-03-06 00:51:00 +02:00
Martynas Bagdonas
a1206e8901
Add Mendeley annotations processor
2021-03-05 21:26:49 +02:00
Martynas Bagdonas
8b1b2ee56a
Fix ctrl+something default keyboard shortcuts
2021-03-04 17:02:10 +02:00
Dan Stillman
586a6f1ddf
Fix time zone of note modification time in notes pane
2021-03-03 17:06:27 -05:00
Dan Stillman
bda52827da
Reset note font size to 14 for new editor
2021-03-03 16:03:31 -05:00
Dan Stillman
f42393c4f3
Update version
2021-03-03 15:40:48 -05:00
Dan Stillman
49906c3fa0
Add "Export PDF" options to File menu
...
Quick implementation, but works on parent items or PDF attachments
Currently always includes annotations, but we'll want that to be an
option
2021-03-03 15:31:37 -05:00
Dan Stillman
2cea1a50f5
Fix Translate.ItemGetter test
...
All we care about is whether annotations were excluded, so don't bother
counting all items.
2021-03-03 09:08:08 -05:00
Dan Stillman
8c1f10c782
Fix additional sync test after format=json removal
2021-03-03 08:53:28 -05:00
Dan Stillman
903fc4d9a7
Fix another cause of syncEventListener test failure
2021-03-03 08:39:45 -05:00
Dan Stillman
e8b19934e2
Fix pref setting in syncEventListener tests
...
Prefs are reset after every test
2021-03-03 07:15:48 -05:00
Dan Stillman
9204e18ee3
Fix sync test after removing format=json from syncAPIClient
2021-03-03 06:42:08 -05:00
Dan Stillman
914f86839c
Fix test failure in libraryTreeView after items test
2021-03-03 06:23:54 -05:00
Dan Stillman
92a073314a
Enable PDF reader pref for tests
2021-03-03 05:52:57 -05:00
Dan Stillman
8d7eee0300
CI: Recursive submodule checkout
2021-03-03 05:30:34 -05:00
Dan Stillman
46c4e82824
Switch submodule URLs from SSH to HTTPS
2021-03-03 05:24:09 -05:00
Dan Stillman
f0992f959c
Merge PDF reader branch
2021-03-03 04:50:58 -05:00
