Commit graph

12263 commits

Author SHA1 Message Date
Martynas Bagdonas
e4e3c72036 Fix PDF reader selector popup that was never opening 2022-08-11 12:18:32 +03:00
Martynas Bagdonas
0857cefb0c Fix regression preventing opening PDF reader window when the tab is open 2022-08-11 12:18:32 +03:00
Dan Stillman
9b7b4fe134 Improve test for event-title substitution
And add comments

Follow-up to 20d0f103f
2022-08-10 01:34:57 -04:00
Dan Stillman
a9c3fc7790 Reset Zotero.locale to 'en-US' after cite test 2022-08-10 01:01:48 -04:00
Dan Stillman
20d0f103fd Automatically substitute event-title for event in styles
Stopgap until styles are updated in citation-style-language/styles#6151
2022-08-10 01:01:48 -04:00
Abe Jellinek
20eca3781d Add test for 87455d 2022-08-08 11:48:33 -04:00
Abe Jellinek
87455d28c3 Item box: Fix fieldMode resetting after editor hidden twice
hideEditor() called switchCreatorMode() too early, setting the fieldMode
attribute on the soon-to-be-discarded textbox instead of the label
replacing it. Then, showing the editor a second time would carry over an
empty fieldMode attribute from the label to the new textbox. Hiding that
editor would update the creator in the item to fieldMode = 0 and trigger
a save.

Moving the switchCreatorMode() call does the trick, and the flex
settings changes still work fine when made there.
2022-08-08 10:56:56 -04:00
Abe Jellinek
2048319541
Advanced Search: Make sure items are loaded (#2743) 2022-08-06 15:00:33 -04:00
Dan Stillman
d03b0a716d Don't preselect Act for multiple sources in classic citation dialog
"Multiple Sources…" wasn't properly handled by 629892b0b8

https://forums.zotero.org/discussion/98877/act-instead-of-page
https://twitter.com/drezvera99/status/1554521940684984320
2022-08-06 02:29:26 -04:00
Abe Jellinek
bb2b37a73a Item box: Prevent tabbing to hidden fields
This one's probably been around for a while! Reproduce by creating an
item with a fieldMode = 1 creator, tabbing past the creator, and then
shift-tabbing back to it. Your cursor will end up in the invisible first
name field and further shift-tabs can't move it past.

Cherry-picked from fx102: 080ada78ee
2022-08-05 16:31:09 -04:00
Martynas Bagdonas
7ec54fdaa9 Select existing unloaded tab instead of opening a new one
Fixes #2740
2022-08-05 18:22:30 +03:00
Martynas Bagdonas
5a659b070d Allow to scroll tabs with mouse wheel
Fixes #2724
2022-07-29 13:06:33 +03:00
Abe Jellinek
ad96323881
Duplicates Merge: Preserve embedded annotations (#2728) 2022-07-29 05:06:44 -04:00
Adomas Venčkauskas
fc0f6157d0 Do not load-timeout on browser PDF download during content load
Closes #2726
2022-07-26 13:49:23 +03:00
Martynas Bagdonas
6733f2edca Freeze note schema version to 8
We can do it because it was only used to create a note from annotations.

No need to update schema version in Zotero client, unless using new
features when creating a note from annotations.
2022-07-25 18:04:00 +03:00
Martynas Bagdonas
e1997620a4 Fix regression that prevents showing the last selected tab on startup
Fixes #2723
2022-07-25 11:51:05 +03:00
Dan Stillman
a396771cbc Update version 2022-07-23 03:56:26 -04:00
Dan Stillman
0e0997078b Update global schema 2022-07-23 03:26:40 -04:00
Martynas Bagdonas
0785b3a086 Fix regression that prevents showing new notes in contextPane notes list 2022-07-21 13:27:32 +03:00
Adomas Venčkauskas
ba5cb7d5c6 Fixes some assets not being saved with SingleFile snapshots
Part of zotero/zotero-connectors#394

When saving an item (e.g. on arxiv) with a site translator, the
translator may add a custom snapshot attachment URL which does not match
the translation URL (the URL in the browser where translation was
initiated) in which case Zotero handles snapshot saving. Zotero loads
the page in a background browser. By default images are not loaded in
this browser. SingleFile due to CORS restrictions has to refetch all
resources that are not from the same domain or subdomain, but uses
pre-loaded resources (images) from the same domain. Before this change
any images that were from the same domain as the saved website were not
saved in the snapshot. This commit fixes that.
2022-07-20 14:28:56 +03:00
Adomas Venčkauskas
d822da4c06 Changes for updated SingleFile submodule 2022-07-20 14:28:56 +03:00
Adomas Venčkauskas
a297692487 Update SingleFile submodule 2022-07-20 14:28:56 +03:00
Dan Stillman
6921268dc0 Localize "Export PDF…" menu option
Fixes #2710
2022-07-20 01:04:00 -04:00
Dan Stillman
ba1906c054 Update version 2022-07-18 23:10:31 -04:00
Dan Stillman
b5be7cbd57 Update note-editor submodule 2022-07-18 19:47:23 -04:00
Dan Stillman
5c61815f36 Update translate submodule 2022-07-18 19:43:18 -04:00
Dan Stillman
b5ca5aed3a Update submodules 2022-07-18 19:14:24 -04:00
Dan Stillman
4b6598acc4 Update locales from Transifex 2022-07-18 08:57:41 -04:00
Dan Stillman
14a6ce000e Disable sort tests from 26a5e2900a for now
Until I can figure out the race-condition breakage they trigger later in
the file
2022-07-18 08:56:57 -04:00
Dan Stillman
9d0cd005f8 Increase Mendeley API timeout to 60 seconds
To see if we can fix the 30-second timeout here:

https://forums.zotero.org/discussion/comment/412750/#Comment_412750
2022-07-18 08:29:45 -04:00
Dan Stillman
26db75971e Update pdf-reader submodule 2022-07-18 03:51:09 -04:00
Dan Stillman
cc45e9019b Apply Big Sur styling when macOS version comes through correctly
Follow-up to zotero/zotero-standalone-build@f7a506a32 -- now that some
people are somehow getting an accurate macOS version number, we need to
apply the Big Sur CSS to all higher versions.

https://forums.zotero.org/discussion/98406/zotero-will-not-open-mac-os-monterey
2022-07-17 05:09:05 -04:00
Dan Stillman
98d6f40e4a Add warning in toolbar for 'dev' channel builds 2022-07-16 04:19:42 -04:00
Martynas Bagdonas
2cad5b00d1 Use Quick Copy (Markdown) for direct plain-text copying from note-editor
Fixes #2505
2022-07-15 15:06:19 +03:00
Abe Jellinek
95239db0fd Prevent deleting My Publications
Previously showed a blank confirmation dialog and logged an error.
2022-07-13 16:23:50 -04:00
Martynas Bagdonas
4c063e7b6e Prevent delayed context pane expansion and pdf-reader rerender/resize when switching from library tab 2022-07-12 18:00:21 +03:00
Martynas Bagdonas
07f1517712 Don't include quotes when {{highlight}} is placed in a blockquote
Fixes #2697
2022-07-12 12:12:21 +03:00
Martynas Bagdonas
f0e0971c69 Include quotation marks for highlights by default, but allow to disable
Fixes #2697
2022-07-11 15:32:02 +03:00
Dan Stillman
acba90f272 Fix test failure after 26a5e2900a 2022-07-11 05:19:18 -04:00
Dan Stillman
26a5e2900a Better fix for errors from invalid sort fields
Just catch the error from `ItemTree::sort()` and clear the
secondary-sort and fallback-sort prefs so that sorting works on the next
attempt.

Replacement for a8ed30ce80

https://groups.google.com/g/zotero-dev/c/kc0-C6-SA74/m/bhHniGceAQAJ
2022-07-11 01:30:38 -04:00
Dan Stillman
34d66381d1 Revert "Validate fields in ItemTree::getSortFields()"
This reverts commit a8ed30ce80 and related
commits.

We'll address breakage from invalid sort fields another way, without
inconveniencing plugin authors.

https://groups.google.com/g/zotero-dev/c/kc0-C6-SA74/m/bhHniGceAQAJ
2022-07-11 00:43:15 -04:00
Dan Stillman
f7dbcdde4b Sort empty rows last for Date/Year columns when descending
Date columns start in descending order, so put empty rows at end

Also remove a seemingly unnecessary exception for Title when not the
primary sort and just always sort it with empty rows first
2022-07-10 23:47:02 -04:00
Dan Stillman
c4563af381 Fix sorting of attachments and notes columns
Regression from a8ed30ce80
2022-07-10 23:26:36 -04:00
Dan Stillman
56e7f0a10f Fix sorting by Item Type and feed item itemID
Regression from a8ed30ce80
2022-07-10 17:31:01 -04:00
Dan Stillman
3a160b2630 Increase downloadPDFViaBrowser.onLoadTimeout to 3000
Apparently necessary for some people to get PDFs on ScienceDirect. We
should come up with a better way of detecting the page load if we can,
so that we can avoid this long of a timeout for people who just will
never have access to ScienceDirect PDFs.

https://forums.zotero.org/discussion/comment/411056/#Comment_411056

Addresses #2698
2022-07-10 06:40:32 -04:00
Dan Stillman
124c18d54d CookieSandbox: Fix error setting request cookies
Regression from 6af3b0276a, showing up as "trackedBy is undefined" error

https://forums.zotero.org/discussion/98322/no-snapshot-or-pdf-autosaved-using-zotero-connector-on-safari
2022-07-10 06:28:56 -04:00
Dan Stillman
57c582e171 Merge new English strings 2022-07-09 18:08:38 -04:00
Dan Stillman
cf8819cc06 Add localized string for timestamp CSL locator
Not included in the CSL locales:

https://forums.zotero.org/discussion/comment/412060/#Comment_412060
2022-07-09 18:07:07 -04:00
Dan Stillman
fe74b02d28 Merge new English strings 2022-07-09 01:56:56 -04:00
Dan Stillman
1dcc2728dd Tweak confirmation message for recursive collection-item removal
I guess the "its" is technically a little clearer, but it's a bit
awkward, and I think it's reasonably implied.
2022-07-09 01:54:07 -04:00