mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
9521 commits 9 branches 364 tags 290 MiB
Commit graph

788 commits

Author SHA1 Message Date
Dan Stillman
05d74c4cac Don't load note/attachments counts as primary data 
Zotero.Item::numNotes()/numAttachments() now require 'childItems' to
have been loaded.

Fixes #1301, Slow startup with many items in trash
 2017-08-30 18:08:25 -04:00
Dan Stillman
687f86af71 Allow parentID in importFileAttachment() test support function 
The Zotero.Attachments functions only take parentItemID, but
createDataObject() takes parentID.
 2017-08-30 18:08:25 -04:00
Dan Stillman
f4b73d22b8 Fix error relocating to filename with different Unicode normalization 2017-08-23 11:02:05 +02:00
Dan Stillman
6673c64ac6 Fix accessDate when translators set CURRENT_TIMESTAMP 
(But it also seems like we always do that automatically for web
translators, so I'm not sure why so many translators set that.)
 2017-08-19 15:21:57 +02:00
Dan Stillman
7386b376f3 Fix linked attachment base directory handling at drive root 
The first letter of the relative path was being removed on save if the
base directory was set to the drive root (e.g. D:\ instead of D:\foo).
 2017-08-18 16:06:56 +02:00
Dan Stillman
1efe54e896 Fix #1286, Show proper error messages for OS.File errors 2017-08-17 15:43:54 +02:00
Dan Stillman
13cd84e1be Fix attachment-download test 2017-08-16 01:42:21 +02:00
Adomas Venčkauskas
a5a7df328a Changes imports from connector to save to selected collection 
Closes #1289
 2017-08-15 11:35:53 +03:00
Dan Stillman
2770860968 Don't update storage version if file sync is stopped 
Otherwise subsequent syncs won't download the remaining files until
there's a remote storage change.
 2017-08-11 22:29:40 +02:00
Dan Stillman
9069559050 Improve logic for determining whether to check for files to download 
This should fix cases of files not being downloaded after interrupted
syncs until the next time files were changed remotely.
 2017-08-11 22:29:40 +02:00
Dan Stillman
9202ab8b3c Download missing attachments as needed even in at-sync-time mode 2017-08-11 16:06:06 +02:00
Dan Stillman
678a6e15cc Better Unicode path comparison in WebDAV.purgeOrphanedStorageFiles() 2017-08-10 04:41:16 +02:00
Dan Stillman
8b7f33826e Fix sync test after 7b0ed6da81 2017-08-05 01:41:21 +02:00
Dan Stillman
c110e64293 Consider fulltextItems with SYNC_STATE_MISSING as unindexed 
The items will still match full-text word searches, but they won't match
phrase searches (because those require cache files for non-text
attachments) and the full-text won't sync to other computers, so they
should really be reindexed.
 2017-07-26 22:16:01 -04:00
Dan Stillman
67ccb632b4 Don't keep looking for unsynced full-text content that isn't available 
This can happen if cache files are deleted for PDF attachments or if
text files are missing.
 2017-07-26 22:16:01 -04:00
Dan Stillman
61f8a2c3c5 Fix various problems with fulltextContent searches 
Including finding items in the wrong library and not finding any items
when paired with the checkboxes in ANY mode
 2017-07-26 22:16:01 -04:00
Dan Stillman
46531a4c69 Remove non-matching parent items when deleting items from trash 
Fixes #866, Trash doesn't refresh properly when emptying deleted
attachments
 2017-07-26 22:16:01 -04:00
Dan Stillman
c2234176aa Disable debug output logging test for now 
This should be tested, but we run tests in Firefox, and this doesn't
exist in Firefox... Easiest option is probably to add the submenu to the
Firefox menus for the purposes of testing.
 2017-07-25 03:29:41 -04:00
Dan Stillman
225215842d Fix auto-syncing of unchecked groups after object change 2017-07-21 19:39:37 -04:00
Dan Stillman
6d2c72fb54 Fix revealing parent directory of missing file 
Updates Zotero.File.getClosestDirectory() to take a path rather than an
nsIFile
 2017-07-21 18:33:36 -04:00
Dan Stillman
316a6f91b2 Test for tag selector search 2017-07-20 18:25:12 -04:00
Adomas Venčkauskas
84c1367e7b Adjust connector server test for ece3491e2 2017-07-19 11:55:46 +03:00
Dan Stillman
cd35962435 Fix Quick Copy tests after 6d265f448f 2017-07-19 04:36:45 -04:00
Dan Stillman
ef7da3486a New state-handling approach for item tag changes 
If this works out I think we'll want to use this approach for
all data layer changes.

Previously, an unsaved change on an object would update its state
immediately, which was fine for synchronous code but breaks down if a
save involves multiple asynchronous calls, because modifying state after
the relevant data has been saved to the DB but before the `_changed`
object has been cleared would mean that new changes would be lost. Now,
changes are written to _changedData, and a get for the data first checks
_changedData before checking the state property (e.g., _tags) directly.
The changedData property is cleared as it's written, and once the object
is saved, the reload updates the state property with the new data.
 2017-07-18 17:31:40 -04:00
Dan Stillman
e683b2be07 Fix a potential sync error with child attachments 
If a standalone attachment existed in a collection and then was added to
a parent (e.g., via Create Parent Item), and attachment metadata was
also changed at the same time (e.g., due to file syncing), the
'collection item must be top level' trigger could throw on another
syncing computer. To work around this, remove collections first, then
make changes to the parentItemID columns, and then add new collections.
 2017-07-11 02:35:11 -04:00
Dan Stillman
de3b47fd78 Add "Delete Automatic Tags in This Library…" option to tag selector menu 
I think it might be worth having a tag management window that lets you
view tags as a grid, sort by column (e.g., type), select ranges, delete,
consolidate, etc., but until then, this fulfills a popular request.
 2017-07-07 18:19:12 -04:00
Dan Stillman
f7c1c56d7d Use 'async' configOptions property to indicate promisified translators 
Instead of >"2017-07-05"

Addresses https://github.com/zotero/translators/issues/1353
 2017-07-05 15:29:13 -04:00
Dan Stillman
198bd70b59 Make 909b4b31c8 apply to search translators too, and fix tests 
Addresses https://github.com/zotero/translators/issues/1353
 2017-07-05 09:15:12 -04:00
Dan Stillman
88088c68db Add Sync.Storage.Local.updateSyncStates() 
This speeds up updating of sync states, particularly after resetting
file sync history.
 2017-07-01 06:31:46 -04:00
Dan Stillman
9a3ff2d244 Add .contentType and .charset options for importFromFile() 
And use them in new importTextAttachment() and importHTMLAttachment()
test support functions. These can be used to avoid needing a hidden
browser for determining the character set of the imported text
documents.
 2017-07-01 06:31:46 -04:00
Dan Stillman
b1fad5a310 Automatically run JS build process before tests if not running 2017-07-01 06:31:46 -04:00
Dan Stillman
22eab3e09d Don't leave file descriptor open in md5Async() 
This could cause "Too many open files" errors during file syncing
 2017-06-30 17:54:33 -04:00
Dan Stillman
e89778c1ab Remove some code that's unnecessary now that we're Fx52+ everywhere 2017-06-23 05:03:11 -04:00
Dan Stillman
c11f1069d7 Add -e flag to runtests.sh to stop tests after a given file 
This is useful when trying to debug an error that only happens after a
number of other tests have run -- specify -e and run tests from either
an earlier file with -s or from the beginning.
 2017-06-20 05:48:38 -04:00
Dan Stillman
7c020da594 Don't run feeds update until after schema update promise 
And tweak feed scheduling in general
 2017-06-19 01:25:03 -04:00
Dan Stillman
26145c3892 Additional prefs in tests to bypass Telemetry prompt 2017-06-19 00:42:31 -04:00
Dan Stillman
1a0f125d78 Maybe fix browser test failures by preloading translators 2017-06-19 00:40:52 -04:00
Dan Stillman
47741e75fa Restore locally deleted collections and searches that changed remotely 
Also restore items that were in the collections
 2017-06-18 09:11:21 -04:00
Dan Stillman
859c506913 Never auto-select new groups, since they always come from syncs 
Fixes test failure from 2e74cd7831
 2017-06-16 05:59:44 -04:00
Dan Stillman
69041832e7 Remove Zotero_Browser tests for new Firefox windows 
I'm not sure if we need the browser tests at all -- we still translate
some things via hidden browsers, and I'm not sure what we have that
tests that -- but we definitely don't need to test saving before the
Zotero pane is opened.
 2017-06-16 04:55:29 -04:00
Dan Stillman
4032edcf7d Ignore note markup conflicts without cache when text content matches 2017-06-14 03:37:03 -04:00
Dan Stillman
3ebc238320 Close prefs window after WebDAV Verify Server tests 2017-06-14 03:37:03 -04:00
Dan Stillman
ccb30351c0 Fix incorrect purging of files on WebDAV 2017-06-14 03:20:23 -04:00
Adomas Venčkauskas
a17b486e4b Don't auto-migrate data dir if target on a different drive 
See https://forums.zotero.org/discussion/comment/277632/#Comment_277632
 2017-06-13 17:17:34 -04:00
Dan Stillman
98f1ac5edb Merge pull request #1240 from tnajdek/master 
Tweaks to make build work on Windows
 2017-06-06 02:18:45 -04:00
Dan Stillman
cd6079d869 Relax last-sync-time check in sync runner test 2017-06-06 02:14:23 -04:00
Tom Najdek
e86bbfbda0 Tweak test runner to work in MSYS environment on Windows 2017-06-06 00:36:03 -04:00
Dan Stillman
b79ecfb5fe Temporarily disable test for non-integer getAsync() 2017-06-05 03:00:15 -04:00
Dan Stillman
898a1dc679 Add alternative to padStart for test in Fx45 2017-06-01 16:44:11 -04:00
Dan Stillman
05ff16c17f Fix some breakage from 013dc958b3 2017-06-01 15:39:42 -04:00
Dan Stillman
ede03f4366 Update some Sinon reset() calls 
In Sinon 2, reset() now resets both behavior and history, so if a stub
specifies behavior and we want to use it again, we have to call
resetHistory().
 2017-06-01 15:39:42 -04:00
Tom Najdek
a59b78e59e Tweak test syntax that breaks with current version of chai-as-promised 
* Second parameter should be an optional message, however is treated
  as a string that should be contained in the error message
 2017-06-01 11:36:18 -04:00
Tom Najdek
4ec6925220 Remove "Error:" expected in error messages. 
* "Error:" seems to have been injected into the message by Bluebird,
  but that's no longer the case
 2017-06-01 11:36:18 -04:00
Tom Najdek
063e13ef22 Modernize sinon.stub() calls 2017-06-01 11:36:17 -04:00
Tom Najdek
289b049377 Support generators in tests via coMocha, instead of custom code 
* coMocha offers better error stack trace
 2017-06-01 11:36:17 -04:00
Tom Najdek
14bf3184bb Fixes and tweaks to make tests work with babelized code 
* Use mocha, chai & sinon from the npm. As of sinon 2.0
  sinon-as-promised is no longer required so it is removed
* Tweak code to re-use the same loader with the same environment
  throghout the code
* Introduce browserify step for testing tools that only provide
  node-compatible libraries (sinon, chai-as-promised)
* Introduce copy step for test data to resolve multiple issues with
  tests depending on files not being symlinks
* Re-introduce custom implementation of setTimeout to resolve issues
  with few tests
* Re-introduce custom Bluebird Promises config & monkey patch
 2017-06-01 11:36:16 -04:00
Dan Stillman
748c30206f Run tests from build dir 2017-06-01 11:36:16 -04:00
Dan Stillman
1e459287de Convert non-standard octal escape sequences to hex in test runner 2017-05-24 01:59:56 -04:00
Dan Stillman
c0f7f6070a Avoid a warning from a storageRequest test from the item not existing 2017-05-23 02:12:00 -04:00
Dan Stillman
e1fb28faa9 Convert some object ids from strings to integers after 4e1937680 2017-05-23 02:10:26 -04:00
Dan Stillman
265df6d48c Skip edit check if skipAll is passed to object save 2017-05-22 17:29:56 -04:00
Dan Stillman
1b8704f133 Firefox 54 compatibility: File.createFromFileName() returns a promise 2017-05-22 06:04:27 -04:00
Dan Stillman
a3eea03a38 Firefox 54 compatibility: rename "new" and "delete" XBL methods 2017-05-22 06:03:14 -04:00
Dan Stillman
fc4eb5308f Remove related-item relations when deleting item 2017-05-19 12:11:51 -04:00
Dan Stillman
90a27f8d4b Add Zotero.URI.getURIItemLibraryKeyFromDB() 
Allows getting libraryID and key without relying on library data being
loaded (e.g., at startup)
 2017-05-19 12:11:21 -04:00
Dan Stillman
f12ae67c47 Test for e1986b460e (export with empty attachment path) 2017-05-14 05:26:39 -04:00
Dan Stillman
20121b9b97 Fix tag selector tests (broken in 5963c02db) 2017-05-12 06:13:02 -04:00
Dan Stillman
5963c02dbb Fix "Display All Tags in This Library" (broken in fe186333b) 2017-05-12 05:37:46 -04:00
Dan Stillman
60810ea0a0 Fix access date without time coming from sync 2017-05-11 00:44:37 -04:00
Dan Stillman
12e70460dc Load polyfill in tests for Object.values() support in Fx45 2017-05-08 18:48:11 -04:00
Adomas Venčkauskas
dbeecb9b0a Make itemFromCSLJSON independent of Zotero.Item existance. 
Addresses !zotero/zotero-connectors#121"
 2017-05-08 09:24:34 +03:00
Dan Stillman
e0e22225bc Fix entering date without time into Accessed 
https://forums.zotero.org/discussion/65560/5-0-beta-accessed-field-changes-dates
 2017-05-05 17:59:53 -04:00
Dan Stillman
40da5f61a0 Still process downloads if uploads fail for a library 2017-05-05 03:26:29 -04:00
Dan Stillman
a1bd2bace5 Remove objects from sync queue if missing from response 
While objects in the sync queue that fail to save should remain in the
queue, objects that just don't exist remotely need to be removed, or
else they'll be retried forever.
 2017-05-05 01:04:16 -04:00
Dan Stillman
7a839e19a6 Fix background/stopOnError options for sync engine tests 2017-05-05 00:26:43 -04:00
Dan Stillman
2eef1702e0 Prevent items in group libraries from being added to My Publications 
And remove existing group items that have been added
 2017-05-04 21:18:44 -04:00
Adomas Venčkauskas
37fa0c203f Write sessionID into the doc on new session creation 2017-05-03 14:34:00 +03:00
Adomas Ven
7d79865023 Merge pull request #1222 from adomasven/feature/document-preferences-cleanup 
Document preferences cleanup
 2017-05-03 13:09:49 +03:00
Dan Stillman
5b0b874435 Purge old objects in sync cache after upload 2017-05-03 03:43:59 -04:00
Dan Stillman
aa1fc01b31 Fix syncing of related item removal 2017-05-02 20:15:54 -04:00
Adomas Venčkauskas
3c19bbffe4 Remove store references in document option. Closes #1216 2017-05-02 16:29:19 +03:00
Adomas Venčkauskas
5e3c7bf63d Fix test breakage from a76493f60 2017-05-02 15:09:12 +03:00
Dan Stillman
32b1769f2f integrationTests.js -> integrationTest.js 2017-04-28 04:12:19 -04:00
Dan Stillman
fe88530120 Recover from a remotely missing parent collection 2017-04-28 03:18:50 -04:00
Dan Stillman
9bd01af2a5 Disallow inPublications for linked-file attachments 2017-04-27 15:33:24 -04:00
Dan Stillman
d715197b2f Don't show Show/Hide button in My Publications for linked files 2017-04-27 04:52:50 -04:00
Dan Stillman
d527c340c6 Fix "text is not defined" error during full-text content sync 2017-04-26 02:44:01 -04:00
Adomas Venčkauskas
bbec11e3eb Prepare 5.0 to handle JSON doc prefs 2017-04-20 18:03:15 +03:00
Adomas Venčkauskas
e272465f6c Fix DocumentData serialization hairiness due to #htmlSpecialChars 
Add tests
 2017-04-20 13:39:19 +03:00
Dan Stillman
de7b56b8a1 Don't include items in My Publications in Unfiled Items 2017-04-17 21:34:08 -04:00
Dan Stillman
b3277de5ae Update tests after citeproc-js upgrade to match output 2017-04-15 04:35:16 -04:00
Dan Stillman
e397d12d42 Update whitespace chars in cleanISBN/cleanISSN tests for Firefox 52+ 
Farewell, Mongolian Vowel Separator
 2017-04-14 23:14:22 -04:00
Adomas Venčkauskas
49001572fd Remove dependency on zoteroIntegration.idl 2017-04-14 14:19:52 +03:00
Adomas Venčkauskas
0de22b132e Move document plugin interface description into integrationTests 2017-04-14 14:19:52 +03:00
Dan Stillman
9c91018964 Reduce indentation in waitForWindow() support function 2017-04-13 05:51:52 -04:00
Dan Stillman
6d18b46165 Fix test breakage after 5ff2a59f87 
And remove all instances of `publicationsLibraryID`
 2017-04-13 00:15:05 -04:00
Dan Stillman
5ff2a59f87 Move My Publications into My Library 
Instead of My Publications being a separate library, have it be a
special collection inside My Library. Top-level items can be dragged
into it as before, and child items can be toggled off and on with a
button in the item pane. Newly added child items won't be shown by
default.

For upgraders, items in the My Publications library will be moved into
My Library, which might result in their being duplicated if the items
weren't removed from My Library. The client will then upload those new
items into My Library.

The API endpoint will continue to show items in the separate My
Publications library until My Publications items are added to My
Library, so the profile page will continue to show them.
 2017-04-12 19:26:58 -04:00
Dan Stillman
4da0c4c1fc Remove unused laststoragesync response from test 2017-04-12 05:37:15 -04:00
Adomas Venčkauskas
7657c9044d Add Document.addEditBibliography to integration.js 
See zotero/zotero-word-for-windows-integration#28 for background
 2017-04-12 11:59:38 +03:00
Adomas Ven
2a5dbaa204 Merge pull request #1202 from adomasven/fix/doc-pref-window-unloaded-styles 
Fix document preferences dialog failing when styles unloaded.
 2017-04-12 11:52:58 +03:00