Update some Sinon reset() calls

In Sinon 2, reset() now resets both behavior and history, so if a stub
specifies behavior and we want to use it again, we have to call
resetHistory().
This commit is contained in:
Dan Stillman 2017-06-01 15:30:06 -04:00
parent 522391bc3e
commit ede03f4366
5 changed files with 12 additions and 11 deletions

View file

@ -99,16 +99,16 @@ describe("Zotero.FeedItems", function () {
ids = Array.map(items, (i) => i.id);
});
after(function() {
save.restore();
});
afterEach(function* () {
save.reset();
yield clearFeeds();
});
after(function() {
save.restore();
});
it('should toggle all items read if at least one unread', function* () {
items[0].isRead = false;
yield items[0].saveTx();

View file

@ -308,9 +308,6 @@ describe("Zotero.Feed", function() {
before(function() {
scheduleNextFeedCheck = sinon.stub(Zotero.Feeds, 'scheduleNextFeedCheck');
});
after(function() {
scheduleNextFeedCheck.restore();
});
beforeEach(function* (){
scheduleNextFeedCheck.reset();
@ -323,6 +320,10 @@ describe("Zotero.Feed", function() {
yield clearFeeds();
});
after(function() {
scheduleNextFeedCheck.restore();
});
it('should schedule next feed check', function* () {
let feed = yield createFeed();

View file

@ -54,7 +54,7 @@ describe("Sync Preferences", function () {
beforeEach(function* (){
yield win.Zotero_Preferences.Sync.unlinkAccount(false);
deleteAPIKey.reset();
deleteAPIKey.resetHistory();
Zotero.alert.reset();
});

View file

@ -144,7 +144,7 @@ describe("Zotero.Sync.APIClient", function () {
if (spy) {
spy.restore();
}
delayStub.reset();
delayStub.resetHistory();
});
after(function () {

View file

@ -632,7 +632,7 @@ describe("Zotero.Sync.Runner", function () {
assert.isTrue(stub.calledOnce);
assert.isFalse(group.editable);
stub.reset();
stub.restore();
});
})