Commit graph

15045 commits

Author SHA1 Message Date
cfede61283 Inject custom workflow
All checks were successful
/ Build tarball w/ submodules (push) Successful in 1m58s
/ Upload to generic repo (push) Successful in 24s
2024-12-06 15:01:49 +00:00
Dan Stillman
0a60953226 Update reader submodule 2024-12-06 04:38:01 -05:00
Abe Jellinek
886dbd17ff Abstract box: Use focused getter instead of :focus-within
See b4c5c5d539

Fixes #4878
2024-12-05 14:39:27 -05:00
Dan Stillman
d57392d810 Update reader submodule 2024-12-04 16:44:52 -05:00
Dan Stillman
6740115cf2 Revert "Fix Item Pane unstable rendering during scrolling (#4879)"
Regressions:

https://forums.zotero.org/discussion/120216/blinking-item-pane-when-switching-item-with-pinned-section-in-the-sidenav
https://forums.zotero.org/discussion/120217/title-field-is-not-visible-anymore-after-creating-a-new-item-if-a-section-is-pinned-in-the-sidenav

This reverts commit 4067745c7a.
2024-12-04 01:35:04 -05:00
Martynas Bagdonas
8317f77837 Trigger annotation import only for PDF attachments when creating a note
Fixes https://forums.zotero.org/discussion/120181/batch-create-note-from-annotations-for-different-attachment-types
2024-12-03 21:24:37 +00:00
Abe Jellinek
1c70e53006
Fix several automatic relinking regressions due to PathUtils (#4887) 2024-12-03 16:23:00 -05:00
Dan Stillman
6fe2772318 Update locales from Transifex 2024-12-03 16:15:48 -05:00
Dan Stillman
0f415063ce Update styles 2024-12-03 16:11:24 -05:00
Dan Stillman
5939f53e9a Update reader submodule 2024-12-03 16:10:22 -05:00
windingwind
4067745c7a
Fix Item Pane unstable rendering during scrolling (#4879)
Fix wrong vertical position in the Item Pane after switching from a note

fix: #4276
2024-12-02 22:42:32 -05:00
Dan Stillman
99b80723b8 Move special handling of 'timestamp' locator
Avoid "Locator 'timestamp' is empty in en-US locale" warning when
opening citation dialog after 969feb620d
2024-12-02 22:39:34 -05:00
Dan Stillman
b5310d5f04 Update note-editor submodule 2024-11-30 01:51:15 -05:00
Dan Stillman
969feb620d Add "Timestamp" to locator menu
https://forums.zotero.org/discussion/comment/480030/#Comment_480030
2024-11-30 01:47:00 -05:00
windingwind
7296583f2a
Fix item pane custom info row render after item change (#4875)
Add test for info row render after item change
fix: #4874
2024-11-29 16:18:31 -05:00
A1lo
c9c373854c
correct the value of the private field in package.json (#4870) 2024-11-28 00:00:58 -05:00
Dan Stillman
052cbb7702 Update reader submodule 2024-11-27 23:58:27 -05:00
abaevbog
247826194a
fix advanced search anyField condition breakage (#4873)
Process "joinMode" before other conditions that may rely on it

Fixes: #4871

Co-authored-by: Dan Stillman <dstillman@zotero.org>
2024-11-27 23:43:09 -05:00
Dan Stillman
bacb60a103 Fix failure loading feed if no link and no url
APA feed link here:

https://forums.zotero.org/discussion/119954/issue-adding-new-feed-from-url-in-zotero-7
2024-11-26 22:44:48 -05:00
Abe Jellinek
0e2427fc9f Scaffold: Correct field help 2024-11-26 11:04:25 -05:00
Abe Jellinek
5a005b9adb Scaffold: Clean up tab select code slightly 2024-11-26 11:01:18 -05:00
Abe Jellinek
08ed672445 Update translate submodule 2024-11-26 10:48:39 -05:00
Abe Jellinek
bb0d7ab951 PageData actor: Settle for readyState "interactive"
Some pages seemingly never become "complete". "interactive" (which we
already use in TranslationChild) is equivalent to DOMContentLoaded, and
that's enough for everything PageDataChild needs to do right now.

This should make Scaffold test runs more reliable. TranslatorTester uses
{ requireSuccessfulStatus: true }, which calls the PageData actor, and
that was occasionally flaking and causing the test to time out.

Fixes #4869
2024-11-26 10:16:49 -05:00
Dan Stillman
501b7a9801 Update reader submodule 2024-11-26 05:53:48 -05:00
Dan Stillman
204c1e3514 Update version 2024-11-26 05:53:48 -05:00
Dan Stillman
ee4c244e0f Update translators 2024-11-26 02:34:02 -05:00
Dan Stillman
fa822b516c Update locales from Transifex 2024-11-26 02:34:02 -05:00
abaevbog
d698287558
context notes pane focus fixes (#4864)
- shift-tab from a note row focuses section header's twisty
- tab from reader into context pane will focus search
field. Previously focused note row will be focused on tab
from a section header's twisty
- fix focus not leaving context notes pane if all
sections are collapsed
- shift-tab from sidenav will focus the last node
in the contextPane, instead of search input. That is to
have consistent tab order in each direction.

Fixes: #4858
2024-11-26 02:27:55 -05:00
Abe Jellinek
2e202a59c9 Scaffold: Debounce ESLint 2024-11-25 14:02:48 -05:00
abaevbog
f824741d07
itemTree: handle restoring child item from trash in notify (#4796)
If a child item is restored from the trash and its parent row
exists and is open, collapse the parent row and expand it
to re-render child items.

Fixes: #4791
2024-11-22 06:41:55 -05:00
Dan Stillman
56ae6d9793 Update reader submodule 2024-11-21 02:59:46 -05:00
Dan Stillman
2ce9b4701b Update translators 2024-11-21 02:55:59 -05:00
Dan Stillman
5e92421114 Update reader submodule 2024-11-21 02:55:36 -05:00
Dan Stillman
9a578f8572 Update locales from Transifex and merge new English strings 2024-11-21 02:55:36 -05:00
abaevbog
a195750f31
context notes list focus handling followup (#4847)
- remember the last focused note-row in the contextPane
and, if possible, refocus it on shift-tab from sidenav, on
tab from the reader into notes pane, or on tab into the
notes list from the collapsible-section. Otherwise, focus the search input.
Per: https://github.com/zotero/zotero/pull/4837#issuecomment-2478108186

- when a note is opened in the context pane, let shift-tab
from sidenav place focus on the links-box. That way,
it is not skipped during tab navigation.

- fix focus not entering note-editor on Tab from the "Go back"
button and instead wrapping around to the current tab
2024-11-21 02:37:19 -05:00
Abe Jellinek
8c5a863aaf
macOS: Move Window → Zotero to platformKeys (#4778)
And change shortcut to Cmd-Shift-L to avoid conflicts with various
font size and zoom shortcuts.
2024-11-21 02:23:33 -05:00
Dan Stillman
5d0420a7d0 Add nsProcess NSIS plugin to check_requirements 2024-11-21 02:09:18 -05:00
Dan Stillman
e9f3d667b3 Windows signing fixes
- Sign zotero.exe in ZIP builds
- Re-sign xul.dll, which we modify in fetch_xulrunner
- Remove xul.dll.sig, a file for Widevine CDN that we don't need and
  that presumably doesn't match anymore
- Sign Word plugin DLL

https://forums.zotero.org/discussion/119766/tenable-invalid-signature-on-xul-dll
2024-11-21 01:14:38 -05:00
Abe Jellinek
bc2c7956db FeedProcessor: Handle dc:creator in Atom feeds
Fixes #4857
2024-11-20 10:05:39 -05:00
windingwind
f5b653e7fd
Add item tree and info box refresh API (#4850)
For APIs that have lifecycle control, e.g. item
pane section, the `update` is passed in the init
hook.
For APIs without lifecycle, we can't pass a value.
Instead, we provide a method to refresh in the API
instance.
2024-11-20 08:35:56 -05:00
windingwind
8e2ec86e56
Fix duplicate item pane when switching to library tab before reader is loaded (#4838)
fix: #4531
2024-11-20 08:09:42 -05:00
Abe Jellinek
e3f2f4455b
Fix sidenav buttons not getting :active state (#4853) 2024-11-20 07:46:37 -05:00
Dan Stillman
dc39ca3756 Don't detect MP3 with embedded image as JPEG
https://forums.zotero.org/discussion/119725/z-imports-mp3s-as-images-if-image-is-embedded-in-the-file

We were looking for "JFIF" anywhere in the sample, which could include
the ID3 tag.

(An upcoming change will also have it just trust the file extension when
one is available.)
2024-11-19 07:12:52 -05:00
Martynas Bagdonas
75fb301f0a
Add pref to control auto-turnoff of note, text, image annotation tools (#4851) 2024-11-19 05:47:43 -05:00
Dan Stillman
ddacfc0b8a Strip invalid quotes around charset in feed responses
E.g., https://bmcmedethics.biomedcentral.com/articles/most-recent/rss.xml
2024-11-19 05:03:36 -05:00
Dan Stillman
dc47650eb3 Update locales from Transifex 2024-11-15 03:54:01 -05:00
Dan Stillman
1a4ecff347 Update English strings for Transifex 2024-11-15 03:48:52 -05:00
Dan Stillman
3284cb461e Update reader submodule 2024-11-15 03:47:15 -05:00
abaevbog
7f57a43f27
context pane notes list focus handling edits (#4837)
- fix the issue of focus not landing on search field of the notes
pane when it is opened on tab from the reader
- shift-tab from the sidenav when notes pane is opened will focus
the search input as well, instead of the last focusable
node in the pane
- tab from a note-row in the list of notes will focus the sidenav
- shift-tab from a note-row will focus the header of the collapsible-section
of the row

Per https://github.com/zotero/zotero/pull/4235#issuecomment-2472397642
2024-11-15 03:29:01 -05:00
abaevbog
e3c18ee1c7
fix "anyField" conflicting with other conditions (#4845)
Fix the glitch where having anyField search condition
along with any other condition would return an empty
result set if joinMode="any".
This would happen due to a conflict between conditions
caused by wrapping "anyField" condition set into a quickSearch
block, which enforces "AND" operator between conditions.

Fixes: #4830
2024-11-15 02:07:11 -05:00