Commit graph

9169 commits

Author SHA1 Message Date
Abe Jellinek
bdea76024b
Add EPUB to Attachment File Type in Advanced Search (#3360) 2023-08-24 03:06:33 -04:00
Abe Jellinek
8f4cb5002a
Fix progress queue segfault (#3359) 2023-08-23 04:56:21 -04:00
Abe Jellinek
30c70a6ecd Defer removing tab content
Improves EPUB close performance.

By wrapping with requestIdleCallback(), we ensure:

  1. remove() won't be called right away, so the DOM elements being removed
     won't be visible and won't trigger a relayout.
  2. remove() won't be called while there are pending UI events, so it
     shouldn't cause the UI to hang/lag/stutter.

Combined, these two improvements make the UI hang when closing a large EPUB
mostly imperceptible on my machine.

Addresses #3321; doesn't completely fix it because there's likely more to be
done on the reader side to optimize the DOM.
2023-08-21 12:20:57 -04:00
Dan Stillman
38d0750dd3 Don't include parent title in tab title for secondary attachments
As suggested in https://github.com/zotero/zotero/issues/2731#issuecomment-1201382522
2023-08-20 02:26:58 -04:00
Tom Najdek
4f19b1d13e
Improve file renaming preview in preferences (#3343) 2023-08-19 05:06:08 -04:00
Dan Stillman
4dbd52782c Better fixing of tab-title logic
Follow-up to 3eef4284d1, which wasn't totally correct, and adds the
attachment title before the parent metadata for secondary attachments.

https://forums.zotero.org/discussion/comment/441362/#Comment_441362
2023-08-19 04:51:04 -04:00
Dan Stillman
3eef4284d1 Fix "Filename" tab title option
https://forums.zotero.org/discussion/comment/441259/#Comment_441259
2023-08-19 04:00:49 -04:00
Martynas Bagdonas
b05ef8ed04 Properly focus reader iframe when opening a new reader instance 2023-08-18 18:33:52 +02:00
Abe Jellinek
17daf9fe8d Fix EPUB attachments with wrong MIME type on view
Fixes #3320
2023-08-15 17:54:37 -04:00
Abe Jellinek
7b26dab2f2 Show spread mode menu items in EPUB reader
Fixes #3318 (only odd spreads supported right now because of CSS grid
limitations)
2023-08-15 17:54:36 -04:00
Northword
dcca56d6c3
preferenceOptions.helpurl should be string instead string[] (#3310) 2023-08-11 07:13:58 -04:00
Dan Stillman
9dd182e9ca Collection tree selection fixes
Fixes various logic around what gets selected when collections and
searches are moved to or restored from the trash (which has never been
exposed) or when they're erased
2023-08-11 04:16:42 -04:00
Dan Stillman
c4eb9df716 Update utilities submodule 2023-08-09 18:09:03 -04:00
Dan Stillman
5e27a75010 Switch to better sentence-caser from zotero/utilities#26
Closes #293
2023-08-09 07:51:16 -04:00
Martynas Bagdonas
879109336a Rename pdf-reader paths to reader 2023-08-08 11:28:00 +03:00
Martynas Bagdonas
07e4d68760 Suppress noisy "dead object" error after each click inside reader tab 2023-08-07 16:07:56 -04:00
Dan Stillman
7e481e3e5f Move Language to the bottom of the General prefpane 2023-08-07 16:07:55 -04:00
Dan Stillman
38b9457ea9 Move new string to Fluent 2023-08-07 16:07:55 -04:00
Dan Stillman
caee5f29ca Update reader prefs
- Move open-in prefs into reader prefs
- Move reader prefs up below File Handling
- Move new strings to Fluent
- Fix clicking on labels to focus open-in drop-downs
- Tweak text
2023-08-07 16:07:55 -04:00
Abe Jellinek
deb6acaab1 Add preferences for ebook & snapshot file handling 2023-08-07 16:07:55 -04:00
Abe Jellinek
2ef560f7d8 Extract ISBNs and DOIs from EPUB content (#64)
And move EPUB functionality to class.
2023-08-07 16:07:55 -04:00
Abe Jellinek
cab0fa93e7 Extend Retrieve Metadata to support EPUBs (#57) 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
80da0fbb56 Remove the unnecessary buf to Uint8Array conversion 2023-08-07 16:07:55 -04:00
Abe Jellinek
b0b11cfcf5 Use data option to initialize reader 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
e031509966 Fix Reader 2.0 merge caused regressions 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
c62ed29de9 Fix text annotation dragging error 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
f18411c151 Properly trigger annotation position split if server says it's too long 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
12fde2dd4a Fix reader error handling and properly display critical errors 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
46d066394f Temporary fix for tab crashes caused by tab loading racing conditions 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
7e28973f3a Fix reader focusing 2023-08-07 16:07:54 -04:00
Abe Jellinek
b408b43394 Support pre-SingleFile snapshots 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
3c08604770 Fix PDF file printing 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
17deb16779 Add partial underline annotation support for note-editor
(changes to note-editor have to be merged to have full support)
2023-08-07 16:07:54 -04:00
Abe Jellinek
e199f35006 Fix _getColorIcon(), update stroke color, use for selected menuitems
- Need to set width/height for macOS native menu
- CSS named grays are too light to show well on the background, so use #555
- type="checkbox" menuitems don't show their icons, so use the icon stroke
  instead
2023-08-07 16:07:54 -04:00
Abe Jellinek
3443d065a3 Use native context menus on macOS 2023-08-07 16:07:53 -04:00
Abe Jellinek
1740e5f1aa Call uninit() in close()
This properly unregisters pref observers and flushes the reader's state.
2023-08-07 16:07:53 -04:00
Abe Jellinek
0ee54b4a7e Use IOUtils instead of OS.File 2023-08-07 16:07:53 -04:00
Abe Jellinek
bdb444371f Debounce writing EPUB/snapshot state to disk 2023-08-07 16:07:53 -04:00
Abe Jellinek
6a4715c324 Enable "Add Note from Annotations" for EPUBs and snapshots 2023-08-07 16:07:53 -04:00
Abe Jellinek
db6ff88ad1 Add full-text indexer for EPUBs 2023-08-07 16:07:53 -04:00
Martynas Bagdonas
e8c5c22d05 Fix pdf-worker CMaps and standard fonts paths 2023-08-07 16:07:53 -04:00
Martynas Bagdonas
7fa05bc463 Properly handle reader window closing 2023-08-07 16:07:53 -04:00
Martynas Bagdonas
9d2d655039 Avoid memory leaks caused by never removed event listeners 2023-08-07 16:07:53 -04:00
Abe Jellinek
7791779289 Fix unloaded tab context menu actions
Show in Library and Move to New Window.

Will fix zotero/zotero#2685
2023-08-07 16:07:53 -04:00
Abe Jellinek
a729297f6b Add menu items to switch EPUB flow modes (paginated/scrolled) 2023-08-07 16:07:52 -04:00
Abe Jellinek
61f21f48e8 Fix browser-custom-element.js event handler error
Send real mouse/pointer events so that the CE can call, e.g.,
preventClickEvent().
2023-08-07 16:07:52 -04:00
Abe Jellinek
ba1b1b0639 Add EPUB format to Zotero.MIME 2023-08-07 16:07:52 -04:00
Abe Jellinek
1d89360765 Persist snapshot scroll position 2023-08-07 16:07:52 -04:00
Abe Jellinek
60f8d11c2d Persist EPUB CFI with setAttachmentLastPageIndex() 2023-08-07 16:07:52 -04:00
Martynas Bagdonas
3105bb9ff3 Fix add to note 2023-08-07 16:07:52 -04:00