Commit graph

11891 commits

Author SHA1 Message Date
Dan Stillman
bacc5b4428 Preserve explicit annotation author name when copying from group 2022-02-08 23:57:49 -05:00
Abe Jellinek
9cf45c0a0b
Set default filename when exporting single note (#2339) 2022-02-08 23:28:53 -05:00
Dan Stillman
734057ff9b Require DB transaction in Zotero.Items.moveChildItems()
But make optional with deprecation warning for now, since it's used in
ZotFile
2022-02-08 06:38:48 -05:00
Dan Stillman
f684984b07 Copy annotations across libraries
Based on option in prefs

When copying an annotation group the
2022-02-08 06:38:32 -05:00
Dan Stillman
67451dffd5 Add annotationAuthorName property to annotation items
And pass both `authorName` and `lastCreatedByUser` to the PDF reader.
The former can either come from `createdByUser` or be set directly on
the item (for group annotations dragged to personal libraries).
2022-02-08 06:38:32 -05:00
Dan Stillman
60f9a0417f Remove isAuthor from JSON passed to PDF reader 2022-02-08 06:38:32 -05:00
Dan Stillman
bf9ef5fc01 Disable PDF annotation transfer in group libraries 2022-02-08 06:38:32 -05:00
Dan Stillman
cc0687a574 Fix selectLibrary() in CollectionTree if no libraryID passed 2022-02-08 06:38:32 -05:00
Adomas Venčkauskas
0d2cfef160 HTML Tree: fix errors being thrown on hover over empty cells
Regression in 54ad6da1
2022-02-08 10:00:36 +02:00
Martynas Bagdonas
b865ee8b65 Fix tagsBox issues in a separate note window:
- Invisible auto-suggested tags
- Oversized tag icon
2022-02-07 17:39:09 +02:00
Dan Stillman
697798b536 Bump version to 6.0 2022-02-05 03:17:51 -05:00
Dan Stillman
e4f5241058 Add missing quote in logged error 2022-02-05 03:17:51 -05:00
Adomas Venčkauskas
54ad6da1af HTML Tree: make tooltip setting code use any parent xul node 2022-02-04 14:19:20 +02:00
Dan Stillman
c78bf1b2a3 Fix feed item guid in logged warning when item exists in different feed 2022-02-04 02:18:38 -05:00
Abe Jellinek
e8b574da0b
Fix React icons only using 2x image once (#2324)
a1267bc fixed repeated re-appending of '@2x' by moving the modified URL
to a local variable, but it still set hasHiDPI to false permanently;
this meant that icons displayed repeatedly in the same window, like the
tab close button, would only use their 2x versions the first time they
were displayed (in the case of tabs, this is the library tab's invisible
close button, so *no* tabs got visible 2x buttons).

This commit moves the HiDPI check and URL modification out of the render
function and instead runs it a single time when i() is first called.
2022-02-04 00:38:01 -05:00
Adomas Venčkauskas
8de1ddcaf4 HTML Tree: Display a tooltip with full cell contents when truncated
Closes #2321

Also added tooltips for cells that use an icon in their contents
2022-02-03 16:09:40 +02:00
Abe Jellinek
4777f0ec89 Double-click/enter to edit feed
Closes #2323
2022-02-02 23:03:04 -08:00
Tom Najdek
90da2563c8
Decouple progress queue table from progress window (#2318)
* Tweaked ProgressQueue to accept multiple listeners per event.
  Removing listeners now requires specifying which one to remove.
* Decoupled progress queue table into new ProgressQueueTable component
2022-02-02 17:15:57 -05:00
Dan Stillman
1ea1a134ba Reset extensions.spellcheck.inline.max-misspellings
Closes #2108
2022-02-02 05:48:23 -05:00
Adomas Venčkauskas
060d2f1c37 Item tree: Add tooltips for header cells.
Restrict the html-tooltip [title] selector to not fall back to
window title when no title attributes are present.
2022-02-02 12:25:50 +02:00
Dan Stillman
15ae72d143 Update pdf-reader submodule 2022-02-02 04:38:47 -05:00
Dan Stillman
4e6b68477d PDF reader: Annotation name display changes
- Show creator's name in groups even when it's the current user
- Don't show name for external annotations
2022-02-02 03:54:34 -05:00
Dan Stillman
3902043669 Update locales from Transifex and merge new English strings 2022-02-02 02:22:34 -05:00
Dan Stillman
a6e0432848 PDF reader: Tweak annotation deletion confirmation text 2022-02-02 02:09:20 -05:00
Dan Stillman
82b1ce2027 Update pdf-reader and pdf-worker 2022-02-02 01:53:50 -05:00
Martynas Bagdonas
21ca1555c1 Focus tag input field if tagsBox doesn't have tags
Fixes #2315
2022-01-31 19:49:58 +02:00
Dan Stillman
cec1f18670 Fix nesting of resetUnsyncedLibraryFiles() test 2022-01-31 06:48:05 -05:00
Dan Stillman
637acbe693 Fix incorrect isEditable() test in Item::moveToLibrary() 2022-01-31 06:48:05 -05:00
Dan Stillman
df64a16b55 Disallow unowned group annotation edits, but allow deletions
Update `DataObject::isEditable()` to take an optional `op` argument to
test individual operations as opposed to general library editing.
Erasing objects now tests `erase`, and `Item::isEditable()` allows
`erase` for unowned group annotations while disallowing the default
`edit`.

It's still up to the reader to handle this appropriately in the UI and
not allow operations it shouldn't, but this enforces it in the data
layer.
2022-01-31 06:48:05 -05:00
Dan Stillman
9de86a3db8 Update pdf-reader submodule 2022-01-31 06:48:05 -05:00
Dan Stillman
5a0cd78f06 Enable PDF reader by default and enable for groups
"Zotero" is now the first and default option in the "Open PDFs using"
drop-down in the General pane of the preferences.
2022-01-31 06:48:05 -05:00
Martynas Bagdonas
f8d7eb8ed7 Prompt confirmation when deleting annotations in PDF reader 2022-01-28 17:32:41 +02:00
Dan Stillman
ae7bfe7f48 "Suppress Author" → "Omit Author"
Authors shall be suppressed no more.
2022-01-26 23:52:47 -05:00
Adomas Venčkauskas
d2aa945083 Select full item name upon entering edit mode in the collection tree
(Instead of placing the cursor at the end of the edit field)
Closes #2316
2022-01-26 15:10:59 +02:00
Dan Stillman
da8f4df8ca Update locales from Transifex and merge new English strings 2022-01-17 05:10:30 -05:00
Dan Stillman
fc1c7580ab Update pdf-reader submodule 2022-01-17 04:26:17 -05:00
Martynas Bagdonas
e46f210b6c
Add color and tag selector to annotations sidebar (#2299) 2022-01-17 04:20:35 -05:00
Martynas Bagdonas
f2e9efaf1d Don't show multiple separators in PDF reader annotation context menu 2022-01-04 19:11:38 +02:00
Dan Stillman
035aac30f2 Fix misplaced '?' in regexp from 52d5652540 2022-01-03 01:31:02 -05:00
Dan Stillman
52d5652540 Don't use Firefox UA for proxy-check S3 domain
https://forums.zotero.org/discussion/comment/396502/#Comment_396502
2022-01-03 01:22:49 -05:00
Dan Stillman
b1b9759864 Doc Prefs: Don't increase style list height at larger font sizes
https://forums.zotero.org/discussion/93655/is-there-a-fix-for-high-dpi-screens
2022-01-02 16:57:06 -05:00
Dan Stillman
ad02b70198 Update locales from Transifex and merge new English strings 2021-12-28 01:27:07 -05:00
Dan Stillman
4f8fccd598 PDF reader: Page label popup tweaks (#2267)
- Change text of context menu option
- Add header line above radio boxes
2021-12-28 01:19:48 -05:00
Martynas Bagdonas
2cd756b7ae PDF reader: Add page label update option to annotation popup (#2267) 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
3cb5340b26 PDF reader: Remove import bar artifacts 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
6913c179dc Optimize annotations batch modification and deletion 2021-12-28 01:19:48 -05:00
Dan Stillman
819dc7f6f4 Include "Zotero/[version]" in file sync requests
To avoid blocking by some institutional firewalls

https://forums.zotero.org/discussion/93510/general-sync-error
2021-12-27 15:54:12 -05:00
Dan Stillman
3dab64ddbb Fix error deleting some orphaned or invalid WebDAV files
If a .prop file was passed to `_deleteStorageFiles()`, it would throw
`deletePropURI.QueryInterface is not a function`.
2021-12-27 14:53:28 -05:00
Dan Stillman
d955a77e98 Update locales from Transifex and merge new English strings 2021-12-27 01:20:24 -05:00
Dan Stillman
71248b591d Better handling of export option for notes in items list context menu
- Show "Export Note…"/"Export Notes…" if only notes or attachments
  selected
- Don't show export option if only attachments and no embedded notes
  (was previously disabled, and still is if all notes or a mixture of
  empty notes and attachments)
2021-12-26 23:50:15 -05:00