mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
10246 commits 9 branches 364 tags 290 MiB
Commit graph

7007 commits

Author SHA1 Message Date
Tom Najdek
897e74c7f1 Reactify the Tag Selector 2019-01-07 15:33:45 +02:00
Dan Stillman
506ed313da Fix moving item via connector to library with files from one without 
Broken in ce5be0bc75 for non-webpage items
 2019-01-07 05:16:17 -05:00
Dan Stillman
5fa608e379 Deprecate DB.getNextName() in favor of Utilities.Internal.getNextName() 2018-12-27 07:12:26 -05:00
Dan Stillman
7575cd8b29 Don't accept keyboard input before new-collection prompt appears 
Fixes #1613
 2018-12-27 07:11:15 -05:00
Dan Stillman
4bc8fab4f5 Allow translators to specify that attachment URLs shouldn't be proxied 
Translators can include `proxy: false` in the attachment object to
indicate that the URL should be used as is, without further proxying.
This generally isn't necessary, but sometimes it is (e.g., on
EBSCOhost), and in theory we should start using this whenever a PDF URL
is extracted from the page instead of being constructed manually by the
translator.

Closes #1612
 2018-12-26 06:23:26 -05:00
Dan Stillman
b58def7bc4 Expose Zotero.Notes for translation-server/Node 
Needed for CSL JSON export of notes, which is pointless but better than
throwing an error, I guess.
 2018-12-21 02:40:18 -05:00
Dan Stillman
559881b896 Update submodules 2018-12-18 21:17:48 -05:00
Dan Stillman
7594fe1800 Fix advanced search test failure after 13d55910e 2018-12-17 05:36:14 -05:00
Dan Stillman
bd5243221b Fix another typo in c81961a9be 2018-12-16 22:41:32 -05:00
Dan Stillman
adcae4b902 Fix typo in previous commit (c81961a9be) 2018-12-16 21:36:59 -05:00
Dan Stillman
c81961a9be Move Z.Items.getFirstCreatorFromItemJSON() to Z.Utilities.Internal 
Needed for COinS export in translation-server
 2018-12-16 21:26:16 -05:00
Dan Stillman
f4bf918f35 Remove ": a novel" from book titles 
Closes #1581
 2018-12-16 03:00:15 -05:00
Dan Stillman
6125d65bc2 Support duplicating saved searches 
Closes #1431
 2018-12-16 02:24:21 -05:00
Dan Stillman
c73e664312 Fix logged error when dragging collection to another library 
"Collection ID '1234' is not an integer (string)"
 2018-12-16 02:24:21 -05:00
Dan Stillman
13d55910ed Simplify cloning of collections and searches 2018-12-16 02:24:21 -05:00
Dan Stillman
5f07f36ae5 Allow Zotero.Item instance instead of itemID in Collection.hasItem() 2018-12-16 02:24:21 -05:00
Dan Stillman
80f6b857f6 Add Utilities.Internal.getNextName(name, existingNames) 
Function to get the next available name when duplicating something
 2018-12-16 02:24:21 -05:00
Dan Stillman
bf6f1432c5 Move Utilities.Internal.escapeSQLExpression() to Zotero.DB 2018-12-16 02:10:15 -05:00
Dan Stillman
28aa86eb79 Default to previous condition when creating new advanced search row 
Fixes #1533
 2018-12-15 23:52:57 -05:00
Dan Stillman
1c47d21937 Expose Zotero.Cite for translation-server/Node 2018-12-13 02:06:10 -05:00
Adomas Venčkauskas
ffbe44a159 Fix snapshot saves refetching page instead of using passed html 2018-12-12 10:59:58 +02:00
Dan Stillman
9ed8bed778 Find direct PDF from page URL if Content-Type includes invalid parameter 
The 'application/pdf' Content-Type shouldn't have any parameters, but a
site was returning 'application/pdf;charset=ISO-8859-1', so instead just
look for the 'application/pdf' prefix.
 2018-12-11 16:02:57 -05:00
Dan Stillman
0706430609 Add setRequestHeaders() method to Translate.Web 
For use in zotero/translation-server#16 to pass Accept-Language through
to translation web requests
 2018-12-04 02:50:40 -07:00
Dan Stillman
a6fb0b35c3 Update processDocuments() signature for allow passing headers 
Also:

- Actually use the cookie sandbox passed to processDocuments()

For zotero/translation-server#16, we want to include Accept-Language
(and maybe other headers) from the client request in upstream requests,
which requires passing it to both non-translate processDocuments().
translation-server's non-translate processDocuments() is defined in that
repo, but it's called by the cross-repo translate processDocuments() in
utilities_translate.js, so the signature needs to be changed in both
repos.

We also apparently weren't using the cookieSandbox in client
processDocuments() calls, though I think that only would've affected
translator testing.
 2018-12-04 01:42:56 -07:00
Dan Stillman
223f582aa7 Fix search error on nonexistent collection in recursive mode 
And don't return results for a nonexistent parent search
 2018-11-28 15:31:57 -07:00
Dan Stillman
6137aeddb8 Follow meta redirects for Find Available PDF 
This fixes direct and VPN-based retrieval of PDFs for Elsevier (e.g.,
ScienceDirect) items that have a DOI but no URL, since Elsevier resolves
DOIs through an intermediate page.
 2018-11-26 00:57:48 -07:00
Dan Stillman
7d9b94c79e Fix autocomplete for tags beginning with _ or % 
Addresses #1598
 2018-11-25 00:36:04 -07:00
Adomas Venčkauskas
b1e3195b5a Adds translatorTester nodejs compatibility code that doesn't break Scaffold 2018-11-13 13:25:01 +02:00
Dan Stillman
b80c405da4 Revert "Changes for translator tester compatibility with translation server" 
This reverts commit e526a8fa89.

This is a repeat of a0ca67d879. The reverted changes break Scaffold.
This will need to be fixed in a way that allows Scaffold to continue to
work.
 2018-11-12 00:40:30 -05:00
Adomas Venčkauskas
51d7959ccd Revert "Ensure the doc prefs window is smaller than screen height" 
This reverts commit 0fd28959bf.
The change causes citation style listbox to fail displaying bottom
entries, a flexed listbox xul bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=413336
 2018-11-05 15:14:38 +02:00
Adomas Venčkauskas
0bdebbd64c Revert "Remove old style conversion code" 
We got multiple requests from users that use custom 0.8 styles
so we'll have to keep this code for now

This reverts commit a59ce2c343.
 2018-10-31 14:01:11 +02:00
Adomas Venčkauskas
e526a8fa89 Changes for translator tester compatibility with translation server 2018-10-31 11:32:33 +02:00
Philipp Zumstein
8fdccb828f Fix comment in ItemProgress.prototype.setIcon (#1591) 2018-10-27 03:26:16 -04:00
Adomas Venčkauskas
8d61e30a93 Update translatorTester for use in translation server 2018-10-26 16:30:08 +03:00
Dan Stillman
91bac0e052 Add 2x icons for attachment-snapshot and conferencePaper 2018-10-26 00:54:40 -04:00
Dan Stillman
6abfd3b5b0 Fix 'req is undefined' error after consecutive S3 failures 2018-10-22 05:30:20 -04:00
Dan Stillman
053599993b Add successCodes argument to translator doGet/doPost 
In 2652fac24 we started failing the translator if doGet/doPost returned
a >=400 status code, but at least one translator (Primo) relied on doGet
continuing after a 404. This allows translators to specify the status
codes that are allowed, similar to the same argument in
Zotero.HTTP.request().

(We'll clean up the signature at some point or just get rid of these
functions, but this is a quick fix for Primo.)
 2018-10-21 06:01:06 -04:00
Dan Stillman
a0ca67d879 Revert part of 5b3b1f0f1 to fix Scaffold breakage 
I didn't look into the details, but `this` isn't defined when this file
is loaded within Scaffold, so this line caused an error and the
translator tester was broken.
 2018-10-21 05:37:03 -04:00
Dan Stillman
28e1d7dfb6 Update submodules 2018-10-21 02:17:57 -04:00
Dan Stillman
c7915e5bc2 Don't add four spaces when tabbing to indent list in note 
Fixes #1236
 2018-10-20 03:39:26 -04:00
Adomas Venčkauskas
206b4d7005 Catch translation select callback errors 2018-10-19 14:59:16 +03:00
Adomas Venčkauskas
5b3b1f0f1b Update translatorTester for translation server support 2018-10-19 13:47:44 +03:00
Adomas Venčkauskas
9d98f765b2 Point doc help to general word processor help page. Closes #1585 2018-10-18 13:34:26 +03:00
Dan Stillman
fc1f737986 Throw proper error for "key must be an 8-character string" error 2018-10-18 04:35:18 -04:00
Dan Stillman
4aaec5f091 Fix note being read-only after viewing note in trash 2018-10-14 23:35:05 -04:00
Adomas Venčkauskas
f7e9067660 Fix imports with missing attachments not closing progress window. Closes #1583 2018-10-12 13:48:20 +03:00
Dan Stillman
1e3608e82e Add zotero://select support for collections 
zotero://select/(library|groups/:groupID)/collections/:collectionKey
 2018-10-10 21:38:10 -04:00
Dan Stillman
2d38a0102c Show "Find Available PDFs" even if non-regular items are selected 2018-10-10 21:38:10 -04:00
Dan Stillman
33a7cc57ea Fix popup when no items are eligible for "Find Available PDFs" 2018-10-10 21:38:10 -04:00
Adomas Venčkauskas
1beab1d3a7 Don't attempt to fetch daySuffixes in Connector/Bookmarklet 2018-10-10 14:25:24 +03:00
Dan Stillman
bd5fca3c23 Skip empty tags from connector 2018-10-10 06:03:41 -04:00
Adomas Venčkauskas
c65ca34afe Permit /connector/delaySync for the bookmarklet 2018-10-10 12:41:16 +03:00
Dan Stillman
ab27dd154e Fix status indicator for successful PDF retrieval in progress window 2018-10-09 18:24:53 -04:00
Dan Stillman
f6448c5de4 Update locales from Transifex 2018-10-09 17:51:05 -04:00
Dan Stillman
be8db4fc50 Don't show progress window for PDF recognition if only one file 2018-10-08 02:46:13 -04:00
Dan Stillman
1b9811c31d Fix test failures after 18f79f9796 2018-10-06 01:38:32 -04:00
Dan Stillman
18f79f9796 Use progress dialog for PDF retrieval 2018-10-06 00:22:57 -04:00
Dan Stillman
a2f13c9043 Allow setting custom status line and hiding Minimize in progress dialog 2018-10-06 00:16:15 -04:00
Dan Stillman
4a6501c198 Update comments for PDF retrieval functions 2018-10-05 01:57:13 -04:00
Martynas Bagdonas
ae7ef109b7 Add universal progress queues (#1573) 2018-10-05 01:56:46 -04:00
Adomas Ven
b6065a7af6 Changes for bookmarklet update to current codebase (#1579) 2018-10-04 04:16:31 -04:00
Martynas Bagdonas
ec5424d5ae Follow meta redirects and use the final URL when processing documents (#1568) 2018-10-03 22:24:39 -04:00
Adomas Venčkauskas
a59ce2c343 Remove old style conversion code 2018-10-03 15:48:27 +03:00
Dan Stillman
e57e297156 Update submodules 2018-09-26 19:00:05 -04:00
Dan Stillman
3a8fd4d942 Fix additional translatorCache problems at startup 2018-09-25 06:24:17 -04:00
Dan Stillman
d899134e7c Automatically delay between PDF retrieval requests to the same domain 
Delay requests to the same domain by 1 second, respect a Retry-After
header if present for 429 and 503, and delay for 10 seconds on 429 or
5xx otherwise.
 2018-09-22 04:03:25 -04:00
Dan Stillman
536c07e9f4 Pass URL to Zotero.HTTP.UnexpectedStatusException 
This allows the URL to be retrieved at .url in the thrown error.
 2018-09-22 04:03:25 -04:00
Dan Stillman
b25d2d9c56 Update Zotero.HTTP.request() documentation 2018-09-22 04:03:25 -04:00
Dan Stillman
b782120840 Add followRedirects: false option to Zotero.HTTP.request() 
Currently only .status and .getResponseHeader() (for getting 'Location')
are available in the returned object, but we could make the body
available if necessary.
 2018-09-22 04:03:25 -04:00
Dan Stillman
b8db83af08 Split out a couple helper functions for PDF retrieval 2018-09-21 21:12:15 -04:00
Dan Stillman
c6a2af7ab5 Use 'load' instead of 'pageshow' in Zotero.HTTP.loadDocuments() 
This seems to fix snapshots in Twitter, which need to wait for a
JS-based self-redirect [1].

[1] https://blog.twitter.com/engineering/en_us/topics/insights/2018/twitter_silhouette.html
 2018-09-21 21:12:15 -04:00
Philipp Zumstein
2957db2aa1 Delete two duplicate switch cases (#1569) 2018-09-14 17:01:47 -04:00
Dan Stillman
f4ac511b50 Copy items across libraries in batches of 100 
This will hopefully fix failures when copying huge numbers of items.
 2018-09-14 04:14:08 -04:00
Adomas Venčkauskas
0cb683ab18 Ensure we don't maintain document sessions across different doc processors 2018-09-10 08:40:48 +03:00
Maecenas Li
dd9ee66212 Add support for marginnoteapp:// URI protocol (#1567) 
https://forums.zotero.org/discussion/comment/316070/#Comment_316070
 2018-09-08 06:01:02 -04:00
Dan Stillman
d8b2d24524 Better fix for invalid file localUrl in Mendeley DB 2018-09-07 01:22:09 -04:00
Dan Stillman
3f2ee35d59 Tweak debug line 2018-09-06 17:22:03 -04:00
Dan Stillman
7cf466a0b6 Save OA PDFs when the DOI resolves directly to the file 2018-09-06 16:44:11 -04:00
Dan Stillman
18821984e0 Accept a Blob as input in Zotero.File.putContentsAsync() 2018-09-06 16:44:11 -04:00
Dan Stillman
36afb34cf6 Show warning if Zotero is started from Mac disk image 
Doing so can cause the Word for Mac extension not to load, and possibly
other problems.

https://forums.zotero.org/discussion/73470/word-could-not-communicate-with-zotero-with-three-full-uninstalls-and-reinstalls
 2018-09-06 00:53:50 -04:00
Dan Stillman
4b64cc312c Handle possible null file URL in Mendeley import 2018-09-05 14:41:13 -04:00
Dan Stillman
03a15d47af Remove redundant OA PDF search in Add Item by Identifier 2018-09-04 14:15:25 -04:00
Adomas Venčkauskas
66ed33b9fb Fix must insert citation prompt in new doc with copied fields. Closes #1564 2018-09-04 16:37:46 +03:00
Dan Stillman
05d8e7a8a3 Check Extra field for DOIs for PDF retrieval 
E.g., a book with a DOI in Extra

Closes #1551
 2018-08-30 16:52:24 -04:00
Adomas Venčkauskas
944188fa63 Fix RTF dontUpdate=true citations updating on LO. Closes #1561 2018-08-30 10:55:54 +03:00
Dan Stillman
5a008cf861 Don't save collections from Scaffold 
Fixes zotero/scaffold#60
 2018-08-27 17:45:42 -04:00
Dan Stillman
4eb4490723 Don't limit PDF retrieval to dev builds 2018-08-25 17:00:53 -04:00
Dan Stillman
862ac5ab40 Handle missing 'attachments' array in /connector/saveItems 2018-08-25 16:55:13 -04:00
Dan Stillman
e7e681c113 Set retrieved OA PDF title to reflect version 
"Full Text", "Accepted Version", or "Submitted Version"
 2018-08-25 16:48:17 -04:00
Dan Stillman
abc4cd9dfe Clear translatorCache table when resetting translators 2018-08-21 22:36:20 -04:00
Dan Stillman
91a3c27235 Fail schemaUpdatePromise and show alert on initialization failure 
This will also cause the word processor plugin to throw an error isntead
of hanging if there was a problem loading translators or styles.

Closes #1557
 2018-08-21 22:36:20 -04:00
Dan Stillman
475bd17b71 Fix 'title is null' error 
Not sure why item.title would ever be null, but this was in a user's
error report and seemed to be causing a restart error.
 2018-08-21 22:36:20 -04:00
Adomas Venčkauskas
0fd28959bf Ensure the doc prefs window is smaller than screen height 
Dynamically resizes the style picker up to the window height of 700px
 2018-08-20 12:42:45 +03:00
Dan Stillman
8d5338db2d Additional debug output for setting base directory 2018-08-19 22:49:09 -04:00
Dan Stillman
4f98ad9567 Vacuum database automatically after clearing full-text index 2018-08-19 04:06:04 -04:00
Dan Stillman
926e2f7317 Reduce memory consumption of full-text index clear 2018-08-19 04:05:38 -04:00
Dan Stillman
18021d1aeb Disable rebuild/clear buttons in Search prefs while in progress 2018-08-19 03:51:00 -04:00
Dan Stillman
c9e80319bb Support "Show File" on evicted iCloud Drive files 2018-08-19 02:41:45 -04:00
Dan Stillman
ec76575645 Trigger downloading and opening of evicted iCloud Drive files 2018-08-19 01:44:49 -04:00
Dan Stillman
e48a1a2abb Remove lots of old Zotero for Firefox code 
We still run tests in Firefox, so not everything can be removed.
 2018-08-17 03:17:08 -04:00