Commit graph

9073 commits

Author SHA1 Message Date
Dan Stillman
96e2510165 Fix missing return in previous commit 2023-07-20 06:42:32 -04:00
Dan Stillman
590460cea4 Add Zotero.Prefs.prefHasUserValue(pref, global) 2023-07-20 06:41:23 -04:00
Dan Stillman
51c70eb925 Use system temp directory by default
Might help for something like
https://forums.zotero.org/discussion/106337/zotero-7-sync-error
2023-07-20 05:43:39 -04:00
Adomas Venčkauskas
75c46e1e5c Enable FAYT in document preferences. Closes #3214 2023-07-20 11:10:14 +03:00
Adomas Venčkauskas
1b30c8b2b5 Add a comment for bib style caching. Closes #3211 2023-07-18 10:58:12 +03:00
Adomas Venčkauskas
f61826281b Revert "Merge pull request #3195 from CommonLoon102/cl102/fix-bib-indent"
This reverts commit aca86967bf, reversing
changes made to 1a850d58c4.
2023-07-18 10:55:14 +03:00
abaevbog
9599d1712c
disable file > close for library if 1+ tabs open (#3210)
When there are multiple tabs opened, menuitem File > Close is disabled for the library tab.

Fixes: #3198
2023-07-18 03:40:19 -04:00
Martynas Bagdonas
e37eaac8d1 Fix panes overflowing in stacked view mode
Fixes #3180
2023-07-17 17:07:38 +03:00
Dan Stillman
c425f71ac4 fx-compat: Fix error passing cookieSandbox to Zotero.HTTP.request()
https://groups.google.com/g/zotero-dev/c/UgP_kZvrEjA/m/KjimYREGAgAJ

getInterface() seems to exist on XHR and nsIWBP without QIing to
nsIInterfaceRequestor, and XHR no longer has QueryInterface().
2023-07-17 06:42:14 -04:00
Dan Stillman
65fe50d11f Clear startup cache when uninstalling/upgrading plugins
https://groups.google.com/g/zotero-dev/c/0nfU-F2q1uI/m/1jBVmMZxBAAJ

Removed by Mozilla in
https://bugzilla.mozilla.org/show_bug.cgi?id=1445739, since
WebExtensions don't put anything in the startup cache
2023-07-15 18:39:59 -04:00
Dan Stillman
838152155e Log warning when not setting createdByUser/lastModifiedByUser
(I encountered this in a test when trying to set createdByUserID without
`Zotero.Users.setName()`.)
2023-07-14 05:48:48 -04:00
Dan Stillman
dc321ce643 Fix startup error on Windows
Regression from 8d3f874e64, which included this unfinished code by mistake.

Fixes #3196
2023-07-14 05:48:48 -04:00
abaevbog
0cd94555d5
prevent incorrect jumpback (#3204)
Fixes: #3152
2023-07-14 05:29:43 -04:00
Dan Stillman
d7449b4d78 Fix merging of group attachments with annotations created by another user
https://forums.zotero.org/discussion/106197/merge-in-group-library-fails-despite-having-edit-permissions
2023-07-13 19:58:47 -04:00
Adomas Venčkauskas
e5d25f3d66 Fix /connector/saveSnapshot still not including info about snapshots 2023-07-12 10:21:46 +03:00
Abe Jellinek
2aa34a6346 Merge: Remove spacing from annotation regex, delete external annotation items
- `/Subtype` isn't necessarily preceded or followed by a space
- Annotation items with `isExternal: true` are for display only and should be
  deleted on merge

https://forums.zotero.org/discussion/105960/external-annotations-ignored-when-merging
2023-07-11 11:12:58 -04:00
Adomas Venčkauskas
a0cdf11096 Fix failing test from 02ba9ca7 2023-07-11 15:57:35 +03:00
Adomas Venčkauskas
02ba9ca7f0 Include information about saved snapshots in /saveSnapshot 2023-07-11 15:45:51 +03:00
Martynas Bagdonas
5928147f26 Fix middle-click selecting tab that is being closed 2023-07-11 14:02:12 +03:00
Dan Stillman
8d3f874e64 Remove all uses of Zotero.isStandalone
(View diff with -w)
2023-07-11 05:35:32 -04:00
Dan Stillman
b98efe0b67 Remove ZoteroPane.updateTagsBoxSize()
Disabled several years ago in bb5075e8b8
2023-07-11 05:35:32 -04:00
Dan Stillman
071162f914 Remove styled-textbox XBL binding 2023-07-11 05:35:32 -04:00
Dan Stillman
af892e5cbd Make annotation sortIndex more flexible 2023-07-11 05:35:32 -04:00
Abe Jellinek
b6d0ad3e05 Accept non-integer attachmentLastPageIndex 2023-07-11 05:35:32 -04:00
Martynas Bagdonas
89adf56eed Add support for text annotations 2023-07-11 05:35:32 -04:00
Martynas Bagdonas
cb14034c46 Add support for underline annotations 2023-07-11 05:35:32 -04:00
Dan Stillman
81ec8287f8 Disable attachmentContentType check to prevent sync errors 2023-07-11 05:35:32 -04:00
Dan Stillman
4a8935eefd Guidance panel fixes
- Fix missing styling in Quick Format dialog
- Fix Book Section panel being immediately hidden
- Remove low-res Zotero icon
- Increase font size and tweak padding
2023-07-11 05:35:32 -04:00
Dan Stillman
fb3466b392 Fix Ctrl-Q on Linux
Fixes #3199
2023-07-06 19:21:52 -04:00
windingwind
a2e8be2af5
Fix extremely slow binary to base64 (#3201) 2023-07-06 01:56:38 -04:00
Martynas Bagdonas
8017b2ab1b Fix extremely slow note editor image ArrayBuffer to data URL conversion 2023-07-05 19:41:32 +03:00
abaevbog
04496fadcd
only save username to prefs on successful login (#3192)
Failing to login does not update the username in prefs.

Fixes #2901
2023-07-05 04:11:56 -04:00
abaevbog
13571f9fd2
making toolbar accessible to the keyboard - initial conversion (#3188)
Port of d866a10a2b

Fixes #3001
2023-07-05 03:17:07 -04:00
Adomas Ven
aca86967bf
Merge pull request #3195 from CommonLoon102/cl102/fix-bib-indent
Fix indentation in bibliography
2023-07-03 15:19:01 +03:00
Adomas Venčkauskas
1a850d58c4 Fix the column picker not working outside of zotero pane. Closes #3162 2023-07-03 14:54:50 +03:00
CommonLoon102
b60fb28313
Fix indentation in bibliography
Fix indentation in bibliography when a new item is added and therefore the recalculation of indents are needed.

https://forums.zotero.org/discussion/23689/bibliography-indentation
2023-07-01 13:15:44 +02:00
Dan Stillman
1766f8bb53 Plugin lifecycle fixes
- Call `shutdown()`/`uninstall()` with `ADDON_UPGRADE`/`ADDON_DOWNGRADE`
  during plugin upgrade/downgrade
- Actually call new version's bootstrap.js, not cached old version
- Create new scope for new version
- Don't call `shutdown()` on uninstall if not active

Fixes #3159
2023-07-01 06:19:04 -04:00
Martynas Bagdonas
fcb30b5e5d Fix not working context menu options to create note from annotations 2023-06-30 10:54:52 +03:00
Adomas Venčkauskas
1274f5f602 Fix citation reordering by dragging in the citation dialog. Closes #3183 2023-06-28 13:36:38 +03:00
Martynas Bagdonas
abfe96fcaa Temporary fix for context-pane item deck selection when closing a tab
Fixes #3175
Related to bb85e11a
2023-06-27 18:34:15 +03:00
Abe Jellinek
65048fd624 Scaffold: Automatically load last opened translator 2023-06-24 15:00:57 -07:00
Abe Jellinek
9b6d6c109c RemoteTranslate: Support cross-origin XMLHttpRequest
By creating our Sandbox under the system principal and giving it privileged XHR.
Bonus: no more `wrappedJSObject` required because sandbox code and actor code
are at the same privilege level now.

Fixes #3176
2023-06-23 22:19:46 -07:00
Dan Stillman
3454c321e7 Fix sw_vers call on older macOS versions
Apparently it didn't used to allow two hyphens before flags
2023-06-23 02:01:27 -04:00
Dan Stillman
f8d8fb5e11 Fix item-type-menu breakage after canceling item-type change on Windows
https://forums.zotero.org/discussion/105739/zotero-7-beta-bug-changing-item-type
2023-06-22 14:18:23 -04:00
Dan Stillman
4b581ad07b Don't call plugin startup() on upgrade if disabled
Fixes #3177

https://forums.zotero.org/discussion/105692/z7-beta-disabled-add-on-suddenly-active
2023-06-22 05:05:05 -04:00
Dan Stillman
f62cef9c12 Remove DOMLocalization from plugin sandbox
That can just be retrieved directly from document.l10n on the
appropriate window, and Mozilla doesn't use it directly.
2023-06-18 16:55:30 -04:00
Dan Stillman
c7304b9fb0 Fix plugin localization handling
Pass Localization and DOMLocalization to plugins and fix locale
registration so that it occurs before startup() is called.
2023-06-18 16:50:04 -04:00
Abe Jellinek
0a94e8fdf0
fx-compat: Make color picker CE accessible via keyboard and VoiceOver (#2933) 2023-06-17 02:43:24 -04:00
Abe Jellinek
c37e327330 Fix clicky sizing and appearance
- Set min-width and min-height to width and height so buttons never shrink
- Remove defunct .zotero-clicky-* styles from 2x block in zotero.css
- Include zotero-platform/content/zotero.css in searchDialog.xhtml
   - It seems only the defunct 2x styles from zotero.css were being applied, so
     the buttons would have been unstyled on a non-hiDPI display
2023-06-17 02:33:59 -04:00
Abe Jellinek
1a2950ae34 Automatically adjust height of multiline/long fields in edit mode
Fixes #3170
2023-06-16 12:17:29 -07:00