Commit graph

6882 commits

Author SHA1 Message Date
Simon Kornblith
181d852b72 Merge pull request #665 from zotero/unit-testing
Unit testing infrastructure
2015-03-09 19:13:25 -04:00
Dan Stillman
0aaa0540d9 Delete syncedSettings for deleted libraries on sync error
Not sure how this is possible, but fix it for now. It'll be prevented with a FK
check in 5.0.
2015-03-09 19:11:36 -04:00
Dan Stillman
cd358977f3 Update locales from Transifex
(Unfortunately this wipes out "Shortcuts" in all locales, but pushing
non-English locales to Transifex scares me too much. Sorry, localizers!
I think Transifex makes it easy to use previously used translations, at
least.)
2015-03-09 18:58:01 -04:00
Dan Stillman
2681a508b4 Merge pull request #664 from gracile-fr/prefs-pane
Move shortcut keys prefpane to tab of Advanced (#646)
2015-03-09 18:54:39 -04:00
Simon Kornblith
8253b98134 Remove index.js and just enumerate the files in the test directory 2015-03-09 17:41:49 -04:00
Simon Kornblith
4c45685331 Add header to EventUtils.jsm 2015-03-09 17:40:58 -04:00
Simon Kornblith
4a4073652f updateBundledFiles before using translators and wait for completion 2015-03-09 17:17:53 -04:00
Simon Kornblith
c2d32c2e27 Just give up on trying to automate the panel itself 2015-03-09 16:49:50 -04:00
Simon Kornblith
c7c58f8343 Add support function to reset the DB and a test that it works. 2015-03-09 14:25:49 -04:00
gracile-fr
0a4fcc90ac Move shortcut keys prefpane to tab of Advanced
[and delete unused "#zotero-prefpane-keys checkbox" (there used to be a checkbox to "Try to override conflicting shortcuts", which has been definely removed by 5b34dce40f )]
2015-03-09 12:08:31 +01:00
gracile-fr
1ac54c4b13 Move "#styleManager-updated" under "Cite Pane" code
It was lost under "Shortcut Keys pane" code.
2015-03-09 12:06:55 +01:00
Dan Stillman
3194f4629f Fix size of separate Z toolbar icon on Windows and Linux
Fixes #667
2015-03-09 03:37:40 -04:00
Simon Kornblith
b6673511f7 Close recognizePDF windows when tests finish 2015-03-08 19:28:33 -04:00
Simon Kornblith
299009dcd5 Add unit tests for add item by identifier and some support refactoring
Also adds EventUtils from MozMill to simplify UI automation.
2015-03-08 19:28:27 -04:00
Simon Kornblith
218917f367 Add unit test for PDF recognition without DOI 2015-03-08 16:20:57 -04:00
Simon Kornblith
3f0f7af71a Add unit test for PDF recognition with DOI
Also some support code that was useful here and will probably be
useful for other tests. This is a pretty complicated thing to test, but
it seems to work.
2015-03-08 16:02:10 -04:00
Dan Stillman
98263fb485 Fix padding of single save button in palette
(At least on OS X. This might need to be added back for Windows/Linux.)
2015-03-08 01:43:12 -07:00
Dan Stillman
806259d187 When dropping combo buttons into panel, add two separate buttons instead
And move combo button to customization palette
2015-03-08 00:13:19 -07:00
Dan Stillman
6b8cc59bea Merge pull request #661 from zuphilip/stop-propagation
Add stopPropagation to menuitem of new icon
2015-03-08 00:13:05 -07:00
Simon Kornblith
50cd396918 Make debugging tests a bit easier
- Add command-line argument to enable debug logging
- Add command-line argument to open (and leave open) jsconsole
- Try to print error stack traces (although Mocha doesn't seem to like
  them?)
2015-03-07 22:17:44 -05:00
Simon Kornblith
1c32db68da Unit testing infrastructure
Implements the beginnings of unit testing infrastructure using
mocha/chai. The unit tests can be run locally using test/runtests.sh,
although this will need tweaks to run on Windows. They should also run
on commit using Travis-CI.

The unit tests themselves live in test/tests. The index.js file
specifies separate test sets, which can be run individually by calling
test/runtests.sh <testsets>. Right now there is only a single unit
test, but hopefully we'll have more soon...
2015-03-07 16:34:55 -05:00
Philipp Zumstein
e9e9527e60 Add stopPropagation to menuitem of new icon
This should solve 658
2015-03-03 00:00:36 +01:00
Dan Stillman
5285fadded Merge pull request #655 from aurimasv/csl-json-export
Regression from f0bd1e77ff
2015-02-28 18:20:55 -08:00
Aurimas Vinckevicius
efa269d382 Regression from f0bd1e77ff
Re https://forums.zotero.org/discussion/47176/beta-item-fields-mapping-to-weird-csl-variables/
2015-02-28 15:57:27 -06:00
Dan Stillman
126d55b3c3 Remove extra overlay.css import
(Though possibly we just want to merge zotero.css and overlay.css, since
the distinction has been mostly lost.)
2015-02-27 03:39:35 -05:00
Dan Stillman
a1bed8b5ad More icon tweaks
- New dedicated Zotero button, available in the Customize palette
- Remove "16px" Z SVG and just render "32px" one at the smaller size
  (there's a slight difference at the edges, but we should probably redo
  it anyway so that dark lines reach all the way to the bottom)
- Change "Open Zotero" back to just "Zotero", since 1) it's for closing
  too, 2) it can also just bring Standalone to the front, and 3) "Open
  Zotero" looks weird and inconsistent in the menu panel next to things
  like "Preferences"
- For now, show single large Z for combo buttons in customization
  palette with "Zotero (Combo)", though we can probably do something
  better.
- Fix some HiDPI bugs when moving items between areas

Still need a layout for the panel for the combo buttons
2015-02-27 03:35:18 -05:00
Dan Stillman
20a3f97bde Merge pull request #654 from sualk/4.0
Restore settings (tag colors) to server
2015-02-26 16:02:36 -05:00
Klaus Flittner
1990240733 Restore settings to server
If the local data is to be resotres to the zotero server,
the settings like tag colors also need to be synced again.
2015-02-26 21:57:16 +01:00
Dan Stillman
94b2865149 Fix sorting of tag autocomplete in advanced search 2015-02-25 23:58:54 -05:00
Dan Stillman
9259bfd49a Merge pull request #626 from aurimasv/isbn-import
Tweaks to ISBN handling
2015-02-24 23:45:42 -05:00
Aurimas Vinckevicius
3918adf21a Hyphenate ISBN when writing to DB
Only hyphenate if we're very confident that it's a list of unhyphenated ISBNs
2015-02-24 22:42:41 -06:00
Aurimas Vinckevicius
68e7849fcf Add Zotero.Utilities.Internal.hyphenateISBN
Hyphenates ISBN-10 or ISBN-13 according to data from https://www.isbn-international.org
2015-02-24 22:42:29 -06:00
Aurimas Vinckevicius
37921b0910 Add dontValidate parameter to ZU.cleanISBN
Don't validate check digit
2015-02-24 22:40:40 -06:00
Aurimas Vinckevicius
c809dfcbc4 Use only the first ISBN for CSL JSON 2015-02-24 22:40:40 -06:00
Aurimas Vinckevicius
f0bd1e77ff Use Zotero.Utilities.itemToCSLJSON when sending items to citeproc 2015-02-24 22:40:39 -06:00
Aurimas Vinckevicius
7f52e00341 Cleanup ISBNs when importing from web/search translators
Validate, convert to ISBN-13, and list in a space-separated format
2015-02-24 22:40:39 -06:00
Dan Stillman
395d596105 Don't try to add child items to collections dragging cross-library
Previously, if you dragged a standalone attachment to a collection in another
library where the item already existed as a child item, it would crash Zotero
on a collection-item constraint.
2015-02-24 15:54:34 -05:00
Dan Stillman
0ab38f1d43 Add borders to collapsed collections/items splitters
We can think about making them more wider, etc., but this makes them ever so
slightly more visible.
2015-02-23 19:48:28 -05:00
Dan Stillman
b80d4cd369 Update locales from Transifex 2015-02-23 03:43:35 -05:00
Dan Stillman
a61157f8e3 Change "Zotero" button tooltip to "Open Zotero" 2015-02-23 03:33:34 -05:00
Dan Stillman
8371749bd1 Add Zotero.clientName, set to "Zotero" by default
We should eventually replace all hard-coded uses of "Zotero" with this
for use by unofficial versions (which legally can't be called "Zotero").
2015-02-23 03:31:52 -05:00
Dan Stillman
003db7c894 Toolbar icon tweaks on OS X 2015-02-23 02:38:48 -05:00
Dan Stillman
46bed210a1 Toolbar icon tweaks on Windows 2015-02-22 19:30:16 -05:00
Dan Stillman
0f402295be Toolbar icon tweaks on Linux 2015-02-22 18:56:39 -05:00
Dan Stillman
00d9bd41b3 Fix HiDPI save icon on Linux, maybe 2015-02-22 14:11:54 -05:00
Dan Stillman
7607e49ae7 Don't color gray webpage on hover 2015-02-22 06:46:07 -05:00
Dan Stillman
1abee72233 Fix toolbar buttons on Windows
Known issues:

- Hover doesn't work on the dropmarker alone, so instead of showing the
  hover effect for each segment individually, the menu-button parts are
  highlighted together, which at least looks like a choice
- When the menu-button is disabled, it still has some hover/active
  effects.
- Tested only on Windows 7
2015-02-22 06:46:07 -05:00
Dan Stillman
a85a9a632e Decrease right-padding of middle button by 1px on OS X 2015-02-22 06:46:07 -05:00
Dan Stillman
1069b483cc Fix toolbar buttons on Linux
Known issues:

- The dropmarker segment doesn't get a background highlight color on
  hover. And now you'll notice. Sorry.
2015-02-22 06:46:07 -05:00
Dan Stillman
aeb7b83a39 Update versions 2015-02-21 21:52:06 -05:00