Dan Stillman
77ea19277d
Remove embedded-image attachment under annotation in test
2021-03-02 18:10:44 -05:00
Dan Stillman
651aabc4dc
Prevent setting parent item to non-regular item
...
Except for embedded-image attachments under notes and annotations under
attachments
2021-03-02 18:10:44 -05:00
Dan Stillman
8b57d0000b
Don't orphan embedded-image attachments in schema integrity check!
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
d0bdc45b9f
Fix "Add to Note" for not yet created note
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
5ddae7c6e6
Update pdf-reader, zotero-note-editor
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
aa836d77af
Improve editor ir merge dialog
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
a225c498ec
Get rid of image natural dimensions
2021-03-02 18:10:44 -05:00
Dan Stillman
eb865e2625
setAttachmentPageIndex() → setAttachmentLastPageIndex()
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
580d800286
Add support for PDF navigation to pageLabel
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
16650b4ddf
Improve note creation from annotations
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
d23e0e30bb
Fix annotation insertion
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
67f76c1445
Update note-editor, pdf-reader, pdf-worker
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
7fa68690dd
Do not insert citation for parentless PDF
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
8d87eeae35
Capitalize acronyms
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
1a4b2e8c7d
Use isPDFBuild for editor switch, fix merge dialog
2021-03-02 18:10:44 -05:00
Dan Stillman
bb9237e82d
Better comment for Zotero.Item.prototype._getPageIndexSettingKey()
2021-03-02 18:10:44 -05:00
Dan Stillman
c8ee3196cd
Replace attachmentPageIndex with synced-setting-based mechanism
...
The page index needs to be per-person in group libraries, and it should
still work in read-only libraries, so it doesn't make sense to store it
on the item. This uses a synced setting in the user's library instead.
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
3b61214dad
Update pdf-reader and pdf-worker
2021-03-02 18:10:44 -05:00
Martynas Bagdonas
8eff0bf5d4
Reverse button fragment images
2021-03-02 18:10:44 -05:00
Dan Stillman
bb79686ce8
Add unused code to switch between the tab bar and the unified toolbar
2021-03-02 18:10:44 -05:00
Dan Stillman
28c1504cdd
Use old toolbar if not a PDF build
2021-03-02 18:10:44 -05:00
Dan Stillman
e1c0f6c1a0
Rename zotero-note-editor submodule to note-editor
2021-03-02 18:10:42 -05:00
Martynas Bagdonas
4c11d45679
Use pre-built submodules to speed up building
2021-03-02 17:58:29 -05:00
Dan Stillman
88dc6638fe
Add Zotero.isPDFBuild feature flag
...
Currently limited to PDF opening (which is then dependant on
the beta.useInternalPDFReader pref)
2021-03-02 17:58:29 -05:00
Dan Stillman
10f41547aa
Search for words separately in PDF reader notes pane
2021-03-02 17:58:29 -05:00
Dan Stillman
a1655e5643
Remove colon from "[n] notes:" line at top of notes panes
2021-03-02 17:58:29 -05:00
Dan Stillman
ed406ec118
Comment out :focus-visible CSS rules to prevent console warnings
2021-03-02 17:58:29 -05:00
Martynas Bagdonas
224eb6bc84
Fix navigation to specific PDF page
2021-03-02 17:58:28 -05:00
Dan Stillman
f0816cc8fb
Add temporary prefs checkbox to use internal PDF reader
...
And use when opening PDFs in My Library from items list and
zotero://open-pdf
This also adds "Zotero" to the main PDF reader pref, which will be the
real way to set this, but that option is hidden for now so that group
library items will still open with the configured reader.
2021-03-02 17:58:28 -05:00
Martynas Bagdonas
04c64fe9fc
Use old editor in group libraries
2021-03-02 17:58:28 -05:00
Martynas Bagdonas
66bed2529c
Fix various PDF reader and note editor issues
2021-03-02 17:58:28 -05:00
Dan Stillman
4a4a54da7b
Clear annotation change state after save
2021-03-02 17:58:28 -05:00
Dan Stillman
98f9a99126
Fix annotation tests after adding isExternal to annotation JSON
2021-03-02 17:58:28 -05:00
Dan Stillman
9f954488c6
Delete cache image when image annotation position changes
2021-03-02 17:58:28 -05:00
Martynas Bagdonas
a19693fa7a
Improve PDF importing and introduce rendering
2021-03-02 17:58:28 -05:00
Dan Stillman
89d9efdec7
Use seconds instead of ms for attachmentLastProcessedModificationTime
2021-03-02 17:58:28 -05:00
Dan Stillman
88f886cb30
Don't delete all annotations when updating attachment item
2021-03-02 17:58:28 -05:00
Dan Stillman
857b413df1
Don't add non-syncing items to sync delete log
...
Currently just external annotations
2021-03-02 17:58:28 -05:00
Dan Stillman
226fc90308
Switch to cache files for image annotations
...
Instead of embedded-image attachments
Create with Zotero.Annotations.saveCacheImage({ libraryID, key }, blob)
2021-03-02 17:58:28 -05:00
Dan Stillman
8c464a7a8b
Add options
argument for Zotero.File.createDirectoryIfMissingAsync()
...
To allow passing 'from' argument through to OS.File.makeDir()
2021-03-02 17:58:28 -05:00
Dan Stillman
2a203afb20
Redo Zotero.File.generateDataURI() without XPCOM and type sniffing
...
Now async and takes a contentType parameter
2021-03-02 17:58:28 -05:00
Martynas Bagdonas
c13ac32ad2
Use new attachment fields for annotations import
2021-03-02 17:58:28 -05:00
Dan Stillman
ebc0ca2462
Add annotationIsExternal
property to annotations
2021-03-02 17:58:28 -05:00
Martynas Bagdonas
5266734ac9
Fix note editor tests
2021-03-02 17:58:28 -05:00
Martynas Bagdonas
232ffba2ab
Improve note content insertion
2021-03-02 17:58:28 -05:00
Dan Stillman
404eaf13d0
Remove obsolete line from Zotero.Reader.open()
2021-03-02 17:58:28 -05:00
Martynas Bagdonas
a96c16a33d
Fix resizing for all vertical panes on macOS
2021-03-02 17:58:28 -05:00
Adomas Venčkauskas
5bc41e250b
Fix citing with automatic citation updates disabled
2021-03-02 17:58:28 -05:00
Dan Stillman
c73f51faef
Always await callback in ZoteroPane.viewAttachment()
...
The recent change to sniff for PDFs when an attachment didn't have a
content type resulted in a ZoteroPane test failing, because a stub for
Zotero.launchFile() wouldn't be called by the time the viewAttachment()
promise resolved.
2021-03-02 17:58:28 -05:00
Dan Stillman
1f2408a9c5
Fix ZFS tests after removing format=json
from syncAPIClient
2021-03-02 17:58:28 -05:00