Commit graph

11776 commits

Author SHA1 Message Date
Tom Najdek
a08c3dee14
Add tests for Zotero.File.download #2216
This test covers couple of scenarios downloading a 16MB file from a
local http server (simple and concurrently) using Zotero.File.download.

When running current implementation, this seems to fail persistently.

In real-world usage, current implementation seems to work
intermittently, failing more often for larger files.

This intermittent behaviour is most likely cause of #2216.
2021-10-02 00:39:09 +02:00
Martynas Bagdonas
3b84e29c9e Update context pane notes list when note is moved to/from parent 2021-10-01 14:47:50 +03:00
Martynas Bagdonas
47c61d3a4d Add limitations for attachment notes 2021-10-01 13:19:20 +03:00
Martynas Bagdonas
e09f1ba5d2 Fix pdf-worker build script 2021-09-27 14:39:53 +03:00
Martynas Bagdonas
c0ecd7691b Focus parent from tab "Show in Library", and PDF file from File menu 2021-09-27 13:46:19 +03:00
Martynas Bagdonas
1f634f9e31 Use OS.File.writeAtomic without tmpPath to avoid #2210 2021-09-23 13:53:47 +03:00
Martynas Bagdonas
47d4949b2a Upgrade note-editor schema to v5:
- Make citation node a leaf node.
- Don't parse citation node inner text.
- Don't trigger citation inner text updating on citation item changes.
- Format citation text only when serializing note HTML.
- Wrap individual citation items into `<span class="citation-item"></span>`.
2021-09-22 19:30:44 +03:00
Dan Stillman
4cfa230508 Add module import shim for 'zotero/filePicker' for plugins
Changed to 'zotero/modules/filePicker' in af597d943b, but a lot of
plugins haven't yet been updated
2021-09-18 06:57:35 -04:00
Dan Stillman
571801e1fb Fix min-height on search results in advanced search window
Regression from HTML tree

Fixes #2206
2021-09-17 06:11:51 -04:00
Dan Stillman
57c9da6df3 Spaces → tabs in _item-tree.scss 2021-09-17 06:11:51 -04:00
Dan Stillman
e2cbb51c31 Update locales from Transifex and merge new English strings 2021-09-17 06:11:51 -04:00
Dan Stillman
7e8bc80c1d "Manage Lookup Engines" dialog tweaks (#2195)
- Lowercase "engines"
- Increase font size
- Switch to hyphenated element id
2021-09-17 05:38:56 -04:00
Abe Jellinek
241981057b Correct Lookup Engine description
The Locate dropdown isn't in the Info pane, and the text was a bit more
verbose than it needed to be.
2021-09-17 05:38:56 -04:00
Martynas Bagdonas
7f7483115f Update pdf-reader and pdf-worker submodules 2021-09-16 13:51:23 +03:00
Dan Stillman
f0a8c9ada3 Merge pull request #2070 from mrtcode:restore-context-pane-tags-related 2021-09-14 01:53:21 -04:00
Dan Stillman
647afbb089 Update related box if related items are renamed or deleted 2021-09-14 01:50:58 -04:00
Martynas Bagdonas
61e3e339bb Restore tags and related tabs, display note links box 2021-09-14 01:50:58 -04:00
Dan Stillman
fa4020f784 HTML tree: Disable clickthrough on collection and item trees
And also the tag selector, while we're at it. Leaving enabled for the
item pane.

(Clickthrough is responding to a click when the window doesn't have
focus, rather than having the first click just raise the window.)

Fixes #2203
2021-09-14 00:43:15 -04:00
Dan Stillman
aeabe0b3f6 Fix inability to drag subcollection to top level within group library
HTML tree regression

Fixes #2201
2021-09-14 00:43:15 -04:00
Abe Jellinek
c5067edd2d
Fix Scaffold failing to initialize (#2200) 2021-09-09 05:17:35 -04:00
Martynas Bagdonas
7468065528 Switch to library tab when dragging a PDF file over Zotero window 2021-09-07 16:53:20 +03:00
Martynas Bagdonas
d38d42d60c Focus main window when navigating to annotation from note window 2021-09-07 12:01:42 +03:00
Dan Stillman
7672340819 HTML tree: Don't select all items on Cmd-Shift-A 2021-09-02 20:24:44 -04:00
Dan Stillman
576b9b7817 Fix SQL error saving an item with hundreds of related items
Fixes #2139
2021-09-01 06:19:56 -04:00
Dan Stillman
14b7206276 Get row height from tree for ItemTree::ensureRowsAreVisible() 2021-09-01 05:15:44 -04:00
Dan Stillman
dadf630728 HTML tree: ensureRowsAreVisible() shouldn't scroll if unnecessary
Fixes #2166
2021-09-01 01:45:54 -04:00
Dan Stillman
c5d89f6d07 Temporarily disable a tree test
Triggered by 4fa7070a31, but I think it's just a problem with
`ensureRowsAreVisible()` in the HTML tree
2021-08-31 07:27:49 -04:00
Dan Stillman
69a43ec456 Hack to fix sorting after reordering columns
There's probably a better fix for this, but this seems to work.
2021-08-31 06:55:57 -04:00
Dan Stillman
4fa7070a31 Fix item tree sorting when column doesn't have .sortDirection property 2021-08-31 06:55:57 -04:00
Martynas Bagdonas
d77b00bf9a Clarify and comment tab moving code 2021-08-31 11:37:01 +03:00
Adomas Venčkauskas
d8af5b7923 Fix wrong collection contents shown when switching collections at startup
Closes #2175
2021-08-30 15:19:12 +03:00
Adomas Venčkauskas
d4b3ed7fd8 HTML Tree: Fix opening multiple items with [Enter] 2021-08-30 15:19:12 +03:00
Martynas Bagdonas
b5ea925d02 Jump back to the opening tab even if the PDF was already open
Fixes #1985
2021-08-30 14:56:09 +03:00
Martynas Bagdonas
295874f803 Fix issue where non-existing tab is selected when closing multiple tabs 2021-08-30 14:12:22 +03:00
Martynas Bagdonas
b8cb093f79 Open multiple PDFs in tabs if SHIFT wasn't pressed, remove old code 2021-08-30 13:43:14 +03:00
Adomas Ven
cb9df902bc
HTML Tree: make find as you type a virtualized table functionality (#2176)
Closes #2168, closes #2169.
Adds find-as-you-type to locate, preference style and export
formats managers.

To enable find as you type you need to specify the getRowString(index) prop
on the VirtualizedTable. See prop comment for more info.
2021-08-30 06:01:08 -04:00
Adomas Venčkauskas
6c5e35ad73 HTML tree: multi-line cell text overflowing. Closes #2171 2021-08-30 12:55:20 +03:00
Adomas Venčkauskas
94c4d975a9 HTML Tree: fix item deletion breakage when child items are selected.
Closes #2174
2021-08-30 12:50:29 +03:00
Adomas Venčkauskas
873846261e Fix export preferences HTML tree 2021-08-30 12:06:17 +03:00
Martynas Bagdonas
aa7f5289a3 Filter ink annotations before creating note from annotations 2021-08-30 11:06:10 +03:00
Dan Stillman
c2df338430 Allow 'ink' annotation type to be created 2021-08-30 03:58:58 -04:00
Adomas Venčkauskas
37d5e99fde Fix some keyboard selection bugs in HTML collection tree
Moving pivot via [CMD/CTRL]+[ArrowKey] would change collection tree
focus without updating the UI
Select-all shortcut worked in the collection tree
2021-08-30 10:23:03 +03:00
Adomas Venčkauskas
b8545590d5 HTML Tree: more fixes to find as you type 2021-08-30 09:57:28 +03:00
Adomas Venčkauskas
2ef5afdd9c Disable typing navigation with modifier keys pressed. Closes #2170 2021-08-30 09:52:13 +03:00
Dan Stillman
d723065a3d HTML tree: Don't move dragged external files by default on macOS
Fixes #2172
2021-08-30 02:40:06 -04:00
Dan Stillman
952663de73 Fix failing repo notice tests 2021-08-29 04:41:52 -04:00
Dan Stillman
2459614f04 Add mechanism for showing dialog with notice from repo
- Messages are shown once a day by default (within the same session for
  id-less messages)
- Messages with an `id` attribute include a checkbox to not show again
  for 30 days
- If an `infoURL` attribute is provided, a "More Information" button is
  shown that launches that URL
- If `title` is provided, it's used for the dialog title. Otherwise
  "Warning" is shown.
2021-08-29 04:25:49 -04:00
Dan Stillman
ba7d0a18aa Restore itemTree::saveSelection()
Deprecated for years, but used by ZotFile
2021-08-29 01:41:40 -04:00
Dan Stillman
8d3adb6f46 HTML tree: Add tree.focus()
And fix shortcut key for selecting library
2021-08-28 22:43:09 -04:00
Dan Stillman
dea4a47b69 Make Zotero.HTTP retry test a bit more robust 2021-08-27 17:12:49 -04:00