Commit graph

11411 commits

Author SHA1 Message Date
Martynas Bagdonas
415e644211 Upgrade note schema to v2:
- Automatically upgrade all editable v1 notes when note is being opened
- Pull `itemData` from existing citations and annotations into metadata container attribute `data-citation-items`
- Strip `abstract` from `itemData`
- Fill `citationItem` (in citations and annotations) with `itemData` when passing an HTML fragment for further processing in `note-editor`
- Keep only `uri`, `text`, `color`, `pageLabel`, `position`, `citationItem` annotation properties
2021-04-02 18:35:01 +03:00
Dan Stillman
26bf507fe2 Throw invalid-data error on unknown annotation type 2021-04-01 05:52:14 -04:00
Dan Stillman
40b871c2fd Updates locales from Transifex and merge new English strings 2021-03-29 02:19:04 -04:00
Dan Stillman
e5ef3affd2
Merge pull request #2017 from Elaborendum/master
Add localizable strings from connector
2021-03-29 02:18:41 -04:00
Dan Stillman
6d212b1759 Update About window
- Add Zotero logo
- Move most acknowledgements to the website, where they can be more more
easily updated and more comprehensive
- Increase font size
- Center window on screen
2021-03-29 01:41:37 -04:00
Dan Stillman
31d095fb42 Add test for citeproc-js disambiguation hang
https://github.com/Juris-M/citeproc-js/issues/179
2021-03-29 01:41:37 -04:00
Dan Stillman
5e9636089d Fix primary item types not appearing in More menu when not in MRU list
Regression in 1c366de54
2021-03-29 01:41:37 -04:00
Elaborendum
5b17bd0a43
Update connector.json 2021-03-27 21:33:11 -05:00
Martynas Bagdonas
5e98b9c533 Select library tab when navigating to item from syncRunner popup 2021-03-25 20:56:02 +02:00
Martynas Bagdonas
f6fa81fdac Strip abstract field to save note space, set new itemData on export 2021-03-25 20:56:01 +02:00
Martynas Bagdonas
3536a384a9 Ensure attachment storage dir exists when saving pdf-reader state 2021-03-24 18:51:27 +02:00
Martynas Bagdonas
da6c852e37 Update pdf-reader and pdf-worker 2021-03-24 18:27:56 +02:00
Martynas Bagdonas
ec7251fd98 Fix tab toolbar button icon scaling on HiDPI 2021-03-23 18:04:38 +02:00
Martynas Bagdonas
3d204f75e9 Focus pdf-reader on tab selection if not focused contextPane note editor 2021-03-23 18:00:07 +02:00
Dan Stillman
f690c666d4 Don't make 'engine' required in Sync.Storage.Request
Follow-up to dc12a2c95a
2021-03-23 03:49:05 -04:00
Dan Stillman
f20263a50f Fix disambiguation-related hang in citeproc-js
This reverts the fix for
https://github.com/Juris-M/citeproc-js/issues/171 to fix the hang in
https://github.com/Juris-M/citeproc-js/issues/179
2021-03-23 03:31:22 -04:00
Dan Stillman
8c341f2e26 Add field name to assertion in annotation clone test 2021-03-23 03:20:33 -04:00
Dan Stillman
45968375d8 Return sooner in _checkForUpdatedFile() on SYNC_STATE_TO_UPLOAD
Before file.stat() instead of after, though it probably doesn't really
matter because the file is already open, which makes the stat call much
faster
2021-03-23 03:20:33 -04:00
Dan Stillman
dc12a2c95a Stop file upload queue after low-quota errors
We weren't making actual upload requests after a quota error if the file
would exceed the quota, but we were still going through all attachments
to upload, which in some cases involves making stat() calls. We now just
stop the queue immediately after a quota error or when starting a new
background sync after a previous quota error.

Closes #1255
2021-03-23 03:20:26 -04:00
Dan Stillman
8f7afb4a57 Fix Zotero.automatedTest in GitHub Actions
$TRAVIS → $CI

Some tests were being run that should be skipped
2021-03-21 17:39:49 -04:00
Dan Stillman
c0eea4dadd Missed annotation property from 7889cd5d3 2021-03-21 15:53:12 -04:00
Dan Stillman
7990ce721e Update pdf-reader submodule 2021-03-21 14:37:03 -04:00
Dan Stillman
b566c06f93 Add getImageBlob() support function for tests 2021-03-21 14:36:43 -04:00
Dan Stillman
06b28194da Show annotation widget in conflict resolution window
This adds a very basic reimplementation of the annotation widget for use
in the CR window. It's not pixel-perfect, but it's close enough that
most people probably won't notice. We'll want to replace this with a
real version that's shared between the PDF reader and the rest of the
codebase.

Image annotations currently show an "[image not shown]" placeholder.
Showing images is tricky: we don't have the remote cache image, so if
the remote position has changed, we could only show an image by
rendering it from the file, and only if the file itself hasn't changed.
Just for a better user experience, we could use the local image as long
as the position and file are both the same, but that would take some
rejiggering of the CR window.

Tags aren't shown because they're not shown for CR at all, though that
could be changed in the future.
2021-03-21 14:36:43 -04:00
Dan Stillman
7889cd5d39 Fix item.clone() on annotation items 2021-03-21 14:36:42 -04:00
Martynas Bagdonas
9eb4fdb9cd Return back to notes list when a note is deleted 2021-03-19 12:41:07 +02:00
Martynas Bagdonas
ac750520e7 Use browser element instead of iframe to have access to History API 2021-03-18 18:19:09 +02:00
Martynas Bagdonas
f02b3464b8 Close note editor window when the note item is deleted 2021-03-18 10:05:21 +02:00
Martynas Bagdonas
4f71c2ab09 Improve PDF reader and note editor error handling 2021-03-18 10:03:36 +02:00
Martynas Bagdonas
1ede4240e0 Close all tabs and unregister tabs observer when destroying main window
#2005
2021-03-17 17:59:04 +02:00
Martynas Bagdonas
bf84e16002 Show crash popover on annotation saving failure
#2006
2021-03-17 13:43:48 +02:00
Martynas Bagdonas
1677e957cd Properly ignore deleted PDF attachments and close pdf-reader tabs
#2006
2021-03-17 13:43:48 +02:00
Martynas Bagdonas
8013a6ce97 Do not select the closest tab when closing a tab that is not selected 2021-03-17 13:41:21 +02:00
Dan Stillman
ae98488d2b Fix selectItem() on first items row (regression from d5334dc483) 2021-03-17 00:31:42 -04:00
Dan Stillman
c04f5c28a2 Update pdf-reader submodule 2021-03-17 00:17:53 -04:00
Dan Stillman
d5334dc483 Fix item tree breakage if annotation is added while search is active 2021-03-17 00:14:43 -04:00
Martynas Bagdonas
bb2f1ced99 Position pdf-reader color popup by element instead of coordinates 2021-03-15 20:27:24 +02:00
Dan Stillman
b3e46392ba Update pdf-reader 2021-03-14 19:12:48 -04:00
Dan Stillman
ed70b404ad Tweak zoom labels in PDF reader context menu
"Automatic" → "Automatically Resize"
"Page Width" → "Zoom to Page Width"
2021-03-12 06:59:53 -05:00
Dan Stillman
76d504c564 Delete child annotations when deleting attachment
And fix a FK definition that could result in orphaned `items` rows
without `itemAnnotations` rows after an attachment was deleted.
2021-03-12 06:35:21 -05:00
Dan Stillman
0bc6b2ccc6 Transfer annotations when converting linked files to stored files
Previously, any annotations on the linked file were partially deleted,
leaving broken `items` rows without `itemAnnotations` rows.
2021-03-12 06:35:21 -05:00
Martynas Bagdonas
7b0bd05865 Add PDF page context menu, update editor & reader
Fixes #1978
2021-03-11 17:24:48 +02:00
Dan Stillman
cbfaed7abf Update locales from Transifex and merge new English strings 2021-03-10 11:00:48 -05:00
Dan Stillman
98c101fd55 Notes pane: Change "Delete" to "Move to Trash" and remove confirm()
And remove unused _removeNote() function

We prompt to delete in the items list to distinguish from collection
removals, but it's arguably not necessary here, since you can always get
the item out of the trash. Undo would be nice, though.
2021-03-10 11:00:48 -05:00
Dan Stillman
24cc59cc7e Compress single-file HTML attachments and other text files
The test for ZIP uploads was having multiple files, but now snapshots
are all single files.
2021-03-10 09:37:52 -05:00
Dan Stillman
249d1aa0da Mendeley import: Add log lines for timing pdf-worker 2021-03-10 09:37:52 -05:00
Martynas Bagdonas
13cafe886e Rework note editor toolbar and related UI 2021-03-09 17:37:44 +02:00
Dan Stillman
824f67cb36 Mendeley import: Ignore empty text highlights 2021-03-08 10:58:15 -05:00
Dan Stillman
e4d7089506 Mendeley import: Fix blank PDF attachment MIME type from previous imports 2021-03-08 09:55:26 -05:00
Dan Stillman
5cdc088c49 Mendeley import: Import highlight and note annotations
Using new PDF worker functionality

If you've previously imported, you should be able to import again to get
annotations in the new PDF reader.

Details:

- Text highlights will be processed to extract text
- Rectangle highlights will turn into image annotations
- Any extracted-annotation notes created by previous improts won't be
  removed, but they're no longer created as long as the file exists.
2021-03-08 09:05:07 -05:00