mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
13379 commits 9 branches 364 tags 290 MiB
Commit graph

13379 commits

This branch
This branch
All branches
Author SHA1 Message Date
Abe Jellinek
cbece42fb9 Fix merge pane overflow behavior 
The item box CE can't be the scroll container, so it needs a wrapper element.

Fixes #3233
 2023-07-28 15:06:02 -04:00
Abe Jellinek
7036073ed1
Resolve plugin-provided URIs relative to rootURI (#3235) 2023-07-28 00:16:58 -04:00
Abe Jellinek
e271b4e494 copyToUnique: Fail if source contains destination 
To prevent unbounded recursion as in 16547f64c2.
 2023-07-27 12:24:51 -04:00
Abe Jellinek
16547f64c2 renameAttachmentFile: Check rename() return value 
And actually return -1 if it returns false.

Before this fix, attempting to rename an attachment file to a name that already
exists on disk would never return -1 as the docs say it should. Instead:

1. rename() would fail and return false
2. newName would be set to false
3. renameAttachmentFile() would pass false as the second argument to
   OS.Path.join()
4. OS.Path.join() would ignore it because it was falsy and return the attachment
   directory path without any modification
5. relinkAttachmentFile() would be called with path set to the attachment
   directory
6. relinkAttachmentFile() would notice that path's dirname wasn't the attachment
   directory - it was the attachment directory's parent - and attempt to copy it
   and its contents, recursively, into itself, using copyToFollowingLinks()

...which created a directory structure on disk over 100 directories deep -
not deeper only because the OS started returning errors due to paths exceeding
32,767 characters (the limit on my filesystem).
 2023-07-27 12:24:32 -04:00
Dan Stillman
00683732d8 Make XMLSerializer available in plugins 
https://groups.google.com/g/zotero-dev/c/ZKoDSBniSXs/m/VDhPpjNqAAAJ
 2023-07-26 23:01:23 -04:00
Dan Stillman
0d70925816 Fix error loading plugin scope after 6a2fcd6898 
`AddonManager.getActiveAddons(["extension"])` doesn't return fully
loaded addon objects if `getAllAddons()` hasn't been called
 2023-07-26 23:01:17 -04:00
Adomas Venčkauskas
987b7ea952 Update Word for Mac submodule 2023-07-26 16:10:58 +03:00
Dan Stillman
be1ab236c8 Better cycling through httpd.js ports to avoid CI failures 2023-07-26 07:25:22 -04:00
Dan Stillman
a376ad8762 Don't close and reopen window during WebDAV tests 
With any luck this will fix the crashing we've been getting in CI.
 2023-07-26 07:25:22 -04:00
Dan Stillman
6a2fcd6898 Remove loadExtensionDefaults() in prefs.js 
We now handle this in prefs.js.
 2023-07-26 07:25:21 -04:00
Dan Stillman
5c26fe15d8 Check for Node 18 or later 2023-07-26 06:49:00 -04:00
Dan Stillman
a1f49e11d5 Fix low-res webpage icon 2023-07-25 07:35:03 -04:00
Adomas Venčkauskas
d96afa4499 Fix split-menu-button dropmarker triggering the button click event 
Regression in fa31956d
 2023-07-25 14:23:34 +03:00
Dan Stillman
630c6d0d97 Fix tags not being saved in item tags box when pressing Enter 
SyntaxError: Element.querySelector: '[ztabindex=1]' is not a valid selector

https://forums.zotero.org/discussion/106405/zotero-7-changes-to-item-tag-do-not-persist
 2023-07-25 05:51:41 -04:00
Dan Stillman
fb59345637 Fix "Check for Update" buttons in error dialogs 
Fixes #3213
 2023-07-25 01:53:22 -04:00
Dan Stillman
ed2cae9236 Adjust attachment-title handling on Rename File from Parent Metadata 
Don't change the attachment title on a manual rename from metadata if it
doesn't match the current filename, with or without the extension

Closes #3220
 2023-07-25 01:48:23 -04:00
Dan Stillman
d95c10e06c Use NODE_OPTIONS=--openssl-legacy-provider in build_and_run 2023-07-25 00:52:54 -04:00
windingwind
c89590c7b7
Add ItemTree column API (#3186) 2023-07-25 00:47:12 -04:00
Abe Jellinek
676f820f87
Strip bidi control characters in filenames and elsewhere (#3208) 
Passing unformatted = true to Item#getField() now returns a bidi control
character-less result, and we use that in Reader#updateTitle() and
getFileBaseNameFromItem() to prevent bidi control characters from showing up in
filenames and window titles (the former everywhere, the latter on Windows only).

We also strip bidi control characters in getValidFileName() to be extra safe.
 2023-07-22 03:30:28 -04:00
Abe Jellinek
f8b4d186a8 Update pdf-worker submodule 2023-07-21 18:36:38 +03:00
Abe Jellinek
1217710234 PDFWorker manager: OS.File -> IOUtils 2023-07-21 18:36:38 +03:00
Abe Jellinek
5aaf368149 Use pdf-worker for hasEmbeddedAnnotations() 2023-07-21 18:36:38 +03:00
Dan Stillman
f4f9712bc9 Increase default title length limit to 100 in attachment filenames 2023-07-21 06:33:01 -04:00
Dan Stillman
2fad3d89ff Use getDisplayTitle() for titles in timelines 
https://forums.zotero.org/discussion/106290/zotero-timeline-does-not-display-email-subject
 2023-07-21 06:23:02 -04:00
windingwind
97235d2dea
Fix selectitems.xhtml persist bug (#3219) 
See https://groups.google.com/g/zotero-dev/c/OscDKuO9Rao
 2023-07-21 04:43:52 -04:00
Tom Najdek
0ba766f2e0
Customizable renaming rules #1413 (#2297) 2023-07-20 06:50:34 -04:00
Dan Stillman
96e2510165 Fix missing return in previous commit 2023-07-20 06:42:32 -04:00
Dan Stillman
590460cea4 Add Zotero.Prefs.prefHasUserValue(pref, global) 2023-07-20 06:41:23 -04:00
Dan Stillman
51c70eb925 Use system temp directory by default 
Might help for something like
https://forums.zotero.org/discussion/106337/zotero-7-sync-error
 2023-07-20 05:43:39 -04:00
Adomas Venčkauskas
75c46e1e5c Enable FAYT in document preferences. Closes #3214 2023-07-20 11:10:14 +03:00
Dan Stillman
d968e8ec33 Update locales from Transifex 2023-07-18 07:55:41 -04:00
Dan Stillman
d3502b22f2 Update Linux build to Firefox 102.13.0esr 2023-07-18 07:40:20 -04:00
Adomas Venčkauskas
1b30c8b2b5 Add a comment for bib style caching. Closes #3211 2023-07-18 10:58:12 +03:00
Adomas Venčkauskas
f61826281b Revert "Merge pull request #3195 from CommonLoon102/cl102/fix-bib-indent" 
This reverts commit aca86967bf, reversing
changes made to 1a850d58c4.
 2023-07-18 10:55:14 +03:00
abaevbog
9599d1712c
disable file > close for library if 1+ tabs open (#3210) 
When there are multiple tabs opened, menuitem File > Close is disabled for the library tab.

Fixes: #3198
 2023-07-18 03:40:19 -04:00
Martynas Bagdonas
e37eaac8d1 Fix panes overflowing in stacked view mode 
Fixes #3180
 2023-07-17 17:07:38 +03:00
Dan Stillman
c425f71ac4 fx-compat: Fix error passing cookieSandbox to Zotero.HTTP.request() 
https://groups.google.com/g/zotero-dev/c/UgP_kZvrEjA/m/KjimYREGAgAJ

getInterface() seems to exist on XHR and nsIWBP without QIing to
nsIInterfaceRequestor, and XHR no longer has QueryInterface().
 2023-07-17 06:42:14 -04:00
Dan Stillman
65fe50d11f Clear startup cache when uninstalling/upgrading plugins 
https://groups.google.com/g/zotero-dev/c/0nfU-F2q1uI/m/1jBVmMZxBAAJ

Removed by Mozilla in
https://bugzilla.mozilla.org/show_bug.cgi?id=1445739, since
WebExtensions don't put anything in the startup cache
 2023-07-15 18:39:59 -04:00
Dan Stillman
838152155e Log warning when not setting createdByUser/lastModifiedByUser 
(I encountered this in a test when trying to set createdByUserID without
`Zotero.Users.setName()`.)
 2023-07-14 05:48:48 -04:00
Dan Stillman
dc321ce643 Fix startup error on Windows 
Regression from 8d3f874e64, which included this unfinished code by mistake.

Fixes #3196
 2023-07-14 05:48:48 -04:00
abaevbog
0cd94555d5
prevent incorrect jumpback (#3204) 
Fixes: #3152
 2023-07-14 05:29:43 -04:00
Dan Stillman
d7449b4d78 Fix merging of group attachments with annotations created by another user 
https://forums.zotero.org/discussion/106197/merge-in-group-library-fails-despite-having-edit-permissions
 2023-07-13 19:58:47 -04:00
Adomas Venčkauskas
e5d25f3d66 Fix /connector/saveSnapshot still not including info about snapshots 2023-07-12 10:21:46 +03:00
Abe Jellinek
2aa34a6346 Merge: Remove spacing from annotation regex, delete external annotation items 
- `/Subtype` isn't necessarily preceded or followed by a space
- Annotation items with `isExternal: true` are for display only and should be
  deleted on merge

https://forums.zotero.org/discussion/105960/external-annotations-ignored-when-merging
 2023-07-11 11:12:58 -04:00
Adomas Venčkauskas
a0cdf11096 Fix failing test from 02ba9ca7 2023-07-11 15:57:35 +03:00
Adomas Venčkauskas
02ba9ca7f0 Include information about saved snapshots in /saveSnapshot 2023-07-11 15:45:51 +03:00
Martynas Bagdonas
5928147f26 Fix middle-click selecting tab that is being closed 2023-07-11 14:02:12 +03:00
Dan Stillman
0186e6330a Update note-editor 2023-07-11 06:12:39 -04:00
Dan Stillman
ae4587226c Update note-editor submodule 2023-07-11 05:37:32 -04:00
Dan Stillman
8d3f874e64 Remove all uses of Zotero.isStandalone 
(View diff with -w)
 2023-07-11 05:35:32 -04:00