Commit graph

12112 commits

Author SHA1 Message Date
Dan Stillman
a2458614df Don't include date line when generating filename for annotations note
Since in many locales it would contain slashes and colons, both of which
would be stripped in the filename, leaving long strings of numbers in
the filename
2022-02-19 13:45:29 -05:00
Dan Stillman
5eee488e20 Update utilities submodule
And add tests for `Utilities.Internal.noteToTitle()`

Follow-up to zotero/utilities@df2dda23b
2022-02-19 13:43:41 -05:00
Martynas Bagdonas
5405da99db
Add support for annotation templates (#2359) 2022-02-18 14:38:36 -05:00
Dan Stillman
7606c88e79 Tweak Word/Apple Silicon warning text 2022-02-17 01:43:39 -05:00
Dan Stillman
b99aeae76e Add DB test for combination of numbered and unnumbered query placeholders 2022-02-17 01:43:39 -05:00
Dan Stillman
db35f55c96 Limit autocomplete in Advanced Search to specific creator types
For `author`, `bookAuthor`, and `editor` conditions added in #2253
2022-02-17 01:43:39 -05:00
Abe Jellinek
91cdc5610b
Search by specific creator type (#2353)
Author, editor, or book author.
2022-02-17 01:06:14 -05:00
Martynas Bagdonas
924d29ff7e Fix undefined Zotero_Tabs issue 2022-02-14 14:13:30 +02:00
Adomas Venčkauskas
06676be8e4 Add defaultSort attribute to columns
Sort date columns in descending order by default.
Closes #2344
2022-02-11 16:19:59 +02:00
Martynas Bagdonas
e6c835abc8
Allow to show/hide citations in notes (#2288) 2022-02-11 12:50:43 +02:00
Martynas Bagdonas
bcfd93bc79 Set lastModifiedByUser even if an annotation author is authoritative 2022-02-10 10:55:02 +02:00
Dan Stillman
cb2df23580 Add tests for directoryContains()
Follow-up to #2335
2022-02-10 03:18:06 -05:00
qqobb
47799adb3c
Improve directoryContains() (#2335) 2022-02-10 03:17:46 -05:00
Dan Stillman
f509e9063a Fix arrow keys in View menu
Arrow keys still step through `collapsed` menuitems, whereas `hidden`
properly hides them from key navigation.
2022-02-10 02:52:02 -05:00
Dan Stillman
76c7e832bb Add accesskey for View menu
https://forums.zotero.org/discussion/94431/6-0-beta-underline-of-view-menu
2022-02-10 02:52:02 -05:00
Martynas Bagdonas
ee3e28e126 Changes to how author name is passed to pdf-reader and pdf-worker 2022-02-09 16:54:46 +02:00
Adomas Venčkauskas
8c846468f2 Update strings for Mac Word errors 2022-02-09 15:25:45 +02:00
Dan Stillman
c6d03753fd Don't copy external annotations to between libraries 2022-02-09 07:08:18 -05:00
Dan Stillman
9156d69110 Update pdf-worker submodule 2022-02-09 06:56:44 -05:00
Dan Stillman
9bf842a3ae Update locales from Transifex and merge new English strings 2022-02-09 06:44:03 -05:00
Dan Stillman
54eb13ce9e Fix annotation-copying tests after bacc5b4428 2022-02-09 00:07:58 -05:00
Dan Stillman
bacc5b4428 Preserve explicit annotation author name when copying from group 2022-02-08 23:57:49 -05:00
Abe Jellinek
9cf45c0a0b
Set default filename when exporting single note (#2339) 2022-02-08 23:28:53 -05:00
Dan Stillman
734057ff9b Require DB transaction in Zotero.Items.moveChildItems()
But make optional with deprecation warning for now, since it's used in
ZotFile
2022-02-08 06:38:48 -05:00
Dan Stillman
f684984b07 Copy annotations across libraries
Based on option in prefs

When copying an annotation group the
2022-02-08 06:38:32 -05:00
Dan Stillman
67451dffd5 Add annotationAuthorName property to annotation items
And pass both `authorName` and `lastCreatedByUser` to the PDF reader.
The former can either come from `createdByUser` or be set directly on
the item (for group annotations dragged to personal libraries).
2022-02-08 06:38:32 -05:00
Dan Stillman
60f9a0417f Remove isAuthor from JSON passed to PDF reader 2022-02-08 06:38:32 -05:00
Dan Stillman
bf9ef5fc01 Disable PDF annotation transfer in group libraries 2022-02-08 06:38:32 -05:00
Dan Stillman
cc0687a574 Fix selectLibrary() in CollectionTree if no libraryID passed 2022-02-08 06:38:32 -05:00
Adomas Venčkauskas
0d2cfef160 HTML Tree: fix errors being thrown on hover over empty cells
Regression in 54ad6da1
2022-02-08 10:00:36 +02:00
Martynas Bagdonas
b865ee8b65 Fix tagsBox issues in a separate note window:
- Invisible auto-suggested tags
- Oversized tag icon
2022-02-07 17:39:09 +02:00
Dan Stillman
697798b536 Bump version to 6.0 2022-02-05 03:17:51 -05:00
Dan Stillman
e4f5241058 Add missing quote in logged error 2022-02-05 03:17:51 -05:00
Adomas Venčkauskas
54ad6da1af HTML Tree: make tooltip setting code use any parent xul node 2022-02-04 14:19:20 +02:00
Dan Stillman
c78bf1b2a3 Fix feed item guid in logged warning when item exists in different feed 2022-02-04 02:18:38 -05:00
Abe Jellinek
e8b574da0b
Fix React icons only using 2x image once (#2324)
a1267bc fixed repeated re-appending of '@2x' by moving the modified URL
to a local variable, but it still set hasHiDPI to false permanently;
this meant that icons displayed repeatedly in the same window, like the
tab close button, would only use their 2x versions the first time they
were displayed (in the case of tabs, this is the library tab's invisible
close button, so *no* tabs got visible 2x buttons).

This commit moves the HiDPI check and URL modification out of the render
function and instead runs it a single time when i() is first called.
2022-02-04 00:38:01 -05:00
Adomas Venčkauskas
8de1ddcaf4 HTML Tree: Display a tooltip with full cell contents when truncated
Closes #2321

Also added tooltips for cells that use an icon in their contents
2022-02-03 16:09:40 +02:00
Abe Jellinek
4777f0ec89 Double-click/enter to edit feed
Closes #2323
2022-02-02 23:03:04 -08:00
Tom Najdek
90da2563c8
Decouple progress queue table from progress window (#2318)
* Tweaked ProgressQueue to accept multiple listeners per event.
  Removing listeners now requires specifying which one to remove.
* Decoupled progress queue table into new ProgressQueueTable component
2022-02-02 17:15:57 -05:00
Dan Stillman
1ea1a134ba Reset extensions.spellcheck.inline.max-misspellings
Closes #2108
2022-02-02 05:48:23 -05:00
Adomas Venčkauskas
060d2f1c37 Item tree: Add tooltips for header cells.
Restrict the html-tooltip [title] selector to not fall back to
window title when no title attributes are present.
2022-02-02 12:25:50 +02:00
Dan Stillman
15ae72d143 Update pdf-reader submodule 2022-02-02 04:38:47 -05:00
Dan Stillman
4e6b68477d PDF reader: Annotation name display changes
- Show creator's name in groups even when it's the current user
- Don't show name for external annotations
2022-02-02 03:54:34 -05:00
Dan Stillman
3902043669 Update locales from Transifex and merge new English strings 2022-02-02 02:22:34 -05:00
Dan Stillman
a6e0432848 PDF reader: Tweak annotation deletion confirmation text 2022-02-02 02:09:20 -05:00
Dan Stillman
82b1ce2027 Update pdf-reader and pdf-worker 2022-02-02 01:53:50 -05:00
Martynas Bagdonas
21ca1555c1 Focus tag input field if tagsBox doesn't have tags
Fixes #2315
2022-01-31 19:49:58 +02:00
Dan Stillman
cec1f18670 Fix nesting of resetUnsyncedLibraryFiles() test 2022-01-31 06:48:05 -05:00
Dan Stillman
637acbe693 Fix incorrect isEditable() test in Item::moveToLibrary() 2022-01-31 06:48:05 -05:00
Dan Stillman
df64a16b55 Disallow unowned group annotation edits, but allow deletions
Update `DataObject::isEditable()` to take an optional `op` argument to
test individual operations as opposed to general library editing.
Erasing objects now tests `erase`, and `Item::isEditable()` allows
`erase` for unowned group annotations while disallowing the default
`edit`.

It's still up to the reader to handle this appropriately in the UI and
not allow operations it shouldn't, but this enforces it in the data
layer.
2022-01-31 06:48:05 -05:00