Commit graph

13010 commits

Author SHA1 Message Date
Abe Jellinek
1aebad3c19 Scaffold: Fix copying JSON test data
Previously only copied '[object Object]'.
2022-11-01 16:04:24 -04:00
Dan Stillman
b5ce8b655a Fix error copying from note if note Quick Copy format is "HTML"
In this case, Note Markdown wouldn't be preloaded, but it's always used
for copying from the note editor, and since the note editor uses
`noWait`, this would result in "Code promise is not resolved in noWait
mode".
2022-11-01 03:56:25 -04:00
Dan Stillman
cbb1ebad33 Fix Quick Copy drag after reiniting translators
Zotero.Translators.reinit() didn't reinit Quick Copy, so if an export
translator was selected it wouldn't be preloaded again and dragging
would fail with "Code promise is not resolved in noWait mode".
2022-11-01 03:19:22 -04:00
Adomas Venčkauskas
228e8407a7 Make colored tagging via keyboard layout independent
Report https://forums.zotero.org/discussion/100717/tag-number-shortcut-with-mac-raccourci-clavier-pour-marqueurs-avec-un-mac
2022-10-31 09:45:27 +02:00
Dan Stillman
8e59e49d29 Avoid infinite/excessive loops in Find Available PDF
https://forums.zotero.org/discussion/100634/potential-infinite-loop-when-trying-to-find-available-pdf

Closes #2883
2022-10-30 04:44:31 -04:00
Dan Stillman
4722366b42 Update Mac Word automation settings instructions for Ventura 2022-10-29 16:42:28 -04:00
Dan Stillman
7a45047f8f Fix comment for Zotero.Attachments.getPDFResolvers() 2022-10-29 04:41:16 -04:00
Dan Stillman
59cb33d231 Retry only twice on error in Find Available PDF
Not three times
2022-10-29 04:41:10 -04:00
Dan Stillman
06b23cca94 Fix hang on 500 from site during Find Available PDF
Find Available PDF has its own domain-based retry logic that predated
automatic 5xx retries in Zotero.HTTP, so disable the latter and fix some
bugs in the former.

Fixes #2700
2022-10-29 04:38:57 -04:00
Adomas Venčkauskas
d658e05363 Truncate long citation text in citation dialog. Closes #2879 2022-10-28 15:08:26 +03:00
Abe Jellinek
57916c032f
Attachment box: Add ability to copy URL of snapshot/link (#2748)
Fixes #2747
2022-10-27 16:54:50 -04:00
Dan Stillman
9869eb4bc8 Restore cell.csl for style tests
Removed in a28908f0b4
2022-10-27 05:07:46 -04:00
Dan Stillman
d850a8be7d Don't localize "Markdown" in Quick Copy settings 2022-10-27 05:06:55 -04:00
Dan Stillman
c6448bd9c1 Add Zotero.Utilities.Internal.stringWithColon() for localized colons
Generally just a colon, but, e.g., French adds a space before it. We'll
want to replace uses of `punctuation.colon` with this.
2022-10-27 05:05:47 -04:00
Dan Stillman
146d50c8d1 Update translators 2022-10-27 05:05:35 -04:00
Dan Stillman
c51cb88c97 Adjust layout of Quick Copy note format options
Also:

- Hide format options until translators are loaded (since otherwise
  the checkboxes don't have labels and the layout is messed up)
- Remove unnecessary "zotero-" prefix from the new elements
2022-10-27 05:04:16 -04:00
Dan Stillman
a95a2937c1 Reset note Quick Copy pref on upgrade if set to Markdown + Rich Text
The default JSON pref value used spaces, but changing the drop-down
resulted in a version without spaces, so simply changing the default to
include the new link options wouldn't change all existing installs and
the "Include App Links" checkbox wouldn't show as enabled for Markdown.
This adds a pref migration step to reset the pref to the new default if
it's set to Markdown + Rich Text, regardless of whitespace differences.
2022-10-27 04:50:04 -04:00
Martynas Bagdonas
da7c73b662 Add "Include Zotero Links" option for note export and QuickCopy
Fixes #2349
2022-10-27 04:49:11 -04:00
Dan Stillman
09f0f74104 Fix error message for invalid field in Item.setField()
The error message was showing a field instead of an item type.

https://forums.zotero.org/discussion/100598/error-1533410729-impossible-to-correct-date-field-in-items-added-with-zotero-conector-ver-6-0-15
2022-10-27 03:47:54 -04:00
Dan Stillman
3a77eb85ed Don't match all attachments with annotations for "not" search conditions
Fixes #2867
2022-10-27 03:46:18 -04:00
Dan Stillman
fe016edf33 PDF reader: Hide "Rotate Page 180°" menu option for now
Rotating will speed up with Zotero 7, so maybe we can do without this.
2022-10-27 03:43:34 -04:00
Dan Stillman
ff3a74064b PDF reader: Add "Page" to rotate menu options for clarity 2022-10-27 03:41:28 -04:00
Martynas Bagdonas
454a2c186b Add rotation options to Edit menu to rotate the current PDF page
(cherry picked from commit d8d6054927)
2022-10-27 03:39:56 -04:00
Martynas Bagdonas
03ba306018 Reduce loaded tabs limit if the system has 8 GB or less memory 2022-10-27 03:01:42 -04:00
Adomas Venčkauskas
ce3266e036 Update SingleFile. Closes #2880 2022-10-25 16:02:22 +03:00
Adomas Venčkauskas
0d1b194b6b Add an integration test for citation merging 2022-10-25 14:50:22 +03:00
Adomas Venčkauskas
19558a425b Fix wrong given name disambiguation after editing author for citeproc-js
Closes #2870
2022-10-25 14:50:05 +03:00
Adomas Venčkauskas
a28908f0b4 Change integration test citation style to APA and some refactoring 2022-10-25 14:50:05 +03:00
Adomas Venčkauskas
87a567122e Fx102: Fix Integration tests 2022-10-25 13:48:39 +03:00
Adomas Ven
ee67c848d7 Adds support for merging adjacent citations (#2875) 2022-10-25 13:19:14 +03:00
Abe Jellinek
93666d310e Zotero.PreferencePanes: Fix shutdown observer error (#2845)
`this` referred to the observer instead of Zotero.PreferencePanes, so
`this.pluginPanes.length` caused an error and plugin panes were not removed.
2022-10-16 16:06:22 -04:00
Abe Jellinek
ccc94e7b45 fx-compat: Add stylesheets parameter to PreferencePanes.register() (#2845)
And just fully reload the preferences window when the pane array changes. The
preferences window won't often be open when a plugin is enabled or disabled,
considering that the Add-ons window is external to the preferences, and trying
to add/remove panes dynamically without reloading brings lots of bugs.
(No way to dynamically remove a script, for one.)
2022-10-16 16:06:05 -04:00
Abe Jellinek
f81a81cb74 fx-compat: Preferences: Activate <?xml-stylesheet?>s, default to XUL (#2845) 2022-10-16 16:05:51 -04:00
Abe Jellinek
c1bb910d1c
Clear sync error and start sync after logging in in prefs (#2802)
Also fixes an existing error due to an argumentless call to
Zotero.Sync.Runner.updateIcons() in ZoteroPane.
2022-10-16 15:47:54 -04:00
Dan Stillman
f9a0622c30 Merge new English strings 2022-10-13 02:20:42 -04:00
Dan Stillman
ac165cfc14 Update note-editor and pdf-reader submodules 2022-10-13 02:20:42 -04:00
Dan Stillman
961e5b955d Default to UTF-8 when indexing text file without detected charset
https://forums.zotero.org/discussion/94637/indexing-of-markdown-plain-text-attachments-with-md-extension
2022-10-13 02:20:42 -04:00
Martynas Bagdonas
81c6c8deff Add annotation update test to pdf-reader tests 2022-10-13 02:20:42 -04:00
Dan Stillman
23a6af128b Change connector server response to "Zotero is running"
People are confused by "Zotero Connector Server is Available". I'm not
sure if this will be any better, but not mentioning the connector might
help -- that seems to be part of the problem.

We could display a longer message with a link to
https://www.zotero.org/support/kb/connector_zotero_unavailable, but this
is the /ping page that gets hit constantly, so it seems like we should
keep it short (though probably it doesn't make a difference).
2022-10-13 02:20:42 -04:00
Abe Jellinek
bde157b085
fx-compat: Automatically register plugin l10n sources (#2863)
Fixes #2837
2022-10-11 11:59:33 -04:00
Abe Jellinek
367090614d fx-compat: Fix File -> Save... in basicViewer
Printing is still broken with no clear fix - PrintUtils really wants a
tabbrowser.
2022-10-11 10:47:15 -04:00
Abe Jellinek
f030190fb7 "Swap First/Last" in creator transform menu
https://github.com/zotero/zotero/pull/2801#issuecomment-1274107763
2022-10-11 10:30:53 -04:00
Abe Jellinek
568b88e342
Add "Capitalize" text transform to creator context menu (#2801) 2022-10-11 01:28:27 -04:00
Abe Jellinek
9be51a5cb0
Fix last editpane tab being misaligned vertically (#2864) 2022-10-10 21:47:20 -04:00
Dan Stillman
7276223a90 Tweak text in LABD auto-relinking dialogs (#2374, #2092) 2022-10-10 10:38:53 -04:00
Abe Jellinek
5f9e8f5b7e Automatically relink attachments from LABD (#2374)
Fixes #2092
2022-10-10 10:38:43 -04:00
Martynas Bagdonas
ecd0e50ac4 Tweak pdf-reader annotation creation test 2022-10-10 17:06:00 +03:00
Martynas Bagdonas
3a26f6eb6f Add pdf-reader annotation creation test
(cherry picked from commit af436d34a8)
2022-10-10 16:56:17 +03:00
Martynas Bagdonas
8db82c1022 Don't allow to rotate or delete pages for read-only PDF
(cherry picked from commit 29dd0cf5dc)
2022-10-10 16:56:17 +03:00
Martynas Bagdonas
35cbbeeea4 Fix annotation image saving to cache for read-only annotations
(cherry picked from commit 28329aa785)
2022-10-10 16:56:17 +03:00