mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix annotation image saving to cache for read-only annotations

Browse source 
(cherry picked from commit 28329aa785)
This commit is contained in:
Martynas Bagdonas 2022-10-06 17:32:51 +03:00
parent b851e66ec8
commit 35cbbeeea4
1 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
chrome/content/zotero/xpcom/reader.js
View file

@ -1034,19 +1034,22 @@ class ReaderInstance {
saveOptions.notifierData.autoSyncDelay = Zotero.Notes.AUTO_SYNC_DELAY;
}
if (annotation.image && this._isReadOnly()) {
let item = Zotero.Items.getByLibraryAndKey(attachment.libraryID, annotation.key);
if (item) {
let blob = this._dataURLtoBlob(annotation.image);
await Zotero.Annotations.saveCacheImage(item, blob);
}
}
// Delete authorName to prevent setting annotationAuthorName unnecessarily
delete annotation.authorName;
let savedAnnotation = await Zotero.Annotations.saveFromJSON(attachment, annotation, saveOptions);
if (annotation.image) {
let item = Zotero.Items.getByLibraryAndKey(attachment.libraryID, annotation.key);
// If annotation isn't editable, only save image to cache.
// This is the only case when saving can be triggered for non-editable annotation
if (annotation.image && item && !item.isEditable()) {
let blob = this._dataURLtoBlob(annotation.image);
await Zotero.Annotations.saveCacheImage(savedAnnotation, blob);
await Zotero.Annotations.saveCacheImage(item, blob);
}
// Save annotation, and save image to cache
else {
// Delete authorName to prevent setting annotationAuthorName unnecessarily
delete annotation.authorName;
let savedAnnotation = await Zotero.Annotations.saveFromJSON(attachment, annotation, saveOptions);
if (annotation.image) {
let blob = this._dataURLtoBlob(annotation.image);
await Zotero.Annotations.saveCacheImage(savedAnnotation, blob);
}
}
}
}