Commit graph

11623 commits

Author SHA1 Message Date
Martynas Bagdonas
425daa3622 Make pdf-reader read-only when item is in trash or read-only group 2021-06-25 19:21:39 +03:00
Dan Stillman
b8ad18e96d Fix broken detection after error loading a translator's code
The bug fixed in bde9a74f9d was triggering an error getting code for a
deleted search translator, which due to this bug caused a double
complete() call that got detection all out of sync, which caused some
search translators to be skipped, which resulted in ISBN lookup
failures.
2021-06-25 06:49:54 -04:00
Dan Stillman
bde9a74f9d Clear caches properly when deleting duplicate translator
Among other things, if the name of a translator was changed, until
restart Zotero.Translators.getAllForType() would return the old cache
entry pointing to a file that no longer existed.
2021-06-25 06:49:18 -04:00
Adomas Venčkauskas
3199d23d09 Fix word plugin state display in the Pref dialog 2021-06-25 10:36:45 +03:00
Martynas Bagdonas
d9eb45bf0e Don't show note-editor replace bar by default, rename input to "Replace"
Fixes #2107
2021-06-24 13:53:40 +03:00
Dan Stillman
f80ba89971 Massively speed up tests
- Make a copy of the database after first initialization that can be
  swapped in when reinitializing in resetDB()
- Avoid unnecessary one-second delay on every reset

Probably more that can be done, but this should take minutes off the
test runs
2021-06-24 06:10:40 -04:00
Martynas Bagdonas
88280641ac Avoid setTimeout call on every note-editor context menu popup
Fixes #2111
2021-06-24 11:32:43 +03:00
Dan Stillman
3fc7ce8e7d Update locales from Transifex and merge new English strings 2021-06-23 22:06:31 -04:00
Dan Stillman
9327819895 Merge pull request #2052 from mrtcode/spell-checker
Spell checker
2021-06-23 21:58:05 -04:00
Dan Stillman
a6172ff9e8 Use Lucida in $font-family-base SCSS variable (currently unused) 2021-06-23 21:56:11 -04:00
Martynas Bagdonas
e3758dc581 Delay popup with spell checker initialization to fix missing checkmark 2021-06-23 21:56:11 -04:00
Dan Stillman
9a7016ad64 Spell checker improvements
- Add/Remove Dictionaries window
- Better account for the (unlikely) possibility that a dictionary could
  be replaced by another more popular dictionary provided by a different
  extension id (tested)
- Better account for the (very unlikely) possibility that an extension
  could bundle multiple dictionaries (untested)
- Use toolkit version comparator for proper extension version
  comparisons
- Localize strings
- Add tests for updating
2021-06-23 21:56:11 -04:00
Dan Stillman
7f2296b1fb Tweak a couple error messages for HTTP.BrowserOfflineException 2021-06-23 21:56:11 -04:00
Dan Stillman
1e2ad01f99 Zotero.File.download(): Throw error on non-200 response 2021-06-23 21:56:07 -04:00
Martynas Bagdonas
814cbc0ee3 Introduce spell checker context menu and dictionaries managing 2021-06-23 19:25:46 -04:00
Dan Stillman
a2f3743152 Update pdf-reader submodule 2021-06-22 18:45:38 -04:00
Dan Stillman
02db8e620e Update locales from Transifex and merge new English strings 2021-06-22 16:06:04 -04:00
Martynas Bagdonas
ac47578a7b Add an option to remove previously set annotation colors in note-editor
Fixes #2106
2021-06-22 12:25:45 +03:00
Martynas Bagdonas
6c16d7625a Redesign find-replace bar 2021-06-22 09:34:37 +03:00
Dan Stillman
5c5b3c8565 Updates locales from Transifex and merge new English strings 2021-06-22 01:24:09 -04:00
Dan Stillman
00a0231e4f Remove "\n" from localized string for note annotation header
Follow-up to 47f897fe8c
2021-06-22 01:13:17 -04:00
Dan Stillman
91ebbc1bc9 Changes to colored tag toggling via keyboard
- Update Date Modified when toggling tags via keyboard
  (https://forums.zotero.org/discussion/90371/bug-toggling-a-colored-tag-with-number-keys-doesnt-update-date-modified)
- If any selected items don't have the tag, add it to all items, instead
  of deciding based on the first item
  (https://forums.zotero.org/discussion/79900/minor-issue-related-to-colored-tags)
2021-06-22 01:01:51 -04:00
Dan Stillman
42b4b173f3 Store lastCompatibleVersion during schema initialization
Otherwise switching back to release from beta doesn't show the last-used
version if the beta hasn't gone through at least one
compatibility-breaking schema update.
2021-06-21 01:16:18 -04:00
Abe Jellinek
e285415451
Make resolveURL available to translators (#2101) 2021-06-18 15:18:44 -04:00
Martynas Bagdonas
47f897fe8c Use two lines for extracted annotation header and fix title extraction
Fixes #2095
2021-06-18 13:03:25 +03:00
Martynas Bagdonas
b5edc0d9c1 Reorganize note-editor toolbar 2021-06-17 14:07:09 +03:00
Dan Stillman
7a4b27e774
Merge pull request #2071 from jryans/feed-processor
Import feed processor
2021-06-17 03:27:36 -04:00
J. Ryan Stinnett
eaa01901ef Wire up new feed processor to Zotero's feed reader
This connects the new feed processor to Zotero's existing feed reader. The new
feed processor assumes a content window environment, so a sandbox in a parent
window is used to load it.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
2bd4904ead Add DOMParser-based XML reader
This adds a `DOMParser`-based XML reader which emits events like a SAX XML
reader for compatibility with the feed processor.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
29ebaa5ec6 Assume fetch-based API for feed processsing
This converts the feed processor to expect a `fetch`-based API instead of an
XPCOM stream.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
1d93296481 Convert feed processor to HTML attribute manipulation
This moves the feed processor away from custom XPCOM SAX attributes and over to
standard HTML attribute map APIs.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
891ba599a6 Convert feed processor parsing to native DOM APIs
This uses native DOM APIs to create document fragments and parse content instead
of XPCOM utils.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
b4303eaa45 Absorb feed processor types from interface
This moves the type constants into code, rather than pulling them from an XPCOM
interface.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
a0694cd8fb Convert feed processor type checks away from XPCOM
This converts the type checks for arrays and interfaces to use native JS
approaches instead of XPCOM.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
a3e6f96289 Remove MIME type description feature from feed processor
This removes the feed processor's feature of converting enclosure MIME types to
a textual type description. This is not used by Zotero and removes an XPCOM
dependency.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
af6029b854 Convert feed processor to native URLs 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
be80598c6b Convert feed processor data away from XPCOM
This changes the feed processor XPCOM array and property bags to native arrays
and objects.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
75eb8c51d4 Ignore feed processor *.idl files 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
bea3b3d3b2 Remove unimplemented registerExtensionPrefix API 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
9d0e1932dc Convert feed processor structure away from XPCOM
This changes the various components to invoke each other directly as regular
objects without involving XPCOM.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
e120ca7395 Align variable style in feed processor
This tweaks variable naming and related details to match Zotero conventions.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
76873bda95 Approaching readable code in feed processor
This adjusts bracing style and other aesthetics to match Zotero conventions.
2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
a210f1fbde More style alignment for feed processor 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
088483b776 Fix lint issues in feedReader.js 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
bc4aafa8e4 Add feed reader tests for parsing behavior
This adds extra tests to check parsing behavior such as entities, tag handling,
CDATA, etc. This will help ensure the new feed processor matches the previous
behavior.
2021-06-16 20:59:57 +01:00
Tom Najdek
f1414731da
Blur active field in switchCreatorMode #2087 (#2088) 2021-06-14 17:33:55 -04:00
Abe Jellinek
f83559feb8
Correct creator fields in OpenURL (#2079)
There is no isInstitution field, so OpenURL search was producing invalid
data for items with institutional authors. Instead we use the name field
in API JSON and the isInstitution flag in internal JSON.
2021-06-14 14:49:49 -04:00
qqobb
5359db39d0
Run JavaScript: Improve await regex (#2083)
Tests: https://regex101.com/r/eQYCIp/1
2021-06-12 02:44:39 -04:00
Tom Najdek
864b135da4
Mendeley import: Simplify filename logic #2067 (#2085) 2021-06-11 13:35:09 -04:00
Martynas Bagdonas
3584853f39 Fix annotations test 2021-06-09 18:12:05 +03:00