mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
6734 commits 9 branches 364 tags 290 MiB
Commit graph

4431 commits

Author SHA1 Message Date
Dan Stillman
a85a9a632e Decrease right-padding of middle button by 1px on OS X 2015-02-22 06:46:07 -05:00
Dan Stillman
1069b483cc Fix toolbar buttons on Linux 
Known issues:

- The dropmarker segment doesn't get a background highlight color on
  hover. And now you'll notice. Sorry.
 2015-02-22 06:46:07 -05:00
Aurimas Vinckevicius
7e67a34444 [WebPageDump] Fix regression from 5f8b56ef86 2015-02-21 21:51:01 -05:00
Aurimas Vinckevicius
7d70cc5886 [WebPageDump] Fix regression from 5f8b56ef86 2015-02-21 20:35:39 -06:00
Aurimas Vinckevicius
66eb40da32 [WebPageDump] More verbose log messages 
Log full error stack
 2015-02-21 20:32:45 -06:00
Dan Stillman
3089685b33 Fix display of some startup errors in toolbar icon tooltip 2015-02-21 20:34:25 -05:00
Dan Stillman
9a87f15956 Toolbar button overhaul 
The address bar icon now lives in a new combo buttonset containing the main Z, "Save to Zotero", and a dropmarker for the former save-icon right-click menu (which we could conceivably use more heavily going forward now that it's more accessible). There's also a separate dedicated Save to Zotero (+ dropmarker) button, not shown by default, that can be swapped in for people who don't want the Z.

The tooltip for the save icon also now shows the keyboard shortcut (though that unfortunately makes for a lot of parentheses).

Known issues:

- Untested on ESR
- Untested on Linux
- Might need refinement on Windows
- Weird 1px horizontal area at bottom of save button that highlights dropmarker (at least on OS X)
- Probably needs a third button option with just the Z icon so that the main button and the save button can be placed separately (e.g., save button in toolbar, Z in panel)
- Combo buttonset needs an inactive single-icon state for the palette and either needs a state for the panel (which might need to span all three columns?) or if possible should just move the other two icons in and put itself back in the palette
- The absurd amount of time and CSS it took to get the toolbar icons looking right on OS X, since apparently no one has put a menu-button inside a combined toolbar button before
 2015-02-21 04:16:34 -05:00
Dan Stillman
ba2a16531b Add "Show Item in Library" button to note-too-long window 
TODO: other too-long errors
 2015-02-19 17:44:35 -05:00
Dan Stillman
110bf42e5f Click a button in the sync error panel should close the panel 2015-02-19 17:07:48 -05:00
Dan Stillman
629f4b3cc5 Make Zotero.Error instanceof Error, and give a less ugly name 2015-02-19 17:06:59 -05:00
Dan Stillman
88d22601d7 Fix error saving from translator context menu (from aaeb2cec) 2015-02-19 01:29:06 -05:00
Aurimas Vinckevicius
f5cd54620b Discard redundant tags in translator tester 
Zotero would discard these anyway when writing to DB. So this makes for more appropriate test cases
 2015-02-18 22:39:04 -06:00
Dan Stillman
424ee72f58 Additional icon changes 
- Add high-res webpage icon
- Show webpage icon in grayscale when no translator (except on hover, for fun)
- Remove pre-Australis icons
- Switch to CustomizableUI API for toolbar icon
- Move icon generation code to separate file
- Add Zotero.hiRes flag for Retina/etc. displays (available only after a window
  has loaded)

Known issues:

- While the gray is mostly to be less distracting, the gray/color distinction
  will probably be lost on most people. A separate guidance panel for the gray
  icon might help.
- On pages with frames, the webpage icon appears first and then is replaced
  with a translator icon.
 2015-02-18 17:10:19 -05:00
Aurimas Vinckevicius
7b621420f7 Fix possible infinite loops 2015-02-17 22:12:52 -06:00
Dan Stillman
aaeb2cec9d Show address bar icon on all web pages in Firefox 
The icon now will save using a translator if possible and otherwise fall back
to creating a web page item. This also removes the "Create Web Page Item from
Current Page" button.

Let's see how this feels. (Pushing it to the beta so more people can try it.) I
think we ultimately should do this, but my main concern with this
implementation is that it's just too distracting, since the icon disappears and
reappears on every page. A persistent, possibly monochrome icon that was just
sometimes disabled (as is the case for the Firefox bookmark toolbar icon) might
be better.

Regardless of the approach, there are some follow-up tweaks that should be made:

- The same thing in the connectors
- Context-menu options
- Different icons and descriptions for different file types (PDF, image)?
- Adjust guidance text? Have separate guidance panels for web vs. translation?
 2015-02-17 03:43:45 -05:00
Dan Stillman
47a062c9a8 Fix potential infinite loop dragging large HTML notes 2015-02-17 01:39:40 -05:00
Dan Stillman
42c55ee5f3 Fix file sync error with filenames containing slashes 
These shouldn't exist, but something either didn't used to or still isn't
protecting against them, so strip them in getFile().
 2015-02-16 17:26:51 -05:00
Simon Kornblith
64f7710877 Merge pull request #409 from aurimasv/cookies 
Manage cookies received from other hosts.
 2015-02-14 13:24:58 -05:00
Dan Stillman
161733b207 Merge pull request #630 from aurimasv/attach-url 
Don't try to parse path if it looks like a web URL
 2015-02-11 01:22:39 -05:00
Dan Stillman
884132ac8b Merge pull request #629 from aurimasv/varDump-exception 
Handle XPCOM Exceptions in varDump
 2015-02-11 01:18:48 -05:00
Dan Stillman
62aa5acc0d Fix NO_INTERFACE console error after itembox/tagsbox edit in Fx36 
In Fx36+, QIing the scrollbox to nsIScrollBoxObject throws NO_INTERFACE,
presumably because https://bugzilla.mozilla.org/show_bug.cgi?id=364612
was implemented in some other ticket.
 2015-02-10 22:45:51 -05:00
Aurimas Vinckevicius
cae9a89b9d Fix syntax error in varDump 2015-02-10 21:26:50 -06:00
Simon Kornblith
aeada8032c Fix XML-based import, export, and search translators on Firefox 36 2015-02-10 22:01:52 -05:00
Aurimas Vinckevicius
264e1f8835 Don't try to parse path if it looks like a web URL 
Also, cleaner parsing messages
 2015-02-10 20:50:08 -06:00
Aurimas Vinckevicius
8e25a4bdf3 Handle XPCOM Exceptions in varDump 2015-02-10 20:49:16 -06:00
Dan Stillman
1afa1ffea6 Update submodules, repotime, and versions 2015-02-10 00:13:42 -05:00
Dan Stillman
a98e6ab4fb Merge pull request #627 from aurimasv/connector-double-proxy 
Don't proxify proxied hosts
 2015-02-09 04:57:47 -05:00
Dan Stillman
f7a2ef6698 Merge pull request #614 from aurimasv/file-attachments 
Allow file paths to be specified in attachment.url
 2015-02-09 04:49:42 -05:00
Aurimas Vinckevicius
82998e986e Don't proxify proxied hosts 2015-02-09 00:57:56 -06:00
Aurimas Vinckevicius
ed2b6ccec3 Don't promote attachment.url to attachment.path 
...but allow demoting from path to url if necessary.
 2015-02-04 03:20:11 -06:00
Aurimas Vinckevicius
cf9ec26eb4 Disallow attachment.path in web/search translators 2015-02-04 02:54:13 -06:00
Dan Stillman
424af025b3 Merge pull request #608 from COV-Steve/4.0 
Fix for OpenURL 0.1 resolver detection
 2015-02-03 22:28:17 -05:00
Aurimas Vinckevicius
27502a60b2 Disable expand/collapse shortcuts in coll. tree when in-line editing 2015-02-03 14:43:52 -06:00
Dan Stillman
3aaf9e341c Fix NO_INTERFACE error after entering tag in tags box 2015-02-03 15:36:01 -05:00
Dan Stillman
6f811cbbd0 Update submodules 2015-02-03 00:51:46 -05:00
Simon Kornblith
449086672c Fix #619, Retrieve metadata via Google Scholar broken in Firefox 31-34 2015-02-02 23:28:59 -05:00
Dan Stillman
496d4c5e77 Properly show saveURI errors in Zotero.Attachments.importFromURL() 2015-02-01 21:09:13 -05:00
Dan Stillman
f5c173b1e5 Fix saving files from translators 
(More breakage from 5f8b56ef8)
 2015-02-01 21:07:24 -05:00
Dan Stillman
fb8149e6db Clarify icon comment 2015-01-31 16:01:53 -05:00
Dan Stillman
bcacb79489 Fix remote file saving 
5f8b56ef8 was so many different kinds of broken
 2015-01-31 15:23:58 -05:00
Frank Bennett
5cfe4db098 Use nav-bar as target ID for Zotero nav bar icon 
The statusBarIcon pref is retained to maintain state across
starts.
 2015-01-30 22:42:34 +09:00
Dan Stillman
f04b641f3c Merge pull request #617 from aurimasv/content-handler 
Content handlers
 2015-01-30 04:09:03 -05:00
Dan Stillman
d8f2d4b268 Merge branch 'fx36-saveURI' into 4.0 2015-01-30 03:56:58 -05:00
mizu
5f8b56ef86 Fix saveURI() in Firefox 36+ 2015-01-30 03:55:35 -05:00
Dan Stillman
783ba4a0b7 Merge pull request #618 from aurimasv/prefs-unicode 
Retrieve unmangled unicode strings from preferences
 2015-01-30 03:42:34 -05:00
Aurimas Vinckevicius
ab7fc1614d Fix bug in collectionTreeView that caused tree row loss 
...when collapsing/expanding group libraries
 2015-01-29 19:31:55 -06:00
Aurimas Vinckevicius
d98a79c33f Fix typo in item field caching code 2015-01-29 19:31:54 -06:00
Aurimas Vinckevicius
9574e56ad6 Convert itemType to itemTypeID in itemTreeView.js, not items.js 
itemType comes from the column name in the tree view, so it makes most sense to do it there. Otherwise, Zotero was complaining about invalid field somewhere
 2015-01-29 19:31:54 -06:00
Dan Stillman
b0e37a38a2 Merge branch '4.0' 
Conflicts:
	chrome/content/zotero/xpcom/schema.js
	chrome/content/zotero/xpcom/translation/translate.js
	chrome/content/zotero/xpcom/zotero.js
	install.rdf
	update.rdf
 2015-01-29 19:59:47 -05:00
Dan Stillman
f2ffc30728 Merge pull request #607 from rmzelle/rename-style-panes 
Localize Style Editor and Preview and other improvements
 2015-01-28 22:57:10 -05:00
rmzelle
0be9e73b51 Further improvements to Style Editor and Preview 
* Clean up code (remove some pre-CSL 0.8.1 code, see also e32e6aa2f5 )
* Complete localization
* Save vertical space. Editor: remove "pre-wrap" wrapping, use smaller headers, add grippy to collapse CSL code. Preview: remove groupbox
 2015-01-28 22:20:20 -05:00
rmzelle
eec1ba4c73 Put JavaScript code from Style Editor and Preview into separate files 2015-01-28 22:20:20 -05:00
rmzelle
6fd3b298de Rename Reference Test and Preview panes 
* Also start localization of Zotero Style Preview
 2015-01-28 22:07:39 -05:00
Dan Stillman
276cd82fe4 Fix NO_INTERFACE error tabbing between fields 
Not sure why this is throwing, but I'm also not sure why it was
necessary in the first place
 2015-01-28 18:28:44 -05:00
Dan Stillman
8499ec6211 Allow extra data for single-object notifications to be passed directly 
Previous it had to be keyed by id (and still can be, but if there's only
a single id the notifier will now key it automatically)
 2015-01-28 17:25:17 -05:00
Dan Stillman
b785a3bfce Dynamically populate charsets table 
Instead of limiting charsets to a fixed list, dynamically populate it
with any charset name of less than 50 ASCII characters. Previously,
unknown charsets were discarded.

Zotero.Item.prototype.attachmentCharset now always returns a charset
name. It can be set with either a name or a charsetID.

Also:

- Remove the unused 'originalPath' column in itemAttachments
 2015-01-28 17:15:16 -05:00
Dan Stillman
b670084925 Use 'version' for groups instead of 'etag' 
APIv3 uses 'version'
 2015-01-28 17:05:25 -05:00
Dan Stillman
58c062dd06 Add per-library lastsync times and synced flags for sync delete logs 2015-01-28 15:56:46 -05:00
Dan Stillman
6199742986 Make attempt to read from an invalid DB column a fatal error 2015-01-28 15:56:46 -05:00
Aurimas Vinckevicius
5db52ac1c3 Add 'year' as a gettable field for Zotero.Item 2015-01-26 15:46:56 -06:00
Aurimas Vinckevicius
a0a656eac0 Allow setting a specific dateModified on item 
To be used in feed items to set the last _remote_ modification date
 2015-01-26 15:46:49 -06:00
Aurimas Vinckevicius
7f5555aab6 Inheritance-based Zotero.DataObjects 2015-01-26 15:46:49 -06:00
Aurimas Vinckevicius
707a65c63e Remove deprecated Zotero.Items.add 2015-01-26 15:46:49 -06:00
Dan Stillman
55d84bcbf3 Merge pull request #609 from aurimasv/retrieve-meta-max-pages 
Allow MAX_PAGES (for retrieving metadata) to be user-adjustable
 2015-01-21 01:01:47 -05:00
Aurimas Vinckevicius
e8e0f5e831 Bump MAX_PAGES to 15 
Re https://forums.zotero.org/discussion/45641/error-getting-metadata/#Item_10
 2015-01-20 23:58:41 -06:00
Aurimas Vinckevicius
11017b650c Retrieve unmangled unicode strings from preferences 2015-01-20 23:28:22 -06:00
Aurimas Vinckevicius
f7893ef400 Don't require Zotero restart to change RIS/BibTeX handling preference 2015-01-20 22:46:30 -06:00
Aurimas Vinckevicius
3f3666c972 Add Zotero.Prefs.registerObserver 
* Easier monitoring of preference changes
* Takes a preference name and a handler function that will be passed the new value of the preference
* Unregister observer via Zotero.Prefs.unregisterObserver with the same parameters
 2015-01-20 22:45:28 -06:00
Aurimas Vinckevicius
4ecdd55717 Continue with default if declining Zotero to handle RIS/BibTex/etc. 2015-01-20 21:54:05 -06:00
Aurimas Vinckevicius
8be83cedec Allow file paths to be specified in attachment.url 
In translators, it may not always be clear whether the given URI is a URL or a local file path.
Regression from 849803473a (that piece of code was introduced by me)
Re https://forums.zotero.org/discussion/45710/ris-import-from-endnote-mac-yosemite-to-zotero-standalone/
 2015-01-19 15:13:49 -06:00
Aurimas Vinckevicius
20444eceb7 Sanitize primary fields in setField before comparing to current value 2015-01-19 11:16:17 -06:00
Aurimas Vinckevicius
f0aae549c5 Allow bypassing library edit check when saving data objects 
Pass {skipEditCheck: true} option to .save()
 2015-01-19 11:16:17 -06:00
Aurimas Vinckevicius
efdc6f1230 Add loadAllData to Zotero.dataObject 
Useful when trying to duplicate items, which requires access to all data
 2015-01-19 11:16:17 -06:00
Aurimas Vinckevicius
84d8c17d6e Move erase to DataObject and make it modular 2015-01-19 11:16:16 -06:00
Aurimas Vinckevicius
cb56b9607d Move loadPrimaryData to Zotero.DataObject 2015-01-19 11:16:16 -06:00
Aurimas Vinckevicius
b83bc40426 Various fixes for Zotero.Item 2015-01-19 11:16:16 -06:00
Aurimas Vinckevicius
83187eaa35 Validate numeric field IDs 2015-01-19 11:16:16 -06:00
Aurimas Vinckevicius
adab8e45a7 Additional tweaks to DataObject & descendents to support inheritance 2015-01-19 11:16:15 -06:00
Aurimas Vinckevicius
442388304b Add Zotero.Libraries.isGroupLibrary 2015-01-19 10:37:22 -06:00
Aurimas Vinckevicius
9f535e0e91 Use Zotero.extendClass for inheritance 2015-01-19 10:37:22 -06:00
Aurimas Vinckevicius
a56e800d7c Add Zotero.localeCompare 
Can be used directly in Array.sort() as the sorting function.
Uses LocaleCollateion.compareString internally
 2015-01-19 10:37:21 -06:00
Aurimas Vinckevicius
9700cdde38 Add Zotero.extendClass 2015-01-19 10:37:21 -06:00
Aurimas Vinckevicius
f7220378dd Pass fixGaps to Zotero.Search.save() in an options object 2015-01-19 10:36:42 -06:00
Aurimas Vinckevicius
e02945b591 Add a centralized, modular .save() method to DataObject 
.save calls ._initSave(), _saveData(), _finalizeSave() internally passing `env` object to each to act as an environment for passing around variables
* _initSave should determine if the save is possible and return a promise for either `true` or `false`. It should also set up the environment, e.g. determine if this `isNew`
* _saveData performs the actual saving to the database, but should not do any terminal steps in the save process so that any extending classes could extend this method to write additional data to the database
* _finalizeSave should perform any finalization before the data is committed to the database.

_recoverFromSaveError is called with `env` and an error that occurred. This method should perform any recovery steps, e.g. discarding the save and reloading the item from the database into the cache.
 2015-01-19 10:36:42 -06:00
Aurimas Vinckevicius
56f244a4bb Add id and libraryID getters for all data objects 2015-01-19 10:36:42 -06:00
Aurimas Vinckevicius
4657c46d4b getClassForObjectType => getObjectsClassForObjectType 2015-01-19 10:36:41 -06:00
Aurimas Vinckevicius
c222a3248a Transition __defineGetter/Setter__ to Zotero.defineProperty 2015-01-19 10:36:41 -06:00
Aurimas Vinckevicius
f7d5ebc357 Default to "configurable: true" in defineProperty 2015-01-19 10:36:41 -06:00
Aurimas Vinckevicius
29e9946123 Allow to define properties for late initialization via defineProperty 2015-01-19 10:35:33 -06:00
Aurimas Vinckevicius
d4bd0ee811 Move defineProperty from ZU.Internal to Zotero 2015-01-19 10:31:39 -06:00
Aurimas Vinckevicius
869fdf61ae Make sure that there's always a title for a given URL 
E.g. https://read.amazon.co.uk/?asin=XXXXXXXXX was resulting in a blank title
 2015-01-18 10:41:17 -06:00
Aurimas Vinckevicius
79a79bb47a Fix typo in attachLink.xul 2015-01-18 10:40:12 -06:00
Simon Kornblith
06615f738f Tweak method for parsing XML without a window to handle UTF-8 properly 
Fixes issue reported at https://forums.zotero.org/discussion/45556
 2015-01-14 01:56:09 -05:00
Steve Jamieson
0d2a205110 Fix for OpenURL 0.1 resolver detection 
The discoverResolvers function was looking for the wrong XML tag name representing OpenURL version 0.1 in the response from the WorldCat Registry
 2015-01-13 14:20:57 -06:00
Simon Kornblith
7d19e17bb9 Ensure that we pass WebPageDump an XPCNativeWrapper 
Fixes some CSS issues in snapshots
 2015-01-13 01:51:03 -05:00
Dan Stillman
f1a3cb3577 Update versions, submodules, and repotime 2015-01-12 21:54:56 -07:00
Simon Kornblith
90625e8a05 Fix translators callback from translators on Fx 35 (affects COinS) 2015-01-12 19:33:12 -05:00
Simon Kornblith
5c76347674 Improve translation on Nightly (with e10s disabled) 
I haven't fully tested, but this fixes Google Scholar
 2015-01-12 11:27:39 -05:00
Simon Kornblith
e082a4fc28 Fix PDF metadata retrieval on Fx 35 2015-01-12 02:44:09 -05:00
Simon Kornblith
da7ee2ba26 Tweak sandboxing for Firefox 35 
Now we have to wrap cross-origin objects with a wrapper on the sandbox
side. Also, Function.prototype.apply.apply...
 2015-01-12 01:41:01 -05:00