Commit graph

13715 commits

Author SHA1 Message Date
Abe Jellinek
25d9524c6a
Fix editable-text expansion with non-overlay scrollbars on macOS (#3589) 2024-01-26 02:13:16 -05:00
windingwind
c21c5632c2
Fix attachment row annotation button bug (#3577) 2024-01-26 00:51:27 -05:00
Dan Stillman
9151fb3558 Force white background in quick-format dialog for now
To avoid unpleasantness in dark mode
2024-01-25 00:20:50 -05:00
Dan Stillman
f7fe38b94b Prevent overriding of quick-format selection background color for now 2024-01-25 00:08:35 -05:00
Dan Stillman
d116d8d0b7 Disable item-tags-box test for now
Failing in CI only
2024-01-25 00:00:25 -05:00
Dan Stillman
eb0988537e Update reader submodule 2024-01-24 23:32:24 -05:00
windingwind
63c532398b Fix sidenav default buttons display bug 2024-01-24 23:32:24 -05:00
windingwind
665f812bd1 Fix sidenav button visibilities update bugs 2024-01-24 23:32:24 -05:00
windingwind
7fe01d6c03 Clicking filename label should focus/blur field in attachment box 2024-01-24 23:32:24 -05:00
abaevbog
f990cb3f4b tabs menu updates
- CMD-F will focus the input field
- ArrowLeft/Right keypresses are ignored
- Reset focus index on the focus of the input field
2024-01-24 23:32:24 -05:00
Dan Stillman
69054bea4a Merge new English strings 2024-01-24 23:32:24 -05:00
abaevbog
1a82ae5c3b collection filter sizing tweaks
- ensure filter field is hidden if the pane is collapsed
- JS-based max-width setting to prevent overflow outside of collection pane
2024-01-24 23:32:24 -05:00
Abe Jellinek
608b732fbb Open tabs menu: Move margin/padding to SCSS 2024-01-24 23:32:24 -05:00
Abe Jellinek
873c87956c Open tabs menu: Escape regex special characters
So we don't throw an error/match inappropriately when the filter
contains backslashes, periods, pluses, and so on.
2024-01-24 23:32:24 -05:00
Abe Jellinek
a1134255ee Always rerender sidenav, even if item doesn't change
Feeds issue remains.
2024-01-24 23:32:23 -05:00
Abe Jellinek
2b50536775 Tweak method name 2024-01-24 23:32:23 -05:00
Dan Stillman
c2cc5e1935 Separate lines for extension-change confirmation into two strings 2024-01-24 23:32:23 -05:00
windingwind
4f73ea0cfa Fix attachment box rename 2024-01-24 23:32:23 -05:00
Abe Jellinek
3472d6cabe Prevent window overflow in Standard mode 2024-01-24 23:32:23 -05:00
Dan Stillman
613a907f3e Change pref from reader.useDarkModeForContent to reader.contentDarkMode 2024-01-24 23:32:23 -05:00
abaevbog
620b35ab78 minor focus tweaks
- after an item is added via "Add item by identifier" panel, end
focus to that item in itemTree.
- restored default behavior when the focus remains visible around an
element when all menupopups open, except for the item type menu in itemBox.
- opening item type menu will still hide the focus-ring
2024-01-24 23:32:23 -05:00
abaevbog
ed8e3f142b itempane keyboard navigation
- right/left arrows on section header expand/collapse the sections
- space/enter on section header toggle section collapsed/expanded
- tab from the header goes through the header's buttons and then
tabs into the section if that's opened
- arrow up/down on the header jumps to the previous/next header
- space/enter on clickable elements simulate a click
- if there is a pinned section, tab from the title will focus its header
2024-01-24 23:32:23 -05:00
Dan Stillman
580d1df086 Use red Z for 16x16 icon in Windows .ico 2024-01-24 23:32:23 -05:00
windingwind
3bdcf34a89 Fix stacked mode layout when toggle item pane 2024-01-24 23:32:23 -05:00
windingwind
8aa77fd5c8 Fix item pane splitter style 2024-01-24 23:32:23 -05:00
windingwind
7f58873e0b Fix item pane size when switching to note in stacked mode 2024-01-24 23:32:23 -05:00
Abe Jellinek
f59ee25fd7 Remove extra textarea padding on all platforms 2024-01-24 23:32:22 -05:00
Abe Jellinek
d375b1c78b editable-text: Use minimal scrollbars everywhere 2024-01-24 23:32:22 -05:00
Abe Jellinek
1159f9b54c Update reader submodule 2024-01-24 23:32:22 -05:00
Dan Stillman
1d8baa635a New app icons 2024-01-24 23:32:22 -05:00
Tom Najdek
ccfc3127ba Tweak padding in the tag selector list 2024-01-24 23:32:22 -05:00
Dan Stillman
61cca0fc69 Use Fluent instead of DTD for "Use Dark Mode for Content" string 2024-01-24 23:32:22 -05:00
abaevbog
11fc1ebd8e remove "Go to this item online" tooltip from url field in itembox
Also:

- set the .tooltiptext for options button in fluent file, so that text
shows up on hover
- added tooltiptext to creator + and - buttons
2024-01-24 23:32:22 -05:00
Abe Jellinek
b8f2aaafa9 Attachment preview: Fix cut-off snapshots
Also:
- Prevent selecting any text within the snapshot
2024-01-24 23:32:22 -05:00
Abe Jellinek
832a6f3eff Fix right-click -> Merge Items... 2024-01-24 23:32:22 -05:00
Abe Jellinek
0d0aee559b Update reader submodule 2024-01-24 23:32:22 -05:00
Dan Stillman
db4d7d5838 Fix recognizeDocument test failures
Wait for all progress-queue rows to be done processing before moving on
to the next test. Without this, preview rendering or other operations
can cause test failures by delaying the `ZoteroPane.selectItems()` call
for the new parent item in `_processItem()` until the middle of a
following test (due to the await for file renaming [1]). If it's delayed
until after the next attachment has been created, the previous parent
item will be selected after the new attachment and `recognizeSelected()`
in the test won't work. This is most pronounced with the reader, but it
was apparently happening previously due to something else, hence the
explicit item selection (now removed) in one test.

[1] 21e50add60/chrome/content/zotero/xpcom/recognizeDocument.js (L289-L301)
2024-01-24 23:32:22 -05:00
windingwind
0cd7a52dc0 Fix attachment preview retry and error catch 2024-01-24 23:32:21 -05:00
windingwind
1c343ee820 Fix viewItem unnecessary scroll 2024-01-24 23:32:21 -05:00
windingwind
86947d7154 Remove attachment-preview-box 2024-01-24 23:32:21 -05:00
windingwind
6ac35a580f Fix attachment info indexed label padding 2024-01-24 23:32:21 -05:00
Abe Jellinek
3ac8f803c9 Fix duplicate creator context menus, extract utility function 2024-01-24 23:32:21 -05:00
Abe Jellinek
a0ab7783ee Remove explicit delay in tag update test 2024-01-24 23:32:21 -05:00
Abe Jellinek
b9deeb1b15 Fix tooltip coloring 2024-01-24 23:32:21 -05:00
Abe Jellinek
f468245caf Attachments box: Don't set this._item to non-regular item
Fixes occasional errors due to `getAttachments()` being called on a
non-regular item in `updateCount()`.
2024-01-24 23:32:21 -05:00
Martynas Bagdonas
c208325aeb Add menu option to toggle dark mode for reader content 2024-01-24 23:32:21 -05:00
Abe Jellinek
c549a96834 Restore notes-box add button 2024-01-24 23:32:21 -05:00
Tom Najdek
03be35426c Couple of small fixes to the tag selector
* Add bottom padding
* Increase padding for macOS 0-width scrollbars
2024-01-24 23:32:21 -05:00
Tom Najdek
71d6e219bd Switch to .svg spinner icon for the PDF metadata retrieval 2024-01-24 23:32:21 -05:00
windingwind
ee514f2fd5 Fix window control buttons on KDE 2024-01-24 23:32:20 -05:00