mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

load all tabs items' data when restoring tab state (#5193)

Browse source 
This fixes the breakage in tabs menu on initial load
if one of the tab is for an item from not-loaded group.
Now, every component relying on tab items (e.g. tabs menu)
can just assume that items are all loaded.

Fixes: #5192
This commit is contained in:
abaevbog 2025-04-08 19:42:56 -07:00 • committed by Dan Stillman
parent bfe28b5918
commit 79feeaecb1
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
chrome/content/zotero/tabs.js
View file

@ -228,7 +228,8 @@ var Zotero_Tabs = new function () {
});
};
this.restoreState = function (tabs) {
this.restoreState = async function (tabs) {
let itemIDs = [];
for (let i = 0; i < tabs.length; i++) {
let tab = tabs[i];
if (tab.type === 'library') {
@ -250,11 +251,17 @@ var Zotero_Tabs = new function () {
data: tab.data,
select: tab.selected
});
itemIDs.push(tab.data.itemID);
}
}
}
// Unset the previously selected tab id, because it was set when restoring tabs
this._prevSelectedID = null;
// Some items may belong to groups that are not yet loaded. Load them here so that
// every component related to tabs (e.g. tabs menu) does not have to handle
// potentially not-yet-loaded items.
let items = await Zotero.Items.getAsync(itemIDs);
await Zotero.Items.loadDataTypes(items);
};
/**