mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

include mru types in main list of "New Item" menu (#5195)

Browse source 
Per https://forums.zotero.org/discussion/123269/bad-practice-in-new-item-drop-down-menu
This commit is contained in:
abaevbog 2025-04-08 19:40:07 -07:00 • committed by Dan Stillman
parent 730d3b1f34
commit bfe28b5918
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
chrome/content/zotero/zoteroPane.js
View file

@ -699,15 +699,18 @@ var ZoteroPane = new function()
localized: Zotero.ItemTypes.getLocalizedString(type.id)
};
});
let allItemTypes = [...primaryItemTypes, ...secondaryItemTypes];
var collation = Zotero.getLocaleCollation();
primaryItemTypes.sort(function (a, b) {
return collation.compareString(1, a.localized, b.localized);
});
secondaryItemTypes.sort(function (a, b) {
allItemTypes.sort(function (a, b) {
return collation.compareString(1, a.localized, b.localized);
});
let lastPrimaryType = primaryItemTypes[primaryItemTypes.length - 1];
let itemTypes = primaryItemTypes.concat(secondaryItemTypes);
// The array of all item types with MRU prepended to the top
let itemTypes = primaryItemTypes.concat(allItemTypes);
for (let itemType of itemTypes) {
let menuitem = document.createXULElement("menuitem");
menuitem.setAttribute("label", itemType.localized);
@ -718,7 +721,7 @@ var ZoteroPane = new function()
});
addMenu.appendChild(menuitem);
// Add a separator between primary and secondary types
if (lastPrimaryType.id == type) {
if (addMenu.childElementCount == primaryItemTypes.length) {
let separator = document.createXULElement("menuseparator");
addMenu.appendChild(separator);
}