Scaffold: Don't use cookie sandbox by default

Instead, just set an empty cookie sandbox when running tests without
"Remember cookies" enabled. The cookie sandbox doesn't remember cookies
set in JS, which breaks some sites in the Scaffold browser.

https://forums.zotero.org/discussion/114239/z7-beta77-scaffold-bugs-report
This commit is contained in:
Abe Jellinek 2024-05-07 15:11:03 -04:00
parent 19ab6b6643
commit 634e27c621

View file

@ -54,7 +54,6 @@ function fix2028(str) {
var Scaffold = new function () {
var _browser;
var _cookieSandbox;
var _translatorsLoadedPromise;
var _translatorProvider = null;
var _lastModifiedTime = 0;
@ -80,7 +79,6 @@ var Scaffold = new function () {
this.onLoad = async function (e) {
if (e.target !== document) return;
_browser = document.getElementById('browser');
_cookieSandbox = new Zotero.CookieSandbox(_browser);
window.messageManager.addMessageListener('Scaffold:Load', ({ data }) => {
document.getElementById("browser-url").value = data.url;
@ -1932,10 +1930,7 @@ var Scaffold = new function () {
_debug,
_translatorProvider
);
if (rememberCookies) {
tester.setCookieSandbox(_cookieSandbox);
}
else {
if (!rememberCookies) {
tester.setCookieSandbox(new Zotero.CookieSandbox());
}
tester.setTests(testsOfType);