From 634e27c62132174cac0afca7c6c546e5b6d705eb Mon Sep 17 00:00:00 2001
From: Abe Jellinek <jellinek@berkeley.edu>
Date: Tue, 7 May 2024 15:11:03 -0400
Subject: [PATCH] Scaffold: Don't use cookie sandbox by default

Instead, just set an empty cookie sandbox when running tests without
"Remember cookies" enabled. The cookie sandbox doesn't remember cookies
set in JS, which breaks some sites in the Scaffold browser.

https://forums.zotero.org/discussion/114239/z7-beta77-scaffold-bugs-report
---
 chrome/content/scaffold/scaffold.js | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/chrome/content/scaffold/scaffold.js b/chrome/content/scaffold/scaffold.js
index 7538eefeb7..6e8f7e73a5 100644
--- a/chrome/content/scaffold/scaffold.js
+++ b/chrome/content/scaffold/scaffold.js
@@ -54,7 +54,6 @@ function fix2028(str) {
 
 var Scaffold = new function () {
 	var _browser;
-	var _cookieSandbox;
 	var _translatorsLoadedPromise;
 	var _translatorProvider = null;
 	var _lastModifiedTime = 0;
@@ -80,7 +79,6 @@ var Scaffold = new function () {
 	this.onLoad = async function (e) {
 		if (e.target !== document) return;
 		_browser = document.getElementById('browser');
-		_cookieSandbox = new Zotero.CookieSandbox(_browser);
 
 		window.messageManager.addMessageListener('Scaffold:Load', ({ data }) => {
 			document.getElementById("browser-url").value = data.url;
@@ -1932,10 +1930,7 @@ var Scaffold = new function () {
 					_debug,
 					_translatorProvider
 				);
-				if (rememberCookies) {
-					tester.setCookieSandbox(_cookieSandbox);
-				}
-				else {
+				if (!rememberCookies) {
 					tester.setCookieSandbox(new Zotero.CookieSandbox());
 				}
 				tester.setTests(testsOfType);