mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Get attachment text on-demand if not cached in Item::attachmentText

Browse source 
Follow-up to 58f515058 with a better approach: if no full-text cache
file, just get text directly without indexing. In the one existing use
of `attachmentText`, attachment merging, this is better anyway, because
we might be deleting the file, so there's no point wasting time
inserting words into the database.
This commit is contained in:
Dan Stillman 2022-03-12 20:17:13 -05:00
parent 46ff3cf4fb
commit 3ec883a7f6
4 changed files with 54 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/tests/itemsTest.js
View file

@ -474,7 +474,7 @@ describe("Zotero.Items", function () {
assert.isTrue(attachment2.deleted);
});
it.skip("should merge identical attachments based on content hash when unindexed", async function () {
it("should merge identical attachments based on content hash when unindexed", async function () {
let item1 = await createDataObject('item');
let attachment1 = await importPDFAttachment(item1);