mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add pending test for merging items with unindexed attachments by content

Browse source 
Follow-up to 58f51505
This commit is contained in:
Dan Stillman 2022-03-12 19:09:23 -05:00
parent 58f5150583
commit 46ff3cf4fb
1 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
test/tests/itemsTest.js
View file

@ -473,8 +473,30 @@ describe("Zotero.Items", function () {
assert.isTrue(item2.deleted);
assert.isTrue(attachment2.deleted);
});
it("shouldn't merge based on content hash when files are empty", async function () {
it.skip("should merge identical attachments based on content hash when unindexed", async function () {
let item1 = await createDataObject('item');
let attachment1 = await importPDFAttachment(item1);
let item2 = item1.clone();
await item2.saveTx();
let attachment2 = await importFileAttachment('duplicatesMerge_test_new_md5.pdf', { parentItemID: item2.id });
await Zotero.DB.executeTransaction(async () => {
await Zotero.FullText.clearItemWords(attachment1.id);
await Zotero.FullText.clearItemWords(attachment2.id);
});
await Zotero.Items.merge(item1, [item2]);
assert.isFalse(item1.deleted);
assert.isFalse(attachment1.deleted);
assert.equal(item1.numAttachments(true), 1);
assert.isTrue(item2.deleted);
assert.isTrue(attachment2.deleted);
});
it("shouldn't merge attachments based on content hash when files are empty", async function () {
let item1 = await createDataObject('item', { setTitle: true });
let attachment1 = await importFileAttachment('empty.pdf', { parentItemID: item1.id });