mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix error generating context menu for multiple standalone attachments

Browse source 
Regression from f161d167ae
This commit is contained in:
Dan Stillman 2021-12-26 23:15:47 -05:00
parent 14caa3a895
commit 24104dc685
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
chrome/content/zotero/zoteroPane.js
View file

@ -3075,6 +3075,7 @@ var ZoteroPane = new function()
function attachmentsWithExtractableAnnotations(item) { function attachmentsWithExtractableAnnotations(item) {
if (!item.isRegularItem()) return [];
return Zotero.Items.get(item.getAttachments()) return Zotero.Items.get(item.getAttachments())
.filter(item => isAttachmentWithExtractableAnnotations(item)); .filter(item => isAttachmentWithExtractableAnnotations(item));
} }

10
test/tests/zoteroPaneTest.js
View file

@ -801,4 +801,14 @@ describe("ZoteroPane", function() {
assert.lengthOf(Object.keys(conditions), 3); assert.lengthOf(Object.keys(conditions), 3);
}); });
}); });
describe("#buildItemContextMenu()", function () {
it("should build menu for multiple standalone file attachments", async function () {
var item1 = await importFileAttachment('test.png');
var item2 = await importFileAttachment('test.png');
await zp.selectItems([item1.id, item2.id]);
await zp.buildItemContextMenu();
});
});
}) })