mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix indexing files with text content types that Firefox won't display (#3708)

Browse source
This commit is contained in:
Abe Jellinek 2024-02-19 05:11:16 -05:00 • committed by GitHub
parent 24cb38cfc8
commit 1f599283df
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 45 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
test/tests/fulltextTest.js
View file

@ -65,6 +65,29 @@ describe("Zotero.FullText", function () {
Zotero.Fulltext.INDEX_STATE_UNINDEXED
);
})
describe("Indexing with HiddenBrowser", () => {
it("should index attachment as its attachmentContentType when supported", async function () {
// Firefox would normally load this as text/x-shellscript, but we detect text/plain
let item = await importFileAttachment('test.sh');
assert.equal(item.attachmentContentType, 'text/plain');
assert.equal(await Zotero.Fulltext.getIndexedState(item), Zotero.Fulltext.INDEX_STATE_INDEXED);
});
it("should index attachment as text/plain when its text/* attachmentContentType is unsupported", async function () {
// Now we force text/x-shellscript, which the HiddenBrowser would normally refuse to load
// It should still load, because we fall back to text/plain from an unsupported text/* content type
let item = await importFileAttachment('test.sh', { contentType: 'text/x-shellscript' });
assert.equal(item.attachmentContentType, 'text/x-shellscript');
assert.equal(await Zotero.Fulltext.getIndexedState(item), Zotero.Fulltext.INDEX_STATE_INDEXED);
});
it("should not index attachment with non-text attachmentContentType", async function () {
let item = await importFileAttachment('test.txt', { contentType: 'image/png' });
assert.equal(item.attachmentContentType, 'image/png');
assert.equal(await Zotero.Fulltext.getIndexedState(item), Zotero.Fulltext.INDEX_STATE_UNINDEXED);
});
});
});
describe("#indexPDF()", function () {