mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix attachment column icon flickering upon selection (#3695)

Browse source
This commit is contained in:
Tom Najdek 2024-02-19 11:04:28 +01:00 • committed by GitHub
parent 826774b1f7
commit 24cb38cfc8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
chrome/content/zotero/xpcom/data/item.js
View file

@ -2729,7 +2729,13 @@ Zotero.Item.prototype._updateAttachmentStates = function (exists) {
Zotero.logError(`Attachment parent ${this.libraryID}/${parentKey} doesn't exist`);
return;
}
item.clearBestAttachmentState();
if (item._bestAttachmentState?.key && this.key === item._bestAttachmentState.key) {
item._bestAttachmentState.exists = exists;
}
else {
item.clearBestAttachmentState();
}
};
@ -3701,7 +3707,11 @@ Zotero.Item.prototype.getBestAttachment = Zotero.Promise.coroutine(function* ()
throw ("getBestAttachment() can only be called on regular items");
}
var attachments = yield this.getBestAttachments();
return attachments ? attachments[0] : false;
let bestAttachment = attachments ? attachments[0] : false;
if (bestAttachment) {
this._bestAttachmentState = { key: bestAttachment.key, ...(this._bestAttachmentState || {}) };
}
return bestAttachment;
});