zotero/.eslintrc

{
	"env": {
		"browser": true,
		"es6": true,
		"node": true
	},
	"globals": {
		"Zotero": false,
		"ZOTERO_CONFIG": false,
		"AddonManager": false,
		"Cc": false,
		"Ci": false,
		"ChromeUtils": false,
		"Components": false,
		"ConcurrentCaller": false,
		"ctypes": false,
		"OS": false,
		"MozXULElement": false,
		"PluralForm": false,
		"Services": false,
		"windowUtils": false,
		"XPCOMUtils": false,
		"XRegExp": false,
		"XULElement": false,
		"XULElementBase": false,
		"Cu": false,
		"ChromeWorker": false,
		"Localization": false,
		"L10nFileSource": false,
		"L10nRegistry": false,
		"ZoteroPane_Local": false,
		"ZoteroPane": false,
		"Zotero_Tabs": false,
		"ZoteroItemPane": false,
		"IOUtils": false,
		"NetUtil": false,
		"FileUtils": false,
		"globalThis": false
	},
	"extends": [
		"@zotero",
		"plugin:react/recommended"
	],
	"parser": "@babel/eslint-parser",
	"parserOptions": {
		"ecmaVersion": 2018,
		"ecmaFeatures": {
			"jsx": true
		},
		"sourceType": "module"
	},
	"plugins": [
		"react",
		"@babel"
	],
	"settings": {
		"react": {
			"version": "17.0"
		}
	},
	"rules": {}
}
Add preliminary eslint config None of our existing files match these rules perfectly, but they're something to aspire to. I've only checked a handful of files, so there may be some unwanted or missing rules, and there are definitely some missing globals. Some of our more common spacing inconsistencies are currently set as warnings rather than errors so they can be easily disabled to see more dangerous stuff. At some point we can use --fix to correct many problems in existing files, but we should go through existing pull requests before doing that to avoid conflicts. Eventually, we'll want to enforce linting as part of a pre-push hook and CI. 2019-01-21 07:57:46 +00:00			`{`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`"env": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"browser": true,`
			`"es6": true,`
			`"node": true`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
			`"globals": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"Zotero": false,`
			`"ZOTERO_CONFIG": false,`
			`"AddonManager": false,`
			`"Cc": false,`
			`"Ci": false,`
fx-compat: Add `ChromeUtils` as eslint global 2022-06-19 07:46:16 +00:00			`"ChromeUtils": false,`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"Components": false,`
			`"ConcurrentCaller": false,`
			`"ctypes": false,`
			`"OS": false,`
fx-compat: Convert itembox XBL to custom element Still lots of things to fix, particularly with styling, but the basic functionality is there. 2020-08-05 03:20:35 +00:00			`"MozXULElement": false,`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"PluralForm": false,`
			`"Services": false,`
Implement Windows redesign for native elements (#3727) 2024-03-02 07:51:55 +00:00			`"windowUtils": false,`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"XPCOMUtils": false,`
fx-compat: Convert itembox XBL to custom element Still lots of things to fix, particularly with styling, but the basic functionality is there. 2020-08-05 03:20:35 +00:00			`"XRegExp": false,`
Add main window hooks for plugins (#3238) 2023-07-31 09:09:33 +00:00			`"XULElement": false,`
Implement attachment preview - Implement attachment preview - Implement attachment-box redesign - Make filename editable - Use new reindex icon - Update attachment note layout - Fix reader.js eslint errors - Add fallback attachment icon and use redesign - Use attachment preview for regular items - Fix pinned pane not exists error - Double click preview to open to page - Fix itemPane pin bug - Preload preview iframe - Fix item pane scroll - Add media preview support - Fix item pane scroll bar on macos - Fix reader sidebar with standalone attachment - Fix attributeChangedCallback - Add attachmentBox _updateAttachmentIDs - Make attachment notes readonly and simplify note window script - Implement convert attachment note to new note - Support preview dragging - Annotations box redesign - Support custom buttons in the collapsible-section - Add preview toggle button - Fix collapsible section attribute listener - Make attachment box notify sync to fix errors in test 2023-12-25 05:51:53 +00:00			`"XULElementBase": false,`
Add main window hooks for plugins (#3238) 2023-07-31 09:09:33 +00:00			`"Cu": false,`
			`"ChromeWorker": false,`
			`"Localization": false,`
			`"L10nFileSource": false,`
			`"L10nRegistry": false,`
Fix itemBox.js eslint errors (#3244) 2023-08-04 08:15:08 +00:00			`"ZoteroPane_Local": false,`
Use IOUtils instead of OS.File 2023-07-05 16:54:18 +00:00			`"ZoteroPane": false,`
Implement attachment preview - Implement attachment preview - Implement attachment-box redesign - Make filename editable - Use new reindex icon - Update attachment note layout - Fix reader.js eslint errors - Add fallback attachment icon and use redesign - Use attachment preview for regular items - Fix pinned pane not exists error - Double click preview to open to page - Fix itemPane pin bug - Preload preview iframe - Fix item pane scroll - Add media preview support - Fix item pane scroll bar on macos - Fix reader sidebar with standalone attachment - Fix attributeChangedCallback - Add attachmentBox _updateAttachmentIDs - Make attachment notes readonly and simplify note window script - Implement convert attachment note to new note - Support preview dragging - Annotations box redesign - Support custom buttons in the collapsible-section - Add preview toggle button - Fix collapsible section attribute listener - Make attachment box notify sync to fix errors in test 2023-12-25 05:51:53 +00:00			`"Zotero_Tabs": false,`
			`"ZoteroItemPane": false,`
Fix ESLint in utilities_internal.js 2024-01-07 09:40:33 +00:00			`"IOUtils": false,`
			`"NetUtil": false,`
			`"FileUtils": false,`
			`"globalThis": false`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
			`"extends": [`
Inherit ESLint config 2019-04-01 01:12:10 +00:00			`"@zotero",`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"plugin:react/recommended"`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`],`
Update Babel and ESLint 2021-12-23 09:53:46 +00:00			`"parser": "@babel/eslint-parser",`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`"parserOptions": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"ecmaVersion": 2018,`
			`"ecmaFeatures": {`
			`"jsx": true`
			`},`
			`"sourceType": "module"`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
			`"plugins": [`
Update Babel and ESLint 2021-12-23 09:53:46 +00:00			`"react",`
			`"@babel"`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`],`
			`"settings": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"react": {`
Update Babel and ESLint 2021-12-23 09:53:46 +00:00			`"version": "17.0"`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`}`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
Inherit ESLint config 2019-04-01 01:12:10 +00:00			`"rules": {}`
Add preliminary eslint config None of our existing files match these rules perfectly, but they're something to aspire to. I've only checked a handful of files, so there may be some unwanted or missing rules, and there are definitely some missing globals. Some of our more common spacing inconsistencies are currently set as warnings rather than errors so they can be easily disabled to see more dangerous stuff. At some point we can use --fix to correct many problems in existing files, but we should go through existing pull requests before doing that to avoid conflicts. Eventually, we'll want to enforce linting as part of a pre-push hook and CI. 2019-01-21 07:57:46 +00:00			`}`