zotero/.eslintrc

{
	"env": {
		"browser": true,
		"es6": true,
		"node": true
	},
	"globals": {
		"Zotero": false,
		"ZOTERO_CONFIG": false,
		"AddonManager": false,
		"Cc": false,
		"Ci": false,
		"ChromeUtils": false,
		"Components": false,
		"ConcurrentCaller": false,
		"ctypes": false,
		"OS": false,
		"MozXULElement": false,
		"PluralForm": false,
		"Services": false,
		"XPCOMUtils": false,
		"XRegExp": false,
		"XULElement": false
	},
	"extends": [
		"@zotero",
		"plugin:react/recommended"
	],
	"parser": "@babel/eslint-parser",
	"parserOptions": {
		"ecmaVersion": 2018,
		"ecmaFeatures": {
			"jsx": true
		},
		"sourceType": "module"
	},
	"plugins": [
		"react",
		"@babel"
	],
	"settings": {
		"react": {
			"version": "17.0"
		}
	},
	"rules": {}
}
Add preliminary eslint config None of our existing files match these rules perfectly, but they're something to aspire to. I've only checked a handful of files, so there may be some unwanted or missing rules, and there are definitely some missing globals. Some of our more common spacing inconsistencies are currently set as warnings rather than errors so they can be easily disabled to see more dangerous stuff. At some point we can use --fix to correct many problems in existing files, but we should go through existing pull requests before doing that to avoid conflicts. Eventually, we'll want to enforce linting as part of a pre-push hook and CI. 2019-01-21 07:57:46 +00:00			`{`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`"env": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"browser": true,`
			`"es6": true,`
			`"node": true`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
			`"globals": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"Zotero": false,`
			`"ZOTERO_CONFIG": false,`
			`"AddonManager": false,`
			`"Cc": false,`
			`"Ci": false,`
fx-compat: Add `ChromeUtils` as eslint global 2022-06-19 07:46:16 +00:00			`"ChromeUtils": false,`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"Components": false,`
			`"ConcurrentCaller": false,`
			`"ctypes": false,`
			`"OS": false,`
fx-compat: Convert itembox XBL to custom element Still lots of things to fix, particularly with styling, but the basic functionality is there. 2020-08-05 03:20:35 +00:00			`"MozXULElement": false,`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"PluralForm": false,`
			`"Services": false,`
			`"XPCOMUtils": false,`
fx-compat: Convert itembox XBL to custom element Still lots of things to fix, particularly with styling, but the basic functionality is there. 2020-08-05 03:20:35 +00:00			`"XRegExp": false,`
			`"XULElement": false`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
			`"extends": [`
Inherit ESLint config 2019-04-01 01:12:10 +00:00			`"@zotero",`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"plugin:react/recommended"`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`],`
Update Babel and ESLint 2021-12-23 09:53:46 +00:00			`"parser": "@babel/eslint-parser",`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`"parserOptions": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"ecmaVersion": 2018,`
			`"ecmaFeatures": {`
			`"jsx": true`
			`},`
			`"sourceType": "module"`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
			`"plugins": [`
Update Babel and ESLint 2021-12-23 09:53:46 +00:00			`"react",`
			`"@babel"`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`],`
			`"settings": {`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`"react": {`
Update Babel and ESLint 2021-12-23 09:53:46 +00:00			`"version": "17.0"`
Fix .eslintrc whitespace, but properly this time 2019-03-06 08:42:30 +00:00			`}`
Convert spaces to tabs in .eslintrc 2019-03-05 06:14:36 +00:00			`},`
Inherit ESLint config 2019-04-01 01:12:10 +00:00			`"rules": {}`
Add preliminary eslint config None of our existing files match these rules perfectly, but they're something to aspire to. I've only checked a handful of files, so there may be some unwanted or missing rules, and there are definitely some missing globals. Some of our more common spacing inconsistencies are currently set as warnings rather than errors so they can be easily disabled to see more dangerous stuff. At some point we can use --fix to correct many problems in existing files, but we should go through existing pull requests before doing that to avoid conflicts. Eventually, we'll want to enforce linting as part of a pre-push hook and CI. 2019-01-21 07:57:46 +00:00			`}`