38 lines
2.1 KiB
Markdown
38 lines
2.1 KiB
Markdown
<!--
|
|
Thanks for contributing to the project!
|
|
Please help us keep this project in good shape by going through this checklist.
|
|
Replace the empty checkboxes [ ] below with checked ones [X] as they are completed
|
|
Remember, you can preview this before saving it.
|
|
-->
|
|
|
|
<!-- You can remove this first section if you have contributed before -->
|
|
|
|
### First time contributor checklist:
|
|
|
|
- [ ] I have read the [README](https://github.com/signalapp/Signal-Desktop/blob/master/README.md) and [Contributor Guidelines](https://github.com/signalapp/Signal-Desktop/blob/master/CONTRIBUTING.md)
|
|
- [ ] I have signed the [Contributor Licence Agreement](https://signal.org/cla/)
|
|
|
|
### Contributor checklist:
|
|
|
|
- [ ] My contribution is **not** related to translations. _Please submit translation changes via our [Signal Desktop Transifex project](https://www.transifex.com/signalapp/signal-desktop/)._
|
|
- [ ] My commits are in nice logical chunks with [good commit messages](http://chris.beams.io/posts/git-commit/)
|
|
- [ ] My changes are [rebased](https://medium.freecodecamp.org/git-rebase-and-the-golden-rule-explained-70715eccc372) on the latest [`development`](https://github.com/signalapp/Signal-Desktop/tree/development) branch
|
|
- [ ] A `yarn ready` run passes successfully ([more about tests here](https://github.com/signalapp/Signal-Desktop/blob/master/CONTRIBUTING.md#tests))
|
|
- [ ] My changes are ready to be shipped to users
|
|
|
|
### Description
|
|
|
|
<!--
|
|
Describe briefly what your pull request changes. Focus on the value provided to users.
|
|
|
|
Does it address any outstanding issues in this project?
|
|
https://github.com/signalapp/Signal-Desktop/issues?utf8=%E2%9C%93&q=is%3Aissue
|
|
Reference an issue with the hash symbol: "#222"
|
|
If you're fixing it, use something like "Fixes #222"
|
|
|
|
Please write a summary of your test approach:
|
|
- What kind of manual testing did you do?
|
|
- Did you write any new tests?
|
|
- What operating systems did you test with? (please use specific versions: http://whatsmyos.com/)
|
|
- What other devices did you test with? (other Desktop devices, Android, Android Simulator, iOS, iOS Simulator)
|
|
-->
|