Commit graph

3747 commits

Author SHA1 Message Date
Scott Nonnenberg
c02860af5c
Responding to pull request review feedback
- messages.getQuoteObjectUrl: early return
- backup.js: explaining variables for long if statement
- types/messages.js: Log if thumbnail has neither data nor path
- sendmessage.js:
  - remove extraneous logging
  - fix indentation
  - upload attachments and thumbnails in parallel
- preload: don't load fs for tests, just fse
- _conversation.scss: split two selectors into two lines, 0px -> 0
- backup_test.js: use fse.existsSync and comment twoSlashes regex
- network_tests_view_test.js: Comment duplicate assignment to window.getSocketStatus
2018-04-23 15:36:47 -07:00
Scott Nonnenberg
6ec6bf08c8
Backup E2E test: Normalize paths because glob returns / on WIN 2018-04-20 17:29:55 -07:00
Scott Nonnenberg
bd17c298a2
Android Dark theme: refactor, increase contrast in outgoing 2018-04-20 17:08:20 -07:00
Scott Nonnenberg
1bfc1ed63e
Backup E2E test: Fix path analysis on windows 2018-04-20 16:56:39 -07:00
Scott Nonnenberg
fdc13d0af3
Fix some tslint errors
I really need to get it running in my editor!
2018-04-20 16:19:53 -07:00
Scott Nonnenberg
bd88407b78
iOS theme: Permanant background to attachment part of bubble
(this is to handle a quote making bubble wider, but a narrow image)
2018-04-20 16:02:33 -07:00
Scott Nonnenberg
ba4b033db9
Disable sending of quoted replies for now 2018-04-20 15:26:44 -07:00
Scott Nonnenberg
21713cbce7
Update quotes to render emoji just like normal messages 2018-04-20 15:24:05 -07:00
Scott Nonnenberg
a7d44d3344
Backup and end-to-end test! 2018-04-20 15:24:04 -07:00
Scott Nonnenberg
c3acf43c47
Eslintify test/backup_test.js 2018-04-20 15:24:04 -07:00
Scott Nonnenberg
d0bcf506b4
Put focus in the message composition field on reply 2018-04-20 15:24:03 -07:00
Scott Nonnenberg
3abaeb807d
Prevent infinite repeated errors on leaving electron tests open 2018-04-20 15:24:03 -07:00
Scott Nonnenberg
334fe32210
Fix electron test race condition with protobuf loading 2018-04-20 15:24:02 -07:00
Scott Nonnenberg
978ff0e2bb
Refactor: Use correct name for sanitized filename in backup.js 2018-04-20 15:24:02 -07:00
Scott Nonnenberg
770410ee88
Remove borders that didn't render well
Android: The gray border around the quote didn't interact well with the
image, which needed to overlap the border. For now we'll just remove the
border.

Also made the thumbnail image 2px bigger because I noticed that in some
cases there was a partial-pixel space below the image (where the rest of
the quote was making the container bigger).

iOS: The gray border around outgoing quotes was fading into the
background gray color, making the quote look a tiny bit more narrow than
the main message. Removed the border.
2018-04-20 15:24:02 -07:00
Scott Nonnenberg
26dd01c4fd
Make sent quote clickable - process after adding to conversation 2018-04-20 15:24:01 -07:00
Scott Nonnenberg
73edabfb17
Full pipeline to send quotes, including thumbnail upload 2018-04-20 15:23:57 -07:00
Scott Nonnenberg
13ce056830
Make thumbnails on quote load and on quote preview creation 2018-04-20 15:23:56 -07:00
Scott Nonnenberg
37cac717cb
Use fit: cover for non-square thumbnails, better movie icon
Also: Match Android's X button in the quote composition area
2018-04-20 15:23:55 -07:00
Scott Nonnenberg
12257e1560
MessageView: Show menu w/ 'reply to message' on triple-dot click 2018-04-20 15:23:55 -07:00
Scott Nonnenberg
f4d9ab8ba0
Put quote preview in text box for Android, above it in iOS 2018-04-20 15:23:54 -07:00
Scott Nonnenberg
d4220e278d
MessageView: Remove logging 2018-04-20 15:23:53 -07:00
Scott Nonnenberg
afad1a8d77
conversation_view: Remove logging in quote handling 2018-04-20 15:23:52 -07:00
Scott Nonnenberg
c71dcf0139
Show current quoted message above composition field
Note that substantial changes will be required for the updated Android
mockups, putting the quotation into the text box next to the attachment
preview.
2018-04-20 15:23:51 -07:00
Scott Nonnenberg
e66f9faf33
MessageView refactor: reply -> quote 2018-04-20 15:23:51 -07:00
Scott Nonnenberg
d29162f3b6
CSS Refactor: Pull quote CSS out from parent classes
This is to prepare for it to be shown in the message composition area.
2018-04-20 15:23:50 -07:00
Scott Nonnenberg
b4ff223d18
Refactor: Push selector logic for quote props into Message model 2018-04-20 15:23:49 -07:00
Scott Nonnenberg
d0b11c59f5
Eslintify conversation_view.js 2018-04-20 15:23:49 -07:00
Scott Nonnenberg
26e4e97592
Tighten up CSS
- Remove extra padding at top of Android bubbles, via sibling selector
- Don't include .attachments, .quote-wrapper, .content in bubble unless
  we actually need them. This allows for sibling selectors.
- This is a different technique for adding the ReactWrapperView for
  quotes - it is now appended to the DOM instead of attaching to
  something already in the DOM. This allows us to use .remove(), so it's
  a bit cleaner.
- Users of ReactWrapperView can now specify tagName and className
2018-04-20 15:23:47 -07:00
Scott Nonnenberg
30957341e4
Show three dot icon next to message on hover
But only if it doesn't have an error.

Also: reformatted message template in legacy_templates.js to match what
is in background.html for easier diffing.
2018-04-20 15:23:47 -07:00
Scott Nonnenberg
a563dc8b37
Style Guide: Additional message examples, a few fixes to enable 2018-04-20 15:23:47 -07:00
Scott Nonnenberg
6a4acc813c
iOS: Center images in bubble, shrink bubble down to image size 2018-04-20 15:23:46 -07:00
Scott Nonnenberg
5af5bbdb0f
Add style guide examples for portrait/landscape images 2018-04-20 15:23:46 -07:00
Bisaloo
89d3078e2a Fix beta install instructions for debian-based linux (#2262) 2018-04-19 08:56:08 -07:00
Scott Nonnenberg
3dbc550db2
v1.8.0-beta.1
Receive quoted replies (#2244)

iOS theme: one bubble for both attachment and message contents (#2244)

Improve URL Auto-Linking In Messages (#2240)

Redact More Variants Of Paths In Stack Traces (#2229)

Fixed: Conversation message preview would sometimes continue to show after message disappeared (1206b3c448)

Dev: Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219 and #2232)
2018-04-16 13:14:18 -07:00
Scott Nonnenberg
8fa0912fb3
Receive quoted replies, collapsed iOS bubbles (#2244)
Complete support for receiving quoted replies, and a big change to the iOS theme. Instead of attachments showing up in a separate bubble from their associated caption, they are now in the same bubble.
2018-04-16 13:10:10 -07:00
Scott Nonnenberg
e3d15d80f6
Quote.md: Fix image example, add examples for attachment + reply 2018-04-16 13:02:51 -07:00
Scott Nonnenberg
bb9859ca61
Make iOS quote theming apply in the message detail screen 2018-04-16 12:30:28 -07:00
Scott Nonnenberg
000dc3a159
Handle attachment load failure for quoted message 2018-04-16 12:17:13 -07:00
Scott Nonnenberg
f1ff040842
Finish type definition for _mapQuotedAttachments 2018-04-16 12:16:34 -07:00
Scott Nonnenberg
73e1498403
messages.json: Fix typo in replacement string 2018-04-16 12:16:11 -07:00
Scott Nonnenberg
4e9abdf348
MessageView: Call the proper render method on change event 2018-04-13 18:44:19 -07:00
Scott Nonnenberg
7bd747a796
ConversationContext: conversationType => type
And a group conversation example to messages.md
2018-04-13 18:10:52 -07:00
Scott Nonnenberg
d8d803d36d
Center and limit the size of non-square thumbnails in quotes 2018-04-13 18:10:52 -07:00
Scott Nonnenberg
3bbbf65a6b
Fix iOS: tail, blue partial border, extra attachment space
Turns out that display: inline on the img tag resulted in a mysterious
3px of space added below it.
2018-04-13 18:10:52 -07:00
Scott Nonnenberg
feb68b24b4
Fix lint issues in message_receiver.js 2018-04-13 18:10:52 -07:00
Scott Nonnenberg
a806f32675
Fix message_receiver 2018-04-13 18:10:52 -07:00
Scott Nonnenberg
04d186c05a
Conversation.loadQuoteThumbnail: Be resilient to no attachments 2018-04-13 18:10:52 -07:00
Scott Nonnenberg
a6467d4fda
Constrain 'start recording' event listener to capture-audio only
(it was firing when clicking on a microphone icon in quotation!)
2018-04-13 18:10:52 -07:00
Scott Nonnenberg
06c70b0ff4
Don't fail message load if we can't load quote thumbnail 2018-04-13 18:10:51 -07:00