Rename shouldShowAudioNotificationSetting

Use `isAudioNotificationSupported` to make it less presentation layer specific.

background.html

@@ -606,12 +606,12 @@
         </div>
       </div>
       <br />
-      {{ #shouldShowAudioNotificationSetting }}
+      {{ #isAudioNotificationSupported }}
       <div class='audio-notification-setting'>
         <input type='checkbox' name='audio-notification' id='audio-notification'/>
         <label for='audio-notification'>{{ audioNotificationDescription }}</label>
       </div>
-      {{ /shouldShowAudioNotificationSetting }}
+      {{ /isAudioNotificationSupported }}
     </div>
   </script>
   <script type='text/x-tmpl-mustache' id='syncSettings'>

js/modules/types/settings.js

@@ -1,4 +1,4 @@
 const OS = require('../os');
 
-exports.shouldShowAudioNotificationSetting = () =>
+exports.isAudioNotificationSupported = () =>
   !OS.isLinux();

js/views/settings_view.js

@@ -70,7 +70,7 @@
                 name: 'theme-setting',
                 event: 'change-theme'
             });
-            if (Settings.shouldShowAudioNotificationSetting()) {
+            if (Settings.isAudioNotificationSupported()) {
                 new CheckboxView({
                     el: this.$('.audio-notification-setting'),
                     defaultValue: false,
@@ -104,8 +104,7 @@
               noNameOrMessage: i18n('noNameOrMessage'),
               nameOnly: i18n('nameOnly'),
               audioNotificationDescription: i18n('audioNotificationDescription'),
-              shouldShowAudioNotificationSetting:
+              isAudioNotificationSupported: Settings.isAudioNotificationSupported(),
-                Settings.shouldShowAudioNotificationSetting(),
               themeAndroidDark: i18n('themeAndroidDark'),
               hideMenuBar: i18n('hideMenuBar'),
             };

test/modules/types/settings_test.js

@@ -7,7 +7,7 @@ const Settings = require('../../../js/modules/types/settings');
 describe('Settings', () => {
   const sandbox = sinon.createSandbox();
 
-  describe('shouldShowAudioNotificationSetting', () => {
+  describe('isAudioNotificationSupported', () => {
     context('on macOS', () => {
       beforeEach(() => {
         sandbox.stub(process, 'platform').value('darwin');
@@ -18,7 +18,7 @@ describe('Settings', () => {
       });
 
       it('should return true', () => {
-        assert.isTrue(Settings.shouldShowAudioNotificationSetting());
+        assert.isTrue(Settings.isAudioNotificationSupported());
       });
     });
 
@@ -32,7 +32,7 @@ describe('Settings', () => {
       });
 
       it('should return true', () => {
-        assert.isTrue(Settings.shouldShowAudioNotificationSetting());
+        assert.isTrue(Settings.isAudioNotificationSupported());
       });
     });
 
@@ -46,7 +46,7 @@ describe('Settings', () => {
       });
 
       it('should return false', () => {
-        assert.isFalse(Settings.shouldShowAudioNotificationSetting());
+        assert.isFalse(Settings.isAudioNotificationSupported());
       });
     });
   });