From 85b121aca4da5cf3245e5f32660dfe87506d568e Mon Sep 17 00:00:00 2001
From: Daniel Gasienica <daniel@gasienica.ch>
Date: Mon, 26 Feb 2018 13:26:40 -0500
Subject: [PATCH] Rename `shouldShowAudioNotificationSetting`

Use `isAudioNotificationSupported` to make it less presentation layer specific.
---
 background.html                     | 4 ++--
 js/modules/types/settings.js        | 2 +-
 js/views/settings_view.js           | 5 ++---
 test/modules/types/settings_test.js | 8 ++++----
 4 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/background.html b/background.html
index 19865b02ac00..c9c0196bd08f 100644
--- a/background.html
+++ b/background.html
@@ -606,12 +606,12 @@
         </div>
       </div>
       <br />
-      {{ #shouldShowAudioNotificationSetting }}
+      {{ #isAudioNotificationSupported }}
       <div class='audio-notification-setting'>
         <input type='checkbox' name='audio-notification' id='audio-notification'/>
         <label for='audio-notification'>{{ audioNotificationDescription }}</label>
       </div>
-      {{ /shouldShowAudioNotificationSetting }}
+      {{ /isAudioNotificationSupported }}
     </div>
   </script>
   <script type='text/x-tmpl-mustache' id='syncSettings'>
diff --git a/js/modules/types/settings.js b/js/modules/types/settings.js
index c6f9133a9991..ac5a60fe4531 100644
--- a/js/modules/types/settings.js
+++ b/js/modules/types/settings.js
@@ -1,4 +1,4 @@
 const OS = require('../os');
 
-exports.shouldShowAudioNotificationSetting = () =>
+exports.isAudioNotificationSupported = () =>
   !OS.isLinux();
diff --git a/js/views/settings_view.js b/js/views/settings_view.js
index 4d384eed7b15..db5dd9ff908b 100644
--- a/js/views/settings_view.js
+++ b/js/views/settings_view.js
@@ -70,7 +70,7 @@
                 name: 'theme-setting',
                 event: 'change-theme'
             });
-            if (Settings.shouldShowAudioNotificationSetting()) {
+            if (Settings.isAudioNotificationSupported()) {
                 new CheckboxView({
                     el: this.$('.audio-notification-setting'),
                     defaultValue: false,
@@ -104,8 +104,7 @@
               noNameOrMessage: i18n('noNameOrMessage'),
               nameOnly: i18n('nameOnly'),
               audioNotificationDescription: i18n('audioNotificationDescription'),
-              shouldShowAudioNotificationSetting:
-                Settings.shouldShowAudioNotificationSetting(),
+              isAudioNotificationSupported: Settings.isAudioNotificationSupported(),
               themeAndroidDark: i18n('themeAndroidDark'),
               hideMenuBar: i18n('hideMenuBar'),
             };
diff --git a/test/modules/types/settings_test.js b/test/modules/types/settings_test.js
index 36c1afb065a9..1ae99996b862 100644
--- a/test/modules/types/settings_test.js
+++ b/test/modules/types/settings_test.js
@@ -7,7 +7,7 @@ const Settings = require('../../../js/modules/types/settings');
 describe('Settings', () => {
   const sandbox = sinon.createSandbox();
 
-  describe('shouldShowAudioNotificationSetting', () => {
+  describe('isAudioNotificationSupported', () => {
     context('on macOS', () => {
       beforeEach(() => {
         sandbox.stub(process, 'platform').value('darwin');
@@ -18,7 +18,7 @@ describe('Settings', () => {
       });
 
       it('should return true', () => {
-        assert.isTrue(Settings.shouldShowAudioNotificationSetting());
+        assert.isTrue(Settings.isAudioNotificationSupported());
       });
     });
 
@@ -32,7 +32,7 @@ describe('Settings', () => {
       });
 
       it('should return true', () => {
-        assert.isTrue(Settings.shouldShowAudioNotificationSetting());
+        assert.isTrue(Settings.isAudioNotificationSupported());
       });
     });
 
@@ -46,7 +46,7 @@ describe('Settings', () => {
       });
 
       it('should return false', () => {
-        assert.isFalse(Settings.shouldShowAudioNotificationSetting());
+        assert.isFalse(Settings.isAudioNotificationSupported());
       });
     });
   });