mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Rename shouldShowAudioNotificationSetting

Browse source 
Use `isAudioNotificationSupported` to make it less presentation layer specific.
This commit is contained in:
Daniel Gasienica 2018-02-26 13:26:40 -05:00
parent 105eb95391
commit 85b121aca4
4 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
js/modules/types/settings.js
View file

@ -1,4 +1,4 @@
const OS = require('../os');
exports.shouldShowAudioNotificationSetting = () =>
exports.isAudioNotificationSupported = () =>
!OS.isLinux();

5
js/views/settings_view.js
View file

@ -70,7 +70,7 @@
name: 'theme-setting',
event: 'change-theme'
});
if (Settings.shouldShowAudioNotificationSetting()) {
if (Settings.isAudioNotificationSupported()) {
new CheckboxView({
el: this.$('.audio-notification-setting'),
defaultValue: false,
@ -104,8 +104,7 @@
noNameOrMessage: i18n('noNameOrMessage'),
nameOnly: i18n('nameOnly'),
audioNotificationDescription: i18n('audioNotificationDescription'),
shouldShowAudioNotificationSetting:
Settings.shouldShowAudioNotificationSetting(),
isAudioNotificationSupported: Settings.isAudioNotificationSupported(),
themeAndroidDark: i18n('themeAndroidDark'),
hideMenuBar: i18n('hideMenuBar'),
};