git-annex/Remote/Helper
Joey Hess 9f3a346f25
fix nested exception bug
Fix reversion introduced in version 6.20180316 that caused git-annex to
stop processing files when unable to contact a ssh remote.

The bug was not in any of the changed lines, but this one in inAnnex:

P2PHelper.checkpresent (Ssh.runProto rmt connpool (cantCheck rmt) fallback) key

cantCheck throws an exception, but that parameter to runProto expects a
value, which it returns. So, inAnnex is returning a Bool containing an
exception. This defeats the usual checks for checkPresent throwing an
exception, crashing git-annex.

Fixed by making runProto take an `Annex a` instead of an `a`, so
passing cantCheck to it doesn't nest exceptions.

This commit was sponsored by andrea rota.
2018-07-03 13:10:43 -04:00
..
Chunked remove 163 lines of code without changing anything except imports 2016-01-20 16:36:33 -04:00
AWS.hs S3: Support the special case endpoint needed for the cn-north-1 region. 2016-11-07 11:49:34 -04:00
Chunked.hs fix giveup shadowing 2016-11-16 00:28:10 -04:00
Encryptable.hs implement exporttree=yes configuration 2017-09-04 13:09:38 -04:00
Export.hs refactor 2017-09-20 16:22:32 -04:00
Git.hs change Remote.repo to Remote.getRepo 2018-06-04 15:30:26 -04:00
Hooks.hs remove 163 lines of code without changing anything except imports 2016-01-20 16:36:33 -04:00
Http.hs fix bad refactoring 2018-04-06 16:59:14 -04:00
Messages.hs Avoid backtraces on expected failures when built with ghc 8; only use backtraces for unexpected errors. 2016-11-15 21:29:54 -04:00
P2P.hs deal with unlocked files 2018-03-13 14:27:14 -04:00
ReadOnly.hs remove 163 lines of code without changing anything except imports 2016-01-20 16:36:33 -04:00
Special.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
Ssh.hs fix nested exception bug 2018-07-03 13:10:43 -04:00