git-annex/Remote
Joey Hess 9f3a346f25
fix nested exception bug
Fix reversion introduced in version 6.20180316 that caused git-annex to
stop processing files when unable to contact a ssh remote.

The bug was not in any of the changed lines, but this one in inAnnex:

P2PHelper.checkpresent (Ssh.runProto rmt connpool (cantCheck rmt) fallback) key

cantCheck throws an exception, but that parameter to runProto expects a
value, which it returns. So, inAnnex is returning a Bool containing an
exception. This defeats the usual checks for checkPresent throwing an
exception, crashing git-annex.

Fixed by making runProto take an `Annex a` instead of an `a`, so
passing cantCheck to it doesn't nest exceptions.

This commit was sponsored by andrea rota.
2018-07-03 13:10:43 -04:00
..
Directory remove 163 lines of code without changing anything except imports 2016-01-20 16:36:33 -04:00
External add GETINFO to external protocol (for ronnypfa) 2018-06-08 11:56:24 -04:00
Helper fix nested exception bug 2018-07-03 13:10:43 -04:00
Rsync Support exporttree=yes for rsync special remotes. 2018-02-28 13:36:20 -04:00
WebDAV webdav: Avoid unncessisarily creating the collection at the top of the repo 2017-10-11 11:10:33 -04:00
Adb.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
BitTorrent.hs Merge branch 'later' 2018-06-25 21:59:20 -04:00
Bup.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
Ddar.hs set ddar to RetrievalAllKeysSecure 2018-06-21 16:38:47 -04:00
Directory.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
External.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
GCrypt.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
Git.hs fix nested exception bug 2018-07-03 13:10:43 -04:00
Glacier.hs don't assume boto will remain secure 2018-06-21 14:14:56 -04:00
Hook.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
List.hs change Remote.repo to Remote.getRepo 2018-06-04 15:30:26 -04:00
P2P.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
Rsync.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
S3.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
Tahoe.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00
Web.hs Merge branch 'later' 2018-06-25 21:59:20 -04:00
WebDAV.hs add retrievalSecurityPolicy 2018-06-21 11:36:36 -04:00