bb4f31a0ee
Baked into the code was an assumption that a repository's git directory could be determined by adding ".git" to its work tree (or nothing for bare repos). That fails when core.worktree, or GIT_DIR and GIT_WORK_TREE are used to separate the two. This was attacked at the type level, by storing the gitdir and worktree separately, so Nothing for the worktree means a bare repo. A complication arose because we don't learn where a repository is bare until its configuration is read. So another Location type handles repositories that have not had their config read yet. I am not entirely happy with this being a Location type, rather than representing them entirely separate from the Git type. The new code is not worse than the old, but better types could enforce more safety. Added support for core.worktree. Overriding it with -c isn't supported because it's not really clear what to do if a git repo's config is read, is not bare, and is then overridden to bare. What is the right git directory in this case? I will worry about this if/when someone has a use case for overriding core.worktree with -c. (See Git.Config.updateLocation) Also removed and renamed some functions like gitDir and workTree that misused git's terminology. One minor regression is known: git annex add in a bare repository does not print a nice error message, but runs git ls-files in a way that fails earlier with a less nice error message. This is because before --work-tree was always passed to git commands, even in a bare repo, while now it's not. |
||
|---|---|---|
| .. | ||
| AutoCorrect.hs | ||
| Branch.hs | ||
| CatFile.hs | ||
| CheckAttr.hs | ||
| Command.hs | ||
| Config.hs | ||
| Construct.hs | ||
| Filename.hs | ||
| HashObject.hs | ||
| Index.hs | ||
| LsFiles.hs | ||
| LsTree.hs | ||
| Queue.hs | ||
| Ref.hs | ||
| Sha.hs | ||
| SharedRepository.hs | ||
| Types.hs | ||
| UnionMerge.hs | ||
| Url.hs | ||
| Version.hs | ||