17c9ff576d
A long time ago I made Remote be an instance of the Ord typeclass, with an implementation that compared the costs of Remotes. That seemed like a good idea at the time, as it saved typing.. But at the time I was still making custom Read and Show instances too. I've since learned that this is *not* a good idea, and neither is making custom Ord instances, without deep thought about the possible sets of values in a type. Haskell typeclasses are not a toy. This Ord instance came around and bit me when I put Remotes into a Set, because now remotes with the same cost appeared to be in the Set even if they were not. Also affected putting Remotes into a Map. Rarely does a bug go this deep. I've fixed it comprehensively, first removing the Ord instance entirely, and fixing the places that wanted to order remotes by cost to do it explicitly. Then adding back an Ord instance that is much more sane. Also by checking the rest of the Ord instances in the code base (which were all ok). While doing that, I found lots of places that kept remotes in Maps and Sets. All of it was probably subtly broken in one way or another before this fix, but it would be hard to say exactly how the bugs would manifest. |
||
|---|---|---|
| .. | ||
| Backend.hs | ||
| BranchState.hs | ||
| Command.hs | ||
| Crypto.hs | ||
| GitConfig.hs | ||
| Group.hs | ||
| Key.hs | ||
| KeySource.hs | ||
| Messages.hs | ||
| Meters.hs | ||
| Option.hs | ||
| Remote.hs | ||
| StandardGroups.hs | ||
| TrustLevel.hs | ||
| UUID.hs | ||