Commit graph

39206 commits

Author SHA1 Message Date
Joey Hess
2aa4fab62a
avoid crashing when there are remotes using unparseable urls
Including the non-standard URI form that git-remote-gcrypt uses for rsync.

Eg, "ook://foo:bar" cannot be parsed because "bar" is not a valid port
number. But git could have a remote with that, it would try to run
git-remote-ook to handle it. So, git-annex has to allow for such things,
rather than crashing.

This commit was sponsored by Luke Shumaker on Patreon.
2021-01-18 14:59:08 -04:00
Joey Hess
aafb7f6eb9
comment 2021-01-18 13:54:57 -04:00
Joey Hess
c0ffb5c2c4
comment 2021-01-18 13:40:31 -04:00
Joey Hess
7cc1ed1940
Merge branch 'master' of ssh://git-annex.branchable.com 2021-01-18 13:28:08 -04:00
Joey Hess
7eb54bad12
fix prop_relPathDirToFileAbs_basics fail on windows
It was just slapping on a path separator to the front of the path to
make it absolute, but on windows, a path like "//foo/bar" actually
has a network "drive" of "//foo" and so that broke the test case.

Since "a:foo" is a somehow relative path on windows
(who knows how), drop any drive from the input. But dropDrive also drops
any leading path separator, making the input path relative. So now
it should be safe to slapp on a leading path separator.
2021-01-18 13:26:10 -04:00
Lukey
541efd7476 Added a comment 2021-01-18 17:05:55 +00:00
Joey Hess
75358f98b0
update 2021-01-18 13:02:28 -04:00
Joey Hess
f89721e13f
comment 2021-01-18 12:42:34 -04:00
Joey Hess
5193aae385
Bug fix: Fix tilde expansion in ssh urls when the tilde is the last character in the url. Thanks, Grond for the patch. 2021-01-18 12:22:48 -04:00
Joey Hess
a9bf2a6cad
Merge branch 'master' of ssh://git-annex.branchable.com 2021-01-18 12:18:23 -04:00
yarikoptic
02e1af71af initial report on prop_relPathDirToFileAbs_basics windows FAIL 2021-01-18 15:50:24 +00:00
Lukey
46aff11afc Added a comment 2021-01-18 14:31:06 +00:00
Lukey
7f72314bf3 Added a comment 2021-01-18 14:11:45 +00:00
Lukey
4f4ee314e9 2021-01-18 14:02:19 +00:00
seanl@fe5df935169a5440a52bdbfc5fece85cdd002d68
a70cd409e2 Added a comment: Works fine after changing mount point 2021-01-17 07:24:38 +00:00
seanl@fe5df935169a5440a52bdbfc5fece85cdd002d68
0c39105355 2021-01-17 06:36:20 +00:00
Joey Hess
ea5c3b4491
improve 2021-01-15 11:31:08 -04:00
grond66@79ca29ba964cd0d8e2f352871d54452e4a9dad88
75988a790e 2021-01-15 13:07:28 +00:00
grond66@79ca29ba964cd0d8e2f352871d54452e4a9dad88
33f9edbd0f 2021-01-15 13:01:50 +00:00
mih
eaf7e67475 Added a comment 2021-01-15 08:32:58 +00:00
grond66@79ca29ba964cd0d8e2f352871d54452e4a9dad88
8b57cc6c00 2021-01-15 02:24:25 +00:00
eric.w@eee65cd362d995ced72640c7cfae388ae93a4234
48fc69120b removed 2021-01-14 22:16:20 +00:00
eric.w@eee65cd362d995ced72640c7cfae388ae93a4234
88c007493d removed 2021-01-14 22:15:54 +00:00
eric.w@eee65cd362d995ced72640c7cfae388ae93a4234
a0b05c59a6 Added a comment 2021-01-14 22:15:12 +00:00
Joey Hess
0a218bf51c
close as not a git-annex bug 2021-01-13 14:51:44 -04:00
Joey Hess
6a30d04ece
Bug fix: export with -J could fail when two files had the same content.
Exporting is done inside a call to writeLockDbWhile which guarantees there
is only one process uploading to a given ExportLocation.
2021-01-13 14:50:48 -04:00
Joey Hess
fb921cd0b0
fix build warning 2021-01-13 14:48:41 -04:00
Joey Hess
5e39b7eb8d
Windows: Work around win32 length limits when dealing with lock files 2021-01-13 14:38:35 -04:00
Joey Hess
bb4dc3a399
export TestableFilePath constructor
Useful for eg, replicating failures in ghci. No need for this to be a
smart constructor, as long as it's used with valid filepaths, it's ok
and if not the test breaks.
2021-01-13 13:23:35 -04:00
Joey Hess
99ba471209
rewrite prop_relPathDirToFileAbs_basics
This was not a good test, it broke the requirement that
relPathDirToFileAbs take absolute paths. And it failed when the two
input paths were eg, the same but differently normalized.

Replaced with some tests of the real basics of that function.
2021-01-13 13:23:26 -04:00
Joey Hess
6c8205a113
close 2021-01-13 13:19:54 -04:00
Joey Hess
27fbd41193
comment 2021-01-13 12:58:21 -04:00
Joey Hess
a7c56f84fc
improve comment 2021-01-13 12:55:26 -04:00
Joey Hess
0ec7bed3c6
comment 2021-01-13 12:49:28 -04:00
Joey Hess
79f319e494
Merge branch 'master' of ssh://git-annex.branchable.com 2021-01-13 12:31:43 -04:00
Joey Hess
285151a921
include bugs/todos tagged datalad
sometimes they are not signed with an author
2021-01-13 12:30:46 -04:00
yarikoptic
3f6d1db33c initial report about fresh test fail 2021-01-13 15:18:44 +00:00
Joey Hess
dc0caef297
merge from git-repair 2021-01-11 21:57:35 -04:00
eric.w@eee65cd362d995ced72640c7cfae388ae93a4234
2d84bf9921 Added a comment 2021-01-11 22:48:27 +00:00
eric.w@eee65cd362d995ced72640c7cfae388ae93a4234
b806c22cb3 Added a comment 2021-01-11 22:42:28 +00:00
eric.w@eee65cd362d995ced72640c7cfae388ae93a4234
ff80ab5f40 Added a comment: git-annex uninit --fast 2021-01-11 22:41:04 +00:00
yarikoptic
8df98e9335 removed myself as the author, damn cut/paste ;) 2021-01-11 21:58:59 +00:00
yarikoptic
89024e25d1 assigned to datalad project 2021-01-11 21:57:26 +00:00
Joey Hess
8a1256bdf1
fixed 2021-01-11 15:55:33 -04:00
Joey Hess
d133dd9003
comment 2021-01-11 14:55:46 -04:00
Joey Hess
af88d55686
Merge branch 'master' of ssh://git-annex.branchable.com 2021-01-11 13:47:04 -04:00
Joey Hess
09b0562ec3
test: avoid unnecessary tests of variants of git remote
Configuring chunking and encryption for a git remote has no effect, so
skip testing those variants in the TestRemote call.

It would be better if TestRemote itself could do this, but it
doesn't seem possible there. There is no way to look at a Remote and
tell if it supports chunking or encryption.

Note that, while the test suite displays output as it it's testing
exporting, it actually skips doing anything for the tests when run on
the git remote. So at least does not waste time even though the output
is not ideal.

This commit was sponsored by Noam Kremen on Patreon.
2021-01-11 13:43:55 -04:00
Joey Hess
5d2a7f7764
remove blank 2021-01-11 13:15:21 -04:00
Joey Hess
29a3f071a7
update test suite after git-annex trust behavior change 2021-01-11 13:14:58 -04:00
Joey Hess
8db09feeba
fix format of message
newlines are eaten
2021-01-11 13:14:09 -04:00