Commit graph

28401 commits

Author SHA1 Message Date
arnaud@c1d1cc612a3921dc06a417301be08a3e125478c4
e0df81c6c0 2020-08-10 14:46:20 +00:00
hdclark@be373988ada6dc692f87a8eefdd600432e54f7d4
2c369fad26 Added a comment: This occurs on 9P filesystem too 2020-08-07 20:41:10 +00:00
cardoso-neto
53ed61ff58 Added a comment: omg 2020-08-07 02:41:12 +00:00
cardoso-neto
04e34a039e Added a comment: Understood. 2020-08-07 02:24:47 +00:00
Joey Hess
0948ef81f6
Merge branch 'master' of ssh://git-annex.branchable.com 2020-08-06 20:14:58 -04:00
Joey Hess
506ffea5e6
stop symlink check once the top of the working tree is reached
Avoid complaining that a file with "is beyond a symbolic link" when the
filepath is absolute and the symlink in question is not actually inside the
git repository.

This assumes that inodes remain stable while the command is running.
I think they always will, the filesystems where they are unstable change
them across mounts. (If inodes were not stable, it would just complain about
symlinks in the path that are not inside the working tree.)

(On windows, I don't want to assume anything about inodes, they could be
random numbers for all I know. But if they were, this would still be ok, as
long as windows doesn't have symlinks that are detected by isSymbolicLink.
Which seems a fair bet.)
2020-08-06 20:14:30 -04:00
kyle
683f527b3b Added a comment 2020-08-06 20:58:21 +00:00
Joey Hess
a358eb1faa
comment 2020-08-06 14:38:06 -04:00
Joey Hess
4288f7576a
comment 2020-08-06 13:59:22 -04:00
Joey Hess
62214244d3
Merge branch 'master' of ssh://git-annex.branchable.com 2020-08-06 13:52:19 -04:00
Joey Hess
5d380c6c5c
when workTreeItems finds a problem with a parameter, don't go on to process it
Part of workTreeItems is trying detect a case
where git porcelain refuses to process a file, and where
git ls-files silently outputs nothing. But, it's hard to perfectly
replicate git's behavior, and besides, git's behavior could change.
So it could be that we warn, but then git ls-files does not skip over
it, and so git-annex also processes it after warning about it.

So, if we think we have a problem with a parameter, display the warning,
and skip processing it at all.

Implementing this was complicated by needing to handle the case where
all command-line parameters get filtered out this way. Which is
different than the case where there are none, because we don't want to
operate on all files in this new case..
2020-08-06 13:47:45 -04:00
Joey Hess
8312cac018
comment and moreinfo 2020-08-06 11:30:44 -04:00
Joey Hess
e2a662892e
forgot to close this earlier 2020-08-06 11:22:42 -04:00
cardoso-neto
ec0fdbb95d Added a comment: Fixing URLs. 2020-08-06 03:15:00 +00:00
cardoso-neto
ffe3a26d83 Added a comment: Correction. 2020-08-06 03:09:16 +00:00
cardoso-neto
860b1f9f17 Create bug report thread on ungraceful exit after cwd being moved/baleeted 2020-08-06 02:55:32 +00:00
cardoso-neto
38d442889c Added a comment: Improperly documented code. 2020-08-06 02:52:51 +00:00
Joey Hess
9948b8b3de
update 2020-08-05 17:47:55 -04:00
Joey Hess
ce93cc43c4
update 2020-08-05 11:49:21 -04:00
Joey Hess
283d2f85d1
importfeed: Fix reversion that caused some '.' in filenames to be replaced with '_'
sanitizeFilePath was changed to sanitize leading '.', but ImportFeed was
running it on parts of the template. So eg the leading '.' in the extension
got sanitized.

Note the added case for sanitizeLeadingFilePathCharacter ('/':_)
-- this was added because, if the template is title/episode and the title
is not set, it would expand to "/episode". So this is another potential
security fix.
2020-08-05 11:35:00 -04:00
madalu
d8517d6cfc Reporting importfeed filename bug 2020-08-04 17:19:06 +00:00
Lukey
7077a7c2e7 Added a comment 2020-08-04 14:10:33 +00:00
Joey Hess
88e5ebcda7
runshell LD_HWCAP_MASK=0 optimisation 2020-08-03 14:34:15 -04:00
git-annex.branchable.com@79d6855760f61f7fbe0a401b45d8c791ef49b500
465842f3f6 Added a comment 2020-08-02 23:41:33 +00:00
yarikoptic
5a5e13e972 Added a comment 2020-08-02 01:31:53 +00:00
yarikoptic
7bd1e392dc Added a comment 2020-07-31 21:48:21 +00:00
yarikoptic
592db0629e Added a comment 2020-07-31 21:37:48 +00:00
kyle
960180dece Added a comment 2020-07-31 21:30:34 +00:00
yarikoptic
2b9d8b4e08 Added a comment 2020-07-31 21:23:57 +00:00
kyle
d844d0a1b7 Added a comment 2020-07-31 21:20:10 +00:00
Joey Hess
f5724d78d4
comment 2020-07-31 16:47:23 -04:00
Joey Hess
5a5873e052
fix bug caught by test suite 2020-07-31 16:11:50 -04:00
Joey Hess
13db029ac0
comment 2020-07-31 16:11:10 -04:00
Joey Hess
8b4e5e6f68
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-31 14:58:02 -04:00
Joey Hess
c4ec52b9ae
Slightly sped up the linux standalone bundle
Reduce the number of directories listed in libdirs, which makes the linker
check a lot less dead ends looking for directories.

Eliminated some directories that didn't really contain shared libraries,
or only contained the linker.

That left only 2, one in lib and one in usr/lib, so consolidate those two.

Doing it this way, rather than just consolidating all libs that might exist
into a single directory means that, if there are optimised versions of some
libs, eg in lib/subarch/foo.so, and lib/subarch2/foo.so, they don't get
moved around in a way that would make the linker pick the wrong one.
2020-07-31 14:42:03 -04:00
Joey Hess
676257dfa8
comment 2020-07-31 13:29:48 -04:00
kyle
7bae35d840 prop_isomorphic_key_encode test failure 2020-07-30 17:51:20 +00:00
Ilya_Shlyakhter
85e57d8260 Added a comment: streaming data and external backends 2020-07-30 15:58:24 +00:00
Ilya_Shlyakhter
6a91ddddbc Added a comment: thanks 2020-07-30 15:51:16 +00:00
Ilya_Shlyakhter
23d15dc985 Added a comment: key length 2020-07-30 15:13:53 +00:00
Joey Hess
8200b52e12
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-29 17:28:34 -04:00
Joey Hess
877d9c4283
devblog 2020-07-29 17:27:51 -04:00
Joey Hess
049807dbba
external backends implemented 2020-07-29 17:24:34 -04:00
Joey Hess
ea63d1dfe3
E variant of external backend keys 2020-07-29 17:12:22 -04:00
Joey Hess
b6fa4cb42f
external backends genKey and verifyKeyContent implemented
Only key translation for HasExt remains..
2020-07-29 16:36:32 -04:00
Joey Hess
f75be32166
external backends wip
It's able to start them up, the only thing not implemented is generating
and verifying keys. And, the key translation for HasExt.
2020-07-29 15:23:18 -04:00
Joey Hess
b5d6a36db0
note external backend names cannot end with E
also markdown improvements
2020-07-29 14:01:49 -04:00
Ilya_Shlyakhter
8bc12d3cc4 Added a comment: version correspondence of standalone builds and official releases 2020-07-29 15:36:39 +00:00
yarikoptic
6b26802047 Added a comment 2020-07-28 15:26:43 +00:00
yarikoptic
61e96d7be4 Added a comment 2020-07-28 15:18:44 +00:00
leej
2105c6e9a7 Added a comment 2020-07-28 14:58:00 +00:00
nicholsn
60f3626338 Added a comment: Thank you 2020-07-28 03:57:34 +00:00
yarikoptic
a846655d69 Added a comment 2020-07-27 21:40:55 +00:00
Joey Hess
33e5ef4164
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-27 16:57:40 -04:00
Joey Hess
3fafcc47bb
comment 2020-07-27 16:53:21 -04:00
kyle
8a594395f3 'beyond symlink' error for upstream link 2020-07-27 19:37:13 +00:00
Joey Hess
7ea8411cfb
comment 2020-07-27 11:40:30 -04:00
Joey Hess
9d9f1f85d6
comment 2020-07-27 11:37:12 -04:00
Joey Hess
36d1621c35
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-27 11:34:03 -04:00
Joey Hess
2e702960ab
followup and close 2020-07-27 11:33:47 -04:00
Joey Hess
3953c7a0ce
add DEBUG 2020-07-27 11:31:00 -04:00
ghen1
ad391da6b8 2020-07-27 15:24:21 +00:00
ghen1
1c495a856d Added a comment 2020-07-27 15:18:55 +00:00
leej
e8135f27ef 2020-07-25 00:15:34 +00:00
Ilya_Shlyakhter
c694eb2a1c Added a comment: updating the standalone distribution 2020-07-24 19:28:22 +00:00
Joey Hess
00c5f04f20
Deal with unusual IFS settings in the shell scripts for linux standalone and OSX app.
Thanks, Yaroslav Halchenko
2020-07-24 14:46:50 -04:00
Joey Hess
3627f03996
comment 2020-07-24 14:36:50 -04:00
Joey Hess
79187a6eaf
Revert "Unset IFS in shell scripts in the linux standalone build and OSX app."
This reverts commit 24125e8dc4.

yoh has a better patch I see
2020-07-24 14:33:13 -04:00
Joey Hess
24125e8dc4
Unset IFS in shell scripts in the linux standalone build and OSX app. 2020-07-24 14:31:11 -04:00
Joey Hess
2e241f92c7
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-24 14:15:44 -04:00
Joey Hess
bdda55ab6f
devblog 2020-07-24 14:15:29 -04:00
Joey Hess
32e1d7bc31
add 2020-07-24 14:11:08 -04:00
nix.zahlen@1211ac6c964ba2d68b70655f747bef1383032e77
df77d63e76 Added a comment: It is really a pitty that the Windows port / version is unmaintained 2020-07-24 17:48:10 +00:00
Joey Hess
c5ea2e9d12
better benchmark for move/copy speedup 2020-07-24 13:34:12 -04:00
Joey Hess
18f1fb5841
drop performance improvements
Sped up seeking files to drop by 2x, and also some performance
improvements to checking numcopies.

Interestingly, the seek speedup is not due to precaching, but I think is
due to calling getParsed earlier.

Annex.Drop had to be changed to check inAnnex there, since it was removed
from Command.Drop. All other users of Command.Drop already checked inAnnex
themselves.

This commit was sponsored by Ryan Newton on Patreon.
2020-07-24 13:27:46 -04:00
Joey Hess
d732ef1a89
move, copy: Sped up seeking for annexed files to operate on by a factor of nearly 2x. 2020-07-24 12:56:02 -04:00
erewhon
694c2dc16c Added a comment 2020-07-24 16:05:08 +00:00
yarikoptic
d7e04e5e3a Added a comment 2020-07-24 15:22:40 +00:00
yarikoptic
4ff59a85d5 report on intolerance of IFS 2020-07-24 01:42:59 +00:00
flpgdt@f64318f00d9e1c9535e11f5d27c80c1d799cce00
d604cd621b 2020-07-23 13:12:38 +00:00
karel-de-macil
39337c604b 2020-07-23 10:30:35 +00:00
karel-de-macil
8325db46a6 2020-07-23 10:28:43 +00:00
karel-de-macil
205d6ea3e7 Added a comment 2020-07-23 10:17:09 +00:00
karel-de-macil
c6454b9b22 2020-07-23 08:32:56 +00:00
Joey Hess
4685612f43
small git-annex get speedup
Remove an redundant inAnnex check. The checkContentPresent handles that,
and after the last commit also does in batch mode.
2020-07-22 14:29:30 -04:00
Joey Hess
1be92381ec
unify batch mode with non-batch by using AnnexedFileSeeker 2020-07-22 14:23:28 -04:00
kyle
155b56f015 Added a comment 2020-07-22 16:12:25 +00:00
mreiden
6dbe68bac5 Added a comment: Autobuild permissions 2020-07-22 16:07:22 +00:00
kyle
0538dc425c Added a comment 2020-07-22 16:01:05 +00:00
Joey Hess
d9ae6ab0b4
comment 2020-07-22 11:12:38 -04:00
Joey Hess
8da851d585
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-22 11:06:13 -04:00
Joey Hess
aa492bc659
Fix a hang when using git-annex with an old openssh 7.2p2
This does mean a 2 second delay after transfers when using that ssh, but
it's an old and apparently quite weirdly broken version of ssh.
2020-07-22 11:04:33 -04:00
Barafu
6dbef88eee 2020-07-21 23:25:06 +00:00
Joey Hess
afaae84f49
comment 2020-07-21 16:50:26 -04:00
Joey Hess
cb74cefde7
Fix a hang when using git-annex with an old openssh 7.2p2
Which had some weird inheriting of ssh FDs by sshd.

Bug was introduced in git-annex version 7.20200202.7.
2020-07-21 16:14:25 -04:00
Joey Hess
b75aa68bfa
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-21 15:31:04 -04:00
Joey Hess
ac56a5c2a0
Fix a lock file descriptor leak that could occur when running commands like git-annex add with -J
Bug was introduced as part of a different FD leak fix in version 6.20160318.
2020-07-21 15:30:47 -04:00
Joey Hess
fd8339005a
update 2020-07-21 14:44:07 -04:00
Barafu
314aef3471 2020-07-21 18:43:40 +00:00
Barafu
75d59a47d7 2020-07-21 18:42:32 +00:00