Commit graph

5309 commits

Author SHA1 Message Date
https://www.google.com/accounts/o8/id?id=AItOawmK0703vNSIQsP1mGf-4MAPnsBZiSc6yVo
70813b0e29 2014-09-19 21:45:42 +00:00
http://joeyh.name/
9ad3746abb Added a comment 2014-09-19 18:33:17 +00:00
annexuser
80232ac871 Added a comment 2014-09-19 04:43:42 +00:00
Joey Hess
2f3c3aa01f glacier, S3: Fix bug that caused embedded creds to not be encypted using the remote's key.
encryptionSetup must be called before setRemoteCredPair. Otherwise,
the RemoteConfig doesn't have the cipher in it, and so no cipher is used to
encrypt the embedded creds.

This is a security fix for non-shared encryption methods!

For encryption=shared, there's no security problem, just an
inconsistentency in whether the embedded creds are encrypted.

This is very important to get right, so used some types to help ensure that
setRemoteCredPair is only run after encryptionSetup. Note that the external
special remote bypasses the type safety, since creds can be set after the
initial remote config, if the external special remote program requests it.
Also note that IA remotes never use encryption, so encryptionSetup is not
run for them at all, and again the type safety is bypassed.

This leaves two open questions:

1. What to do about S3 and glacier remotes that were set up
   using encryption=pubkey/hybrid with embedcreds?
   Such a git repo has a security hole embedded in it, and this needs to be
   communicated to the user. Is the changelog enough?

2. enableremote won't work in such a repo, because git-annex will
   try to decrypt the embedded creds, which are not encrypted, so fails.
   This needs to be dealt with, especially for ecryption=shared repos,
   which are not really broken, just inconsistently configured.

   Noticing that problem for encryption=shared is what led to commit
   fbdeeeed5f, which tried to
   fix the problem by not decrypting the embedded creds.

This commit was sponsored by Josh Taylor.
2014-09-18 17:26:12 -04:00
http://joeyh.name/
ac635f7ada Added a comment 2014-09-18 19:28:56 +00:00
Joey Hess
4b38a572ab Merge branch 'master' of ssh://git-annex.branchable.com 2014-09-18 15:23:01 -04:00
Joey Hess
d84eab8a8a Revert "S3, Glacier, WebDAV: Fix bug that prevented accessing the creds when the repository was configured with encryption=shared embedcreds=yes."
This reverts commit fbdeeeed5f.

I can find no basis for that commit and think that I made it in error.
setRemoteCredPair always encrypts using the cipher from remoteCipher,
even when the cipher is shared.
2014-09-18 15:21:47 -04:00
http://joeyh.name/
74ad8ebb0c Added a comment 2014-09-18 18:52:17 +00:00
http://joeyh.name/
ce0f2dd114 Added a comment 2014-09-18 18:49:43 +00:00
Joey Hess
2abeae7582 Windows: Avoid crashing trying to list gpg secret keys, for gcrypt which is not yet supported on Windows. 2014-09-16 13:40:44 -04:00
Kim
734c1fa4a3 2014-09-14 22:03:23 +00:00
Joey Hess
632e5aee35 fixed 2014-09-13 16:27:07 -04:00
http://joeyh.name/
ac0945b9d0 Added a comment: turns out to be an upstream bug already filed 2014-09-12 17:46:23 +00:00
http://joeyh.name/
61b75d0475 Added a comment 2014-09-12 16:38:48 +00:00
http://joeyh.name/
6ae36f5445 Added a comment 2014-09-12 16:34:56 +00:00
http://joeyh.name/
db0f679f54 Added a comment 2014-09-12 16:03:09 +00:00
http://grossmeier.net/
cc58b5089c initial 2014-09-12 01:24:47 +00:00
https://andrew.aylett.co.uk/
64d9e0b580 Added a comment 2014-09-11 19:03:07 +00:00
Joey Hess
ea1891cbca Merge branch 'master' of ssh://git-annex.branchable.com 2014-09-11 14:50:47 -04:00
Joey Hess
9711d529c8 WORM backend: Switched to include the relative path to the file inside the repository, rather than just the file's base name. Note that if you're relying on such things to keep files separate with WORM, you should really be using a better backend. 2014-09-11 14:50:18 -04:00
http://joeyh.name/
4953fafd68 Added a comment 2014-09-11 18:41:45 +00:00
Joey Hess
ea9f66ef6a Merge branch 'master' of ssh://git-annex.branchable.com 2014-09-11 14:35:55 -04:00
Joey Hess
4c429ad7ee sync: Ensure that pending changes to git-annex branch are committed when in direct mode. (Fixing a very minor reversion.) 2014-09-11 14:35:28 -04:00
http://joeyh.name/
2139c55986 Added a comment 2014-09-11 18:34:02 +00:00
http://joeyh.name/
f08a6c96f8 Added a comment 2014-09-11 18:11:43 +00:00
Joey Hess
e82eeab3c4 close 2014-09-11 14:07:35 -04:00
Joey Hess
843396ea2f Merge branch 'master' of ssh://git-annex.branchable.com 2014-09-11 14:06:26 -04:00
Joey Hess
de05ac11af document need for msysgit installer to put it into PATH 2014-09-11 14:01:08 -04:00
http://joeyh.name/
4d4e1f9237 Added a comment 2014-09-11 17:55:28 +00:00
Joey Hess
0598412e5c Fix transfer lock file FD leak that could occur when two separate git-annex processes were both working to perform the same set of transfers. 2014-09-11 13:53:26 -04:00
http://joeyh.name/
8a4d030aae Added a comment 2014-09-11 17:45:31 +00:00
Joey Hess
c489dff1a7 dup of old, long fixed bug 2014-09-11 13:45:26 -04:00
Joey Hess
80ba5b4935 close 2014-09-11 13:39:28 -04:00
Joey Hess
9ed63d1545 Promote file not found warning message to an error. 2014-09-11 13:36:28 -04:00
Joey Hess
79deba1f51 Merge branch 'master' of ssh://git-annex.branchable.com 2014-09-11 13:22:49 -04:00
Joey Hess
a97c9e43b7 The annex-rsync-transport configuration is now also used when checking if a key is present on a rsync remote, and when dropping a key from the remote. 2014-09-11 13:21:35 -04:00
pot
5961191981 2014-09-11 06:02:37 +00:00
Joey Hess
286021cebc Merge branch 'master' of ssh://git-annex.branchable.com 2014-09-10 15:15:26 -04:00
Joey Hess
3814b664a7 retitle 2014-09-10 14:27:25 -04:00
Joey Hess
11f111bf1a Fix parsing of ipv6 address in git remote address when it was not formatted as an url. 2014-09-10 14:17:02 -04:00
Joey Hess
03dae17127 close; this is not the redhat bts 2014-09-10 14:06:38 -04:00
https://www.google.com/accounts/o8/id?id=AItOawlsL6qQTFGlP3fTJkx6JdieNbb6mM63SGk
c8e0d04292 2014-09-09 23:41:56 +00:00
CandyAngel
4d42f10206 Added a comment 2014-09-08 08:08:50 +00:00
https://www.google.com/accounts/o8/id?id=AItOawk9nck8WX8-ADF3Fdh5vFo4Qrw1I_bJcR8
863c27425f Added a comment 2014-09-08 07:27:46 +00:00
https://andrew.aylett.co.uk/
b4165bd712 2014-09-07 20:50:25 +00:00
http://id.clacke.se/
90f0991f38 Added a comment: yep 2014-09-07 19:42:04 +00:00
http://id.clacke.se/
faf8987938 Added a comment: 5.20140830 2014-09-07 19:24:49 +00:00
http://id.clacke.se/
dbf4491956 initial report 2014-09-07 19:21:17 +00:00
https://andrew.aylett.co.uk/
9ea2702cc3 Added a comment 2014-09-07 18:41:28 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmTlfbCC37CAjhQrS107ZWRVA_sF4s3gLU
d61cd586d4 2014-09-07 15:27:16 +00:00
zardoz
ab1ab57f80 Added a comment 2014-09-07 14:04:51 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmLdL4zLty4fsfaIXNtPMS5RXs4y8OAk0o
545e21a593 2014-09-05 11:24:50 +00:00
Joey Hess
0881f6d45c webapp: Fixed visual glitch in xmpp pairing.
It seems that all other uses of <div .col-sm-9> occur outside of
<div .content-box>. This one occurred inside it, when xmpp pairing.

This was introduced in the bootstrap 3 conversion.
2014-09-04 16:18:20 -04:00
https://www.google.com/accounts/o8/id?id=AItOawlMz4vAdXg8mJm4J_Bl201w65f_lK9B6A0
63ce76805c 2014-09-03 18:50:21 +00:00
https://www.google.com/accounts/o8/id?id=AItOawlog_5wIICaMcrKTexlFNA6IO6UTp323aE
bce14a6c23 Added a comment 2014-09-01 11:01:30 +00:00
http://joeyh.name/
fa172b4d2f Added a comment 2014-08-31 22:29:44 +00:00
Ganwell
3ed723f883 2014-08-31 13:41:06 +00:00
Ganwell
6fdec95c8a 2014-08-31 13:38:43 +00:00
http://svario.it/gioele
af41726e10 Added a comment 2014-08-31 10:15:31 +00:00
http://svario.it/gioele
1d84394249 Add details to the description 2014-08-31 10:09:27 +00:00
http://svario.it/gioele
7266268297 Add global configuration to test script 2014-08-31 10:05:55 +00:00
https://www.google.com/accounts/o8/id?id=AItOawknD9ZTzo_B5NIkknx8_nBGij4-ziUGcec
3c96b79e34 2014-08-30 21:58:03 +00:00
https://www.google.com/accounts/o8/id?id=AItOawknD9ZTzo_B5NIkknx8_nBGij4-ziUGcec
e83d8a5e7d 2014-08-30 21:57:13 +00:00
annexuser
af769466b8 2014-08-30 03:44:37 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmBUR4O9mofxVbpb8JV9mEbVfIYv670uJo
a71b373727 Added a comment 2014-08-28 20:46:29 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmBUR4O9mofxVbpb8JV9mEbVfIYv670uJo
462651569d removed 2014-08-28 20:46:04 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmBUR4O9mofxVbpb8JV9mEbVfIYv670uJo
836da65d70 Added a comment 2014-08-28 20:45:11 +00:00
https://www.google.com/accounts/o8/id?id=AItOawlog_5wIICaMcrKTexlFNA6IO6UTp323aE
e845892e2b 2014-08-27 19:48:31 +00:00
https://www.google.com/accounts/o8/id?id=AItOawlog_5wIICaMcrKTexlFNA6IO6UTp323aE
c19f2bf81f 2014-08-27 19:47:29 +00:00
http://bret.io/
db58ac0a0b 2014-08-27 05:06:17 +00:00
http://bret.io/
63b0830497 Added visual bug description 2014-08-26 23:30:07 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmBmv0HhwTFxkpxlf8ifTlMOHnIwHCHTYs
f8c4d80aaa Added a comment: path on windows 2014-08-26 12:18:39 +00:00
Hans_Ryding
940b92926f Added a comment: Relying on path is not best practice in a Windows environment 2014-08-25 16:16:34 +00:00
https://www.google.com/accounts/o8/id?id=AItOawld54zdyk6b0W4jXnssSO_j2Nn3W1uVsUE
6cb0e971aa Added a comment 2014-08-24 22:26:47 +00:00
https://www.google.com/accounts/o8/id?id=AItOawld54zdyk6b0W4jXnssSO_j2Nn3W1uVsUE
230eba2fd8 Added a comment 2014-08-24 20:27:09 +00:00
https://www.google.com/accounts/o8/id?id=AItOawld54zdyk6b0W4jXnssSO_j2Nn3W1uVsUE
51f129d9f4 2014-08-24 19:59:38 +00:00
https://launchpad.net/~pauli-virtanen
bd7fd9c3d9 2014-08-23 23:12:39 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmBmv0HhwTFxkpxlf8ifTlMOHnIwHCHTYs
79ccc7e347 Added a comment: path on windows 2014-08-23 22:02:07 +00:00
https://www.google.com/accounts/o8/id?id=AItOawk7iPiqWr3BVPLWEDvJhSSvcOqheLEbLNo
99771b3404 Added a comment 2014-08-23 18:13:06 +00:00
https://www.google.com/accounts/o8/id?id=AItOawk7iPiqWr3BVPLWEDvJhSSvcOqheLEbLNo
51acb30238 2014-08-23 13:59:59 +00:00
warroyo
b768cd1262 2014-08-22 22:15:27 +00:00
zardoz
6bc2419f02 Added a comment 2014-08-22 18:57:37 +00:00
zardoz
d5bce8a3b8 Added a comment 2014-08-22 14:00:42 +00:00
zardoz
3a0d342bfd Added a comment 2014-08-22 13:15:06 +00:00
zardoz
646e36d1d1 Added a comment 2014-08-22 13:07:34 +00:00
zardoz
4f189d0134 Added a comment 2014-08-22 10:15:52 +00:00
zardoz
8002704a3f Added a comment 2014-08-22 09:58:05 +00:00
zardoz
356c782ace Added a comment 2014-08-22 09:38:03 +00:00
zardoz
ef121f0d48 Added a comment 2014-08-22 09:27:34 +00:00
zardoz
71f80ad226 2014-08-22 09:08:23 +00:00
Hans_Ryding
7e0cacd273 Added a comment: Change the name of the bug 2014-08-21 09:14:16 +00:00
Hans_Ryding
1b86daa5de Added a comment: Quite right 2014-08-21 08:54:51 +00:00
http://joeyh.name/
12b2a89e91 Added a comment 2014-08-20 14:37:31 +00:00
Hans_Ryding
dfec2ffb22 2014-08-20 11:11:54 +00:00
Hans_Ryding
45b59e0ef4 2014-08-20 11:10:39 +00:00
Hans_Ryding
e5f09276bc 2014-08-20 11:09:27 +00:00
jg123h12jh3y12g3y
2bffae54ff Added a comment: Log with --debug 2014-08-20 05:49:02 +00:00
zardoz
f78da404e5 Added a comment 2014-08-18 20:54:11 +00:00
http://joeyh.name/
10bf03aa34 Added a comment 2014-08-18 18:39:33 +00:00
zardoz
d8a50f49ed Added a comment 2014-08-16 13:58:28 +00:00